From 4d6cd761d8987adee511546f644ecf5f357148ad Mon Sep 17 00:00:00 2001 From: Emmanuel Pescosta Date: Wed, 21 Oct 2015 13:45:01 +0200 Subject: [PATCH] Fix detach tab not working when path contains spaces. BUG: 352420 FIXED-IN: 15.08.3 REVIEW: 125587 --- src/dolphintabwidget.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/dolphintabwidget.cpp b/src/dolphintabwidget.cpp index ca626d47a..0b1f07e0e 100644 --- a/src/dolphintabwidget.cpp +++ b/src/dolphintabwidget.cpp @@ -25,6 +25,7 @@ #include #include +#include #include #include @@ -255,16 +256,16 @@ void DolphinTabWidget::detachTab(int index) { Q_ASSERT(index >= 0); - const QString separator(QLatin1Char(' ')); - QString command = QLatin1String("dolphin"); + QStringList args; const DolphinTabPage* tabPage = tabPageAt(index); - command += separator + tabPage->primaryViewContainer()->url().url(); + args << tabPage->primaryViewContainer()->url().url(); if (tabPage->splitViewEnabled()) { - command += separator + tabPage->secondaryViewContainer()->url().url(); - command += separator + QLatin1String("-split"); + args << tabPage->secondaryViewContainer()->url().url(); + args << QStringLiteral("--split"); } + const QString command = QStringLiteral("dolphin %1").arg(KShell::joinArgs(args)); KRun::runCommand(command, this); closeTab(index);