kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-19 16:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix visual artefacts for tooltips, if compositing has been disabled. Thanks to Maciej Mrozowski for analyzing the root cause! Also a minor issue is fixed with the upper/left position: It may never overlap with the icon area.

Browse source 
BUG: 245491

svn path=/trunk/KDE/kdebase/apps/; revision=1153521
This commit is contained in:
Peter Penz 2010-07-23 12:26:57 +00:00
parent 4189ba1e74
commit 4ba9eb8ea3
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/tooltips/tooltipmanager.cpp
View file

@ -25,6 +25,7 @@
#include "filemetadatatooltip.h"
#include <kicon.h>
#include <kio/previewjob.h>
#include <kwindowsystem.h>
#include <QApplication>
#include <QDesktopWidget>
@ -228,14 +229,14 @@ void ToolTipManager::showToolTip()
x = desktop.right() - size.width();
}
if (hasRoomBelow) {
y = m_itemRect.bottom();
y = m_itemRect.bottom() + 1;
} else {
y = m_itemRect.top() - size.height();
}
} else {
Q_ASSERT(hasRoomToLeft || hasRoomToRight);
if (hasRoomToRight) {
x = m_itemRect.right();
x = m_itemRect.right() + 1;
} else {
x = m_itemRect.left() - size.width();
}
@ -263,10 +264,12 @@ void ToolTipManager::showToolTipDelayed(const QPixmap& pixmap)
// content (QWidgets don't update their layout geometry if they are invisible). To
// assure having a consistent size without relayout flickering, the tooltip is opened
// on an invisible position first. This gives the layout system some time to asynchronously
// update the content.
const QRect desktop = QApplication::desktop()->screenGeometry(m_itemRect.bottomRight());
m_fileMetaDataToolTip->move(desktop.bottomRight());
m_fileMetaDataToolTip->show();
// update the content. Sadly this only works with compositing enabled.
if (KWindowSystem::compositingActive()) {
const QRect desktop = QApplication::desktop()->screenGeometry(m_itemRect.bottomRight());
m_fileMetaDataToolTip->move(desktop.bottomRight());
m_fileMetaDataToolTip->show();
}
m_showToolTipDelayedTimer->start(); // Calls ToolTipManager::showToolTip()
}