From 48af912b83f62b067f3e6328982e911cb068ce29 Mon Sep 17 00:00:00 2001 From: Duong Do Minh Chau Date: Mon, 28 Dec 2020 14:32:32 +0700 Subject: [PATCH] Add const --- src/settings/contextmenu/contextmenusettingspage.cpp | 8 ++++---- src/settings/contextmenu/contextmenusettingspage.h | 8 +++++--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/settings/contextmenu/contextmenusettingspage.cpp b/src/settings/contextmenu/contextmenusettingspage.cpp index 21929d569..0723fee2e 100644 --- a/src/settings/contextmenu/contextmenusettingspage.cpp +++ b/src/settings/contextmenu/contextmenusettingspage.cpp @@ -38,8 +38,8 @@ namespace } ContextMenuSettingsPage::ContextMenuSettingsPage(QWidget* parent, - KActionCollection* actions, - QStringList actionIds) : + const KActionCollection* actions, + const QStringList& actionIds) : SettingsPageBase(parent), m_initialized(false), m_serviceModel(nullptr), @@ -230,8 +230,8 @@ void ContextMenuSettingsPage::showEvent(QShowEvent* event) ContextMenuSettings::showCopyMoveMenu()); // Add other built-in actions - for (const QString& id : qAsConst(m_actionIds)) { - QAction* action = m_actions->action(id); + for (const QString& id : m_actionIds) { + const QAction* action = m_actions->action(id); if (action) { addRow(action->icon().name(), action->text(), id, entryVisible(id)); } diff --git a/src/settings/contextmenu/contextmenusettingspage.h b/src/settings/contextmenu/contextmenusettingspage.h index c35528935..88b42770f 100644 --- a/src/settings/contextmenu/contextmenusettingspage.h +++ b/src/settings/contextmenu/contextmenusettingspage.h @@ -25,7 +25,9 @@ class ContextMenuSettingsPage : public SettingsPageBase Q_OBJECT public: - explicit ContextMenuSettingsPage(QWidget* parent, KActionCollection* actions, QStringList actionIds); + explicit ContextMenuSettingsPage(QWidget* parent, + const KActionCollection* actions, + const QStringList& actionIds); ~ContextMenuSettingsPage() override; /** @see SettingsPageBase::applySettings() */ @@ -68,8 +70,8 @@ private: QListView* m_listView; QLineEdit *m_searchLineEdit; QStringList m_enabledVcsPlugins; - KActionCollection* m_actions; - QStringList m_actionIds; + const KActionCollection* m_actions; + const QStringList m_actionIds; }; #endif