From 3c7d447030bc5a9ee5a3f54ca129cdaa069ad8f6 Mon Sep 17 00:00:00 2001 From: Christian Hartmann Date: Tue, 5 Apr 2022 13:27:09 +0200 Subject: [PATCH] fix-service-menu-installer-run-script-in-konsole-on-install---uninstall service-menu-installer runs de-installation in konsole for 'uninstall.sh' but not for 'install.sh uninstall' for no discernible reason. Changes will run install.sh --uninstall as uninstall.sh in Konsole and will therefor provide user feedback if any in the script. BUG: 452292 --- .../contextmenu/servicemenuinstaller/servicemenuinstaller.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp b/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp index 9a6d2f6d6f..299680ebfc 100644 --- a/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp +++ b/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp @@ -259,7 +259,7 @@ bool runScriptVariants(const QString &path, bool hasArgVariants, const QStringLi qInfo() << "[servicemenuinstaller]: Trying to run installer/uninstaller" << path; if (hasArgVariants) { for (const auto &arg : argVariants) { - if (runScriptOnce(path, {arg}, ScriptExecution::Process)) { + if (runScriptOnce(path, {arg}, ScriptExecution::Konsole)) { return true; } }