kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-28 03:21:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Comment out assertion to fix a crash when filtering in Icons/Compat View

Browse source 
I'm not sure yet if there is a problem somewhere else in the code. For
the time being, I think it's better to replace the assert by a TODO
comment to prevent that users find out the hard way that there is
something that we're not quite sure about.

BUG: 317827
FIXED-IN: 4.10.3
This commit is contained in:
Frank Reininghaus 2013-04-22 21:36:57 +02:00
parent 151c8d8c42
commit 37e796522b
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/kitemviews/kitemlistview.cpp
View file

@ -1147,7 +1147,10 @@ void KItemListView::slotItemsRemoved(const KItemRangeList& itemRanges)
// Important: Don't read any m_layouter-property inside the for-loop in case if
// multiple ranges are given! m_layouter accesses m_sizeHintResolver which is
// updated in each loop-cycle and has only a consistent state after the loop.
Q_ASSERT(m_layouter->isDirty());
// TODO: This assert can be hit when filtering in Icons and Compact view,
// see https://bugs.kde.org/show_bug.cgi?id=317827 comments 2 and 3.
// We should try to figure out if the assert is wrong or if there is a bug in the code.
//Q_ASSERT(m_layouter->isDirty());
#endif
m_endTransactionAnimationHint = NoAnimation;
endTransaction();