mirror of
https://invent.kde.org/system/dolphin
synced 2024-08-22 01:40:02 +00:00
PlacesItemModel: remove redundant set of properties
Summary: The text, icon and url properties are already set in `PlacesItem::setBookmark()`, so there is no need to set them here. The `OnlyInApp` property is part of the KBookmark object that we are going to set to the place item, so there is no need to set it here either. Test Plan: - Open both dolphin and the Plasma file dialog in some app - Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog - Check whether the place in dolphin keeps getting updated accordingly Reviewers: #dolphin, meven, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25230
This commit is contained in:
parent
16a3aea6a6
commit
2e9f6a7abf
|
@ -588,11 +588,6 @@ void PlacesItemModel::onSourceModelDataChanged(const QModelIndex &topLeft, const
|
|||
}
|
||||
|
||||
if (placeItem && !m_sourceModel->isDevice(sourceIndex)) {
|
||||
placeItem->setText(bookmark.text());
|
||||
placeItem->setIcon(sourceIndex.data(KFilePlacesModel::IconNameRole).toString());
|
||||
placeItem->setUrl(m_sourceModel->url(sourceIndex));
|
||||
placeItem->bookmark().setMetaDataItem(QStringLiteral("OnlyInApp"),
|
||||
bookmark.metaDataItem(QStringLiteral("OnlyInApp")));
|
||||
// must update the bookmark object
|
||||
placeItem->setBookmark(bookmark);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue