From 2e4991d5f095170ab0b306bbdfb9eaa38a5f3f03 Mon Sep 17 00:00:00 2001 From: Frank Reininghaus Date: Sun, 22 Dec 2013 13:17:05 +0100 Subject: [PATCH] Fix crash when dragging children of expanded folders in Details View The problem was that the loop in KFileItemModel::createMimeData() which is supposed to find out if any parent of an item has been added to the QMimeData already (because it is not necessary to add the item in that case) did not loop through the parents of the item, but incorrectly replaced the local variable 'itemData' by its parent. BUG: 329119 REVIEW: 114562 --- src/kitemviews/kfileitemmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 4521374e6f..058248a189 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -253,7 +253,7 @@ QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const const ItemData* parent = itemData->parent; while (parent && parent != lastAddedItem) { - itemData = itemData->parent; + parent = parent->parent; } if (parent && parent == lastAddedItem) {