kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-07-16 02:07:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed.

Browse source 
Summary:
Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
This fix is pretty straight forward.

Steps to reproduce:
1. Run Dolphin without Konsole available.
2. Press F4 to open console window.
3. Click in service menu "Focus Terminal Panel".
4. Click in service menu "Defocus Terminal Panel". Observe the crash.

Test Plan:
1. Run Dolphin without Konsole available.
2. Press F4 to open console window.
3. Click in service menu "Focus Teminal Panel".
4. Click in service menu "Defocus Terminal Panel".
5. Click in service menu "Focus Terminal Panel".
6. Press F4 to close console window.

Reviewers: #dolphin, meven, elvisangelaccio, ngraham

Reviewed By: #dolphin, meven, elvisangelaccio, ngraham

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D29345
This commit is contained in:
Nikolai Krasheninnikov 2020-05-01 20:44:58 +03:00
parent 5bbdf66fce
commit 2c72b18661
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/panels/terminal/terminalpanel.cpp
View file

@ -267,5 +267,9 @@ void TerminalPanel::slotKonsolePartCurrentDirectoryChanged(const QString& dir)
bool TerminalPanel::terminalHasFocus() const
{
return m_terminalWidget->hasFocus();
if (m_terminalWidget) {
return m_terminalWidget->hasFocus();
}
return hasFocus();
}