diff --git a/src/dolphincolumnview.cpp b/src/dolphincolumnview.cpp index 4f893e9975..e38d081874 100644 --- a/src/dolphincolumnview.cpp +++ b/src/dolphincolumnview.cpp @@ -497,8 +497,8 @@ void DolphinColumnView::invertSelection() KDirLister* dirLister = m_dolphinModel->dirLister(); const KFileItemList list = dirLister->itemsForDir(column->url()); - foreach (KFileItem* item, list) { - const QModelIndex index = m_dolphinModel->indexForUrl(item->url()); + foreach (const KFileItem item, list) { + const QModelIndex index = m_dolphinModel->indexForUrl(item.url()); selModel->select(m_proxyModel->mapFromSource(index), QItemSelectionModel::Toggle); } } diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index f3dbfcf6ed..fd7f65aa54 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -493,14 +493,9 @@ void DolphinMainWindow::deleteItems() void DolphinMainWindow::properties() { - QList list = m_activeViewContainer->view()->selectedItems(); - // ### KPropertiesDialog still uses pointer-based KFileItemList - KFileItemList lst; - // Can't be a const_iterator :( - for ( QList::iterator it = list.begin(), end = list.end() ; it != end ; ++it ) { - lst << & *it; // ugly! - } - KPropertiesDialog dialog(lst, this); + const KFileItemList list = m_activeViewContainer->view()->selectedItems(); + + KPropertiesDialog dialog(list, this); dialog.exec(); } diff --git a/src/dolphinpart.cpp b/src/dolphinpart.cpp index 22b2483951..f88f916227 100644 --- a/src/dolphinpart.cpp +++ b/src/dolphinpart.cpp @@ -185,11 +185,8 @@ void DolphinPart::slotOpenContextMenu(const KFileItem& _item, const KUrl&) item = KFileItem( S_IFDIR, (mode_t)-1, url() ); } - // TODO port popupMenu to QList - KFileItem* itemCopy = new KFileItem(item); // ugly - KFileItemList items; items.append(itemCopy); + KFileItemList items; items.append(item); emit m_extension->popupMenu( 0, QCursor::pos(), items, KParts::OpenUrlArguments(), KParts::BrowserArguments(), popupFlags ); - delete itemCopy; } #include "dolphinpart.moc" diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp index edecf199a1..2c02820c44 100644 --- a/src/dolphinview.cpp +++ b/src/dolphinview.cpp @@ -900,9 +900,9 @@ void DolphinView::applyCutItemEffect() KFileItemList::const_iterator it = items.begin(); const KFileItemList::const_iterator end = items.end(); while (it != end) { - KFileItem* item = *it; - if (isCutItem(*item)) { - const QModelIndex index = m_dolphinModel->indexForItem(*item); + const KFileItem item = *it; + if (isCutItem(item)) { + const QModelIndex index = m_dolphinModel->indexForItem(item); // Huh? the item is already known //const KFileItem item = m_dolphinModel->itemForIndex(index); const QVariant value = m_dolphinModel->data(index, Qt::DecorationRole); @@ -913,7 +913,7 @@ void DolphinView::applyCutItemEffect() // remember current pixmap for the item to be able // to restore it when other items get cut CutItem cutItem; - cutItem.url = item->url(); + cutItem.url = item.url(); cutItem.pixmap = pixmap; m_cutItemsCache.append(cutItem); diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp index a2902afd7e..bd4acc2be1 100644 --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -106,7 +106,7 @@ DolphinViewContainer::DolphinViewContainer(DolphinMainWindow* mainWindow, this, SLOT(updateStatusBar())); connect(m_dirLister, SIGNAL(percent(int)), this, SLOT(updateProgress(int))); - connect(m_dirLister, SIGNAL(deleteItem(KFileItem*)), + connect(m_dirLister, SIGNAL(deleteItem(const KFileItem&)), this, SLOT(updateStatusBar())); connect(m_dirLister, SIGNAL(completed()), this, SLOT(updateItemCount())); @@ -309,8 +309,8 @@ void DolphinViewContainer::updateItemCount() m_folderCount = 0; while (it != end) { - KFileItem* item = *it; - if (item->isDir()) { + const KFileItem item = *it; + if (item.isDir()) { ++m_folderCount; } else { ++m_fileCount;