mirror of
https://invent.kde.org/system/dolphin
synced 2024-09-12 12:54:29 +00:00
Fix missing update of file name label in information panel without preview
Summary:
The file name label was only updated when the preview was shown, after
the function was moved into a conditional section. This is a regression
caused by commit 405aa4878f
("[InformationPanel] Hide the video when the
preview is disabled, avoid computing the preview when it is disabled").
Test Plan:
Hide the preview in dolphin's information panel
Hover different files, the name label reflects the hovered file again
Reviewers: #dolphin, elvisangelaccio, meven, ngraham
Reviewed By: meven
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D20660
This commit is contained in:
parent
48c082767e
commit
28a949a925
|
@ -154,12 +154,12 @@ void InformationPanelContent::refreshPreview() {
|
||||||
m_previewJob->kill();
|
m_previewJob->kill();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
setNameLabelText(m_item.text());
|
||||||
if (InformationPanelSettings::previewsShown()) {
|
if (InformationPanelSettings::previewsShown()) {
|
||||||
m_preview->show();
|
m_preview->show();
|
||||||
|
|
||||||
const QUrl itemUrl = m_item.url();
|
const QUrl itemUrl = m_item.url();
|
||||||
const bool isSearchUrl = itemUrl.scheme().contains(QStringLiteral("search")) && m_item.localPath().isEmpty();
|
const bool isSearchUrl = itemUrl.scheme().contains(QStringLiteral("search")) && m_item.localPath().isEmpty();
|
||||||
setNameLabelText(m_item.text());
|
|
||||||
if (isSearchUrl) {
|
if (isSearchUrl) {
|
||||||
// in the case of a search-URL the URL is not readable for humans
|
// in the case of a search-URL the URL is not readable for humans
|
||||||
// (at least not useful to show in the Information Panel)
|
// (at least not useful to show in the Information Panel)
|
||||||
|
|
Loading…
Reference in a new issue