kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing update of file name label in information panel without preview

Browse source 
Summary:
The file name label was only updated when the preview was shown, after
the function was moved into a conditional section. This is a regression
caused by commit 405aa4878f ("[InformationPanel] Hide the video when the
preview is disabled, avoid computing the preview when it is disabled").

Test Plan:
Hide the preview in dolphin's information panel
Hover different files, the name label reflects the hovered file again

Reviewers: #dolphin, elvisangelaccio, meven, ngraham

Reviewed By: meven

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20660
This commit is contained in:
Stefan Brüns 2019-04-18 14:37:09 +02:00 committed by Elvis Angelaccio
parent 48c082767e
commit 28a949a925
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/panels/information/informationpanelcontent.cpp
View file

@ -154,12 +154,12 @@ void InformationPanelContent::refreshPreview() {
m_previewJob->kill();
}
setNameLabelText(m_item.text());
if (InformationPanelSettings::previewsShown()) {
m_preview->show();
const QUrl itemUrl = m_item.url();
const bool isSearchUrl = itemUrl.scheme().contains(QStringLiteral("search")) && m_item.localPath().isEmpty();
setNameLabelText(m_item.text());
if (isSearchUrl) {
// in the case of a search-URL the URL is not readable for humans
// (at least not useful to show in the Information Panel)