kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clazy non-pod-global-static warning

Browse source 
This list of URLs is only used by cleanupBookmarks(), so there is no
need to make it global (which is what clazy complains about).

While at it, make it also a `const QVector`.
This commit is contained in:
Elvis Angelaccio 2019-11-09 19:42:57 +01:00
parent b2d4e3322a
commit 273fc202fd
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/panels/places/placesitemmodel.cpp
View file

@ -44,19 +44,6 @@
#include <QMimeData>
#include <QTimer>
namespace {
static QList<QUrl> balooURLs = {
QUrl(QStringLiteral("timeline:/today")),
QUrl(QStringLiteral("timeline:/yesterday")),
QUrl(QStringLiteral("timeline:/thismonth")),
QUrl(QStringLiteral("timeline:/lastmonth")),
QUrl(QStringLiteral("search:/documents")),
QUrl(QStringLiteral("search:/images")),
QUrl(QStringLiteral("search:/audio")),
QUrl(QStringLiteral("search:/videos"))
};
}
PlacesItemModel::PlacesItemModel(QObject* parent) :
KStandardItemModel(parent),
m_hiddenItemsShown(false),
@ -627,6 +614,18 @@ void PlacesItemModel::cleanupBookmarks()
{
// KIO model now provides support for baloo urls, and because of that we
// need to remove old URLs that were visible only in Dolphin to avoid duplication
static const QVector<QUrl> balooURLs = {
QUrl(QStringLiteral("timeline:/today")),
QUrl(QStringLiteral("timeline:/yesterday")),
QUrl(QStringLiteral("timeline:/thismonth")),
QUrl(QStringLiteral("timeline:/lastmonth")),
QUrl(QStringLiteral("search:/documents")),
QUrl(QStringLiteral("search:/images")),
QUrl(QStringLiteral("search:/audio")),
QUrl(QStringLiteral("search:/videos"))
};
int row = 0;
do {
const QModelIndex sourceIndex = m_sourceModel->index(row, 0);