From 25e646e9b638f381f1de6c766c0bf38854df8f5d Mon Sep 17 00:00:00 2001 From: Frank Reininghaus Date: Wed, 30 Apr 2014 09:34:32 +0200 Subject: [PATCH] Update the "Paste" action only if it is necessary Updating this action is only required if the clipboard contents change, or if the "is writable" state of the current location changes. In all other cases, an update of this action should be prevented because it can be very expensive if many files are in the clipboard. In particular, the update when the selection changes could make changing the current item in the view very slow. BUG: 333903 REVIEW: 117782 FIXED-IN: 4.13.1 --- dolphin/src/dolphinmainwindow.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dolphin/src/dolphinmainwindow.cpp b/dolphin/src/dolphinmainwindow.cpp index 28169cfb59..7117c09bad 100644 --- a/dolphin/src/dolphinmainwindow.cpp +++ b/dolphin/src/dolphinmainwindow.cpp @@ -217,6 +217,7 @@ DolphinMainWindow::DolphinMainWindow() : toggleSplitView(); } updateEditActions(); + updatePasteAction(); updateViewActions(); updateGoActions(); @@ -356,6 +357,7 @@ void DolphinMainWindow::changeUrl(const KUrl& url) if (view) { view->setUrl(url); updateEditActions(); + updatePasteAction(); updateViewActions(); updateGoActions(); setUrlAsCaption(url); @@ -1455,6 +1457,7 @@ void DolphinMainWindow::setActiveViewContainer(DolphinViewContainer* viewContain updateHistory(); updateEditActions(); + updatePasteAction(); updateViewActions(); updateGoActions(); @@ -1817,7 +1820,6 @@ void DolphinMainWindow::updateEditActions() deleteWithTrashShortcut->setEnabled(capabilities.supportsDeleting() && !enableMoveToTrash); cutAction->setEnabled(capabilities.supportsMoving()); } - updatePasteAction(); } void DolphinMainWindow::updateViewActions()