kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-12 12:54:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly disable create_dir action in Trash

Browse source 
`isFolderWritable` is set in DolphinView::updateWritableState() according to
KFileItemListProperties::supportsWriting().
However, `writing=true` does not imply `makedir=true`,
in an ioslave's .protocol file. An example is the trash protocol.

So we need to enable the `create_dir` action only if the protocol is
actually able to create folders.

CCBUG: 332463
REVIEW: 129712
This commit is contained in:
Elvis Angelaccio 2017-01-02 14:52:37 +01:00
parent c456c5d528
commit 24ed38d77f
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/views/dolphinviewactionhandler.cpp
View file

@ -37,6 +37,7 @@
#include <KSelectAction>
#include <KToggleAction>
#include <KPropertiesDialog>
#include <KProtocolManager>
#include <QIcon>
#include "dolphindebug.h"
@ -486,7 +487,8 @@ void DolphinViewActionHandler::slotHiddenFilesShownChanged(bool shown)
void DolphinViewActionHandler::slotWriteStateChanged(bool isFolderWritable)
{
m_actionCollection->action(QStringLiteral("create_dir"))->setEnabled(isFolderWritable);
m_actionCollection->action(QStringLiteral("create_dir"))->setEnabled(isFolderWritable &&
KProtocolManager::supportsMakeDir(currentView()->url()));
}
KToggleAction* DolphinViewActionHandler::iconsModeAction()