Keep name readable on drag to matching background

Summary:
Previously, when a single item was selected and dragged, the
name would become unreadable when the text colour matched the
background colour it was dragged onto.

This is now fixed by not deselecting the item (and hence keeping
the highlighting around the text) before creating the pixmap for
dragging.

BUG: 405266

Test Plan: Tested with Breeze and Breeze Dark.

Reviewers: #dolphin, elvisangelaccio, meven

Reviewed By: #dolphin, elvisangelaccio, meven

Subscribers: meven, elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D29378
This commit is contained in:
Christian Christiansen 2020-05-06 09:30:57 +10:00
parent 3e1cb2c7fb
commit 1d72710039

View file

@ -378,7 +378,6 @@ QPixmap KItemListWidget::createDragPixmap(const QStyleOptionGraphicsItem* option
const bool wasHovered = m_hovered;
setAlternateBackground(false);
setSelected(false);
setHovered(false);
paint(&painter, option, widget);