mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-28 03:21:56 +00:00
Don't show "Open With" menu items for empty directories
Summary: Any app that registers itself as able to open directories generally can't do anything useful with an empty directory. So, don't show the {nav Open With} menu items for them. Test Plan: Before: {F6759793} After: {F6759794} The {nav Open With} items still appear for non-empty directories. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: trmdi, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20396
This commit is contained in:
parent
dbc5e57192
commit
14f0cd52f6
|
@ -351,7 +351,12 @@ void DolphinContextMenu::openViewportContextMenu()
|
|||
KFileItemActions fileItemActions;
|
||||
fileItemActions.setParentWidget(m_mainWindow);
|
||||
fileItemActions.setItemListProperties(baseUrlProperties);
|
||||
|
||||
// Don't show "Open With" menu items if the current dir is empty, because there's
|
||||
// generally no app that can do anything interesting with an empty directory
|
||||
if (view->itemsCount() != 0) {
|
||||
addOpenWithActions(fileItemActions);
|
||||
}
|
||||
|
||||
// Insert 'New Window' and 'New Tab' entries. Don't use "open_in_new_window" and
|
||||
// "open_in_new_tab" here, as the current selection should get ignored.
|
||||
|
|
Loading…
Reference in a new issue