kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't show "Open With" menu items for empty directories

Browse source 
Summary:
Any app that registers itself as able to open directories generally can't do anything
useful with an empty directory. So, don't show the {nav Open With} menu items for them.

Test Plan:
Before: {F6759793}

After: {F6759794}

The {nav Open With} items still appear for non-empty directories.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: trmdi, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20396
This commit is contained in:
Nate Graham 2019-04-08 16:03:48 -06:00
parent dbc5e57192
commit 14f0cd52f6
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/dolphincontextmenu.cpp
View file

@ -351,7 +351,12 @@ void DolphinContextMenu::openViewportContextMenu()
KFileItemActions fileItemActions;
fileItemActions.setParentWidget(m_mainWindow);
fileItemActions.setItemListProperties(baseUrlProperties);
addOpenWithActions(fileItemActions);
// Don't show "Open With" menu items if the current dir is empty, because there's
// generally no app that can do anything interesting with an empty directory
if (view->itemsCount() != 0) {
addOpenWithActions(fileItemActions);
}
// Insert 'New Window' and 'New Tab' entries. Don't use "open_in_new_window" and
// "open_in_new_tab" here, as the current selection should get ignored.