From 108e10ca15be6662fa02f56665cc78808ab243e7 Mon Sep 17 00:00:00 2001 From: Nathaniel Graham Date: Tue, 30 Jan 2018 17:05:57 -0700 Subject: [PATCH] Let the terminal panel dock to any part of the window Summary: BUG: 362593 Just what it says: Let the terminal panel sit on the left or right side of the window. Test Plan: Tested in KDE Neon: - Opened terminal panel, unlocked widgets, and tried to drag it to the right or left side of the window: I can - Put terminal panel on right side, quit Dolphin and opened Dolphin again: terminal panel appears on the right as expected - Put terminal panel on right side, closed terminal panel, quit Dolphin, opened Dolphin, and opened the terminal panel again: terminal panel appears on the right as expected - Removed dolphinrc file and opened terminal panel: appears on the bottom {F5682428} Reviewers: #dolphin Subscribers: elvisangelaccio, anthonyfieroni, cfeck Differential Revision: https://phabricator.kde.org/D10189 --- src/dolphinmainwindow.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index c35de766cc..070d56aeb2 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -1278,7 +1278,6 @@ void DolphinMainWindow::setupDockWidgets() DolphinDockWidget* terminalDock = new DolphinDockWidget(i18nc("@title:window Shell terminal", "Terminal")); terminalDock->setLocked(lock); terminalDock->setObjectName(QStringLiteral("terminalDock")); - terminalDock->setAllowedAreas(Qt::TopDockWidgetArea | Qt::BottomDockWidgetArea); m_terminalPanel = new TerminalPanel(terminalDock); m_terminalPanel->setCustomContextMenuActions({lockLayoutAction}); terminalDock->setWidget(m_terminalPanel);