mirror of
https://invent.kde.org/system/dolphin
synced 2024-09-19 00:11:21 +00:00
Use the name of the property instead of the label, otherwise the stored keys would get invalid as soon as we get translated labels.
svn path=/trunk/KDE/kdebase/apps/; revision=984677
This commit is contained in:
parent
2f233f27da
commit
0dd138d147
|
@ -283,7 +283,7 @@ void InformationPanel::contextMenuEvent(QContextMenuEvent* event)
|
||||||
QHash<QUrl, Nepomuk::Variant>::const_iterator it = properties.constBegin();
|
QHash<QUrl, Nepomuk::Variant>::const_iterator it = properties.constBegin();
|
||||||
while (it != properties.constEnd()) {
|
while (it != properties.constEnd()) {
|
||||||
Nepomuk::Types::Property prop(it.key());
|
Nepomuk::Types::Property prop(it.key());
|
||||||
const QString key = prop.label();
|
const QString key = prop.name();
|
||||||
|
|
||||||
// Meta information provided by Nepomuk that is already
|
// Meta information provided by Nepomuk that is already
|
||||||
// available from KFileItem should not be configurable.
|
// available from KFileItem should not be configurable.
|
||||||
|
@ -305,7 +305,7 @@ void InformationPanel::contextMenuEvent(QContextMenuEvent* event)
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!skip) {
|
if (!skip) {
|
||||||
const QString label = tunedLabel(key); // TODO
|
const QString label = tunedLabel(prop.label());
|
||||||
QAction* action = new QAction(label, &popup);
|
QAction* action = new QAction(label, &popup);
|
||||||
action->setCheckable(true);
|
action->setCheckable(true);
|
||||||
action->setChecked(settings.readEntry(key, true));
|
action->setChecked(settings.readEntry(key, true));
|
||||||
|
@ -584,13 +584,12 @@ void InformationPanel::showMetaInfo()
|
||||||
QHash<QUrl, Nepomuk::Variant>::const_iterator it = properties.constBegin();
|
QHash<QUrl, Nepomuk::Variant>::const_iterator it = properties.constBegin();
|
||||||
while (it != properties.constEnd()) {
|
while (it != properties.constEnd()) {
|
||||||
Nepomuk::Types::Property prop(it.key());
|
Nepomuk::Types::Property prop(it.key());
|
||||||
const QString label = prop.label();
|
if (settings.readEntry(prop.name(), true)) {
|
||||||
if (settings.readEntry(label, true)) {
|
|
||||||
// TODO #1: use Nepomuk::formatValue(res, prop) if available
|
// TODO #1: use Nepomuk::formatValue(res, prop) if available
|
||||||
// instead of it.value().toString()
|
// instead of it.value().toString()
|
||||||
// TODO #2: using tunedLabel() is a workaround for KDE 4.3 until
|
// TODO #2: using tunedLabel() is a workaround for KDE 4.3 until
|
||||||
// we get translated labels
|
// we get translated labels
|
||||||
m_metaTextLabel->add(tunedLabel(label) + ':', it.value().toString());
|
m_metaTextLabel->add(tunedLabel(prop.label()) + ':', it.value().toString());
|
||||||
}
|
}
|
||||||
++it;
|
++it;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue