mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-05 16:19:10 +00:00
Fix some compile warnings
Reviewers: markg, elvisangelaccio Reviewed By: markg, elvisangelaccio Subscribers: chehrlic, rkflx, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10995
This commit is contained in:
parent
8c1455f96f
commit
0c9343d614
|
@ -7,7 +7,7 @@ set (KDE_APPLICATIONS_VERSION_MICRO "70")
|
||||||
set (KDE_APPLICATIONS_VERSION "${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}")
|
set (KDE_APPLICATIONS_VERSION "${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}")
|
||||||
project(Dolphin VERSION ${KDE_APPLICATIONS_VERSION})
|
project(Dolphin VERSION ${KDE_APPLICATIONS_VERSION})
|
||||||
|
|
||||||
set(QT_MIN_VERSION "5.5.0")
|
set(QT_MIN_VERSION "5.8.0")
|
||||||
set(KF5_MIN_VERSION "5.43.0")
|
set(KF5_MIN_VERSION "5.43.0")
|
||||||
set(ECM_MIN_VERSION "1.6.0")
|
set(ECM_MIN_VERSION "1.6.0")
|
||||||
|
|
||||||
|
|
|
@ -428,6 +428,7 @@ void DolphinContextMenu::addShowMenuBarAction()
|
||||||
|
|
||||||
bool DolphinContextMenu::placeExists(const QUrl& url) const
|
bool DolphinContextMenu::placeExists(const QUrl& url) const
|
||||||
{
|
{
|
||||||
|
Q_UNUSED(url)
|
||||||
// Creating up a PlacesItemModel to find out if 'url' is one of the Places
|
// Creating up a PlacesItemModel to find out if 'url' is one of the Places
|
||||||
// can be expensive because the model asks Solid for the devices which are
|
// can be expensive because the model asks Solid for the devices which are
|
||||||
// available, which can take some time.
|
// available, which can take some time.
|
||||||
|
|
|
@ -410,6 +410,7 @@ void DolphinMainWindow::closeEvent(QCloseEvent* event)
|
||||||
case QDialogButtonBox::No:
|
case QDialogButtonBox::No:
|
||||||
// Close only the current tab
|
// Close only the current tab
|
||||||
m_tabWidget->closeTab();
|
m_tabWidget->closeTab();
|
||||||
|
Q_FALLTHROUGH();
|
||||||
default:
|
default:
|
||||||
event->ignore();
|
event->ignore();
|
||||||
return;
|
return;
|
||||||
|
|
|
@ -246,7 +246,6 @@ QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const
|
||||||
// Copyright (C) 2006 David Faure <faure@kde.org>
|
// Copyright (C) 2006 David Faure <faure@kde.org>
|
||||||
QList<QUrl> urls;
|
QList<QUrl> urls;
|
||||||
QList<QUrl> mostLocalUrls;
|
QList<QUrl> mostLocalUrls;
|
||||||
bool canUseMostLocalUrls = true;
|
|
||||||
const ItemData* lastAddedItem = nullptr;
|
const ItemData* lastAddedItem = nullptr;
|
||||||
|
|
||||||
for (int index : indexes) {
|
for (int index : indexes) {
|
||||||
|
@ -269,9 +268,6 @@ QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const
|
||||||
|
|
||||||
bool isLocal;
|
bool isLocal;
|
||||||
mostLocalUrls << item.mostLocalUrl(isLocal);
|
mostLocalUrls << item.mostLocalUrl(isLocal);
|
||||||
if (!isLocal) {
|
|
||||||
canUseMostLocalUrls = false;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -433,8 +433,7 @@ bool KItemListController::keyPressEvent(QKeyEvent* event)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
// Fall through to the default case and add the Space to the current search string.
|
Q_FALLTHROUGH(); // fall through to the default case and add the Space to the current search string.
|
||||||
|
|
||||||
default:
|
default:
|
||||||
m_keyboardManager->addKeys(event->text());
|
m_keyboardManager->addKeys(event->text());
|
||||||
// Make sure unconsumed events get propagated up the chain. #302329
|
// Make sure unconsumed events get propagated up the chain. #302329
|
||||||
|
|
|
@ -167,7 +167,7 @@ void PhononWidget::stateChanged(Phonon::State newstate)
|
||||||
m_videoPlayer->hide();
|
m_videoPlayer->hide();
|
||||||
}
|
}
|
||||||
emit hasVideoChanged(false);
|
emit hasVideoChanged(false);
|
||||||
// fall through
|
Q_FALLTHROUGH();
|
||||||
default:
|
default:
|
||||||
m_stopButton->hide();
|
m_stopButton->hide();
|
||||||
m_playButton->show();
|
m_playButton->show();
|
||||||
|
|
Loading…
Reference in a new issue