kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-05 16:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace qswap with std::swap

Browse source 
Fixes obsolete function 'qSwap' called. It is recommended to use 'std::swap'
instead. (CWE-477)
This commit is contained in:
Willyanto Willyanto 2023-01-16 23:44:25 +07:00
parent bf0260642b
commit 0a0f0c76db
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/dolphintabpage.cpp
View file

@ -120,7 +120,7 @@ void DolphinTabPage::setSplitViewEnabled(bool enabled, Animated animated, const
// If the primary view is active, we have to swap the pointers
// because the secondary view will be the new primary view.
qSwap(m_primaryViewContainer, m_secondaryViewContainer);
std::swap(m_primaryViewContainer, m_secondaryViewContainer);
m_primaryViewActive = false;
}
} else {
@ -132,7 +132,7 @@ void DolphinTabPage::setSplitViewEnabled(bool enabled, Animated animated, const
// If the secondary view is active, we have to swap the pointers
// because the secondary view will be the new primary view.
qSwap(m_primaryViewContainer, m_secondaryViewContainer);
std::swap(m_primaryViewContainer, m_secondaryViewContainer);
m_primaryViewActive = true;
}
}

2
src/kitemviews/private/kfileitemmodelsortalgorithm.h
View file

@ -100,7 +100,7 @@ static void merge(RandomAccessIterator begin,
if (len1 + len2 == 2) {
if (lessThan(*(begin + 1), *(begin))) {
qSwap(*begin, *(begin + 1));
std::swap(*begin, *(begin + 1));
}
return;
}