From 088e692007363bb2c8cd98487cc36ad63186b2d4 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Fri, 22 Jun 2018 16:03:48 +0200 Subject: [PATCH] don't use temporaries when uneeded Summary: Remove unused variable Compiled, Run. Trash still there. Use copy ellision Remove uneeded code Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13680 --- src/dolphindockwidget.cpp | 8 -------- src/dolphindockwidget.h | 3 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/dolphindockwidget.cpp b/src/dolphindockwidget.cpp index 726338377..32d25702a 100644 --- a/src/dolphindockwidget.cpp +++ b/src/dolphindockwidget.cpp @@ -58,14 +58,6 @@ DolphinDockWidget::DolphinDockWidget(const QString& title, QWidget* parent, Qt:: setFeatures(DefaultDockWidgetFeatures); } -DolphinDockWidget::DolphinDockWidget(QWidget* parent, Qt::WindowFlags flags) : - QDockWidget(parent, flags), - m_locked(false), - m_dockTitleBar(nullptr) -{ - setFeatures(DefaultDockWidgetFeatures); -} - DolphinDockWidget::~DolphinDockWidget() { } diff --git a/src/dolphindockwidget.h b/src/dolphindockwidget.h index c4fcbf753..0b745f083 100644 --- a/src/dolphindockwidget.h +++ b/src/dolphindockwidget.h @@ -30,8 +30,7 @@ class DolphinDockWidget : public QDockWidget Q_OBJECT public: - explicit DolphinDockWidget(const QString& title, QWidget* parent = nullptr, Qt::WindowFlags flags = nullptr); - explicit DolphinDockWidget(QWidget* parent = nullptr, Qt::WindowFlags flags = nullptr); + explicit DolphinDockWidget(const QString& title = QString(), QWidget* parent = nullptr, Qt::WindowFlags flags = nullptr); ~DolphinDockWidget() override; /**