jmarya/moira
jmarya/moira
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages 2 Wiki Activity Actions

Approval gates #4

New issue
Open
opened 2026-04-20 20:11:19 +00:00 by jmarya · 0 comments
jmarya commented 2026-04-20 20:11:19 +00:00
Owner
Copy link

Implement human approval as a built-in module step. A step uses moira.gate; the agent registers the gate on the server and polls for resolution. On approve the step succeeds; on deny it fails.

Design

- name: approve-deploy
  use: moira.gate
  with:
    message: "Deploy ${{ git.tag }} to production?"
    timeout: 24h
    approvers:
      roles: [owner]
    depends_on: [build]

- name: deploy
  run: ./deploy.sh
  depends_on: [approve-deploy]

Outputs

approved_by (string), approved_at (string), reason (on denial).

Scope

  • Server: gates table (id, run_id, step_name, message, timeout_at, status, resolved_by, resolved_at, reason) + migration
  • Server: POST /work/runs/:id/gates (agent creates), GET (agent polls),
    POST /gates/:id/approve, POST /gates/:id/deny (CLI/user resolves)
  • Agent: built-in module handler — register gate, poll every 5s,
    return StepResult on resolution or timeout
  • CLI: moira gate list, moira gate approve <id>,
    moira gate deny <id> --reason "..."
  • Local mode: interactive terminal prompt (y/n) when gate is reached
  • Run lifecycle: waiting status while gate is open
Implement human approval as a built-in module step. A step uses `moira.gate`; the agent registers the gate on the server and polls for resolution. On approve the step succeeds; on deny it fails. ## Design ```yml - name: approve-deploy use: moira.gate with: message: "Deploy ${{ git.tag }} to production?" timeout: 24h approvers: roles: [owner] depends_on: [build] - name: deploy run: ./deploy.sh depends_on: [approve-deploy] ``` ## Outputs `approved_by` (string), `approved_at` (string), `reason` (on denial). ## Scope - Server: `gates` table (id, run_id, step_name, message, timeout_at, status, resolved_by, resolved_at, reason) + migration - Server: POST /work/runs/:id/gates (agent creates), GET (agent polls), POST /gates/:id/approve, POST /gates/:id/deny (CLI/user resolves) - Agent: built-in module handler — register gate, poll every 5s, return StepResult on resolution or timeout - CLI: `moira gate list`, `moira gate approve <id>`, `moira gate deny <id> --reason "..."` - Local mode: interactive terminal prompt (y/n) when gate is reached - Run lifecycle: `waiting` status while gate is open
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jmarya/moira#4
No description provided.