Commit graph

10675 commits

Author SHA1 Message Date
Michael Natterer f3ffe972eb guard against g_file_query_info() returning NULL (if the file doesn't
2008-07-22  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpviewrendererimagefile.c
	(gimp_view_renderer_imagefile_get_icon): guard against
	g_file_query_info() returning NULL (if the file doesn't exist or
	whatever error).


svn path=/trunk/; revision=26277
2008-07-22 14:50:37 +00:00
Michael Natterer 7750d317c8 set scroll_lock to TRUE while moving or creating sample points so the
2008-07-22  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcolortool.c: set scroll_lock to TRUE while moving
	or creating sample points so the image doesn't scroll while a new
	sample point is dragged from the rulers and sample points can be
	deleted by dragging them out of image without scrolling at the
	same time.


svn path=/trunk/; revision=26276
2008-07-22 14:43:52 +00:00
Sven Neumann a00579917a only use the position from the event coordinates when creating or
2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpvectortool.c: only use the position from the 
event
	coordinates when creating or modifying strokes. Initialize all
	other GimpCoords fields with default values.


svn path=/trunk/; revision=26275
2008-07-22 12:33:15 +00:00
Sven Neumann 9fa59a22fd formatting
2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpvectortool.c: formatting

svn path=/trunk/; revision=26274
2008-07-22 11:12:16 +00:00
Sven Neumann be7d770ad3 template can be const
svn path=/trunk/; revision=26273
2008-07-22 10:56:35 +00:00
Sven Neumann 06d13d4bb5 formatting.
2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/vectors/gimpbezierstroke.c: formatting.


svn path=/trunk/; revision=26272
2008-07-22 10:53:08 +00:00
Sven Neumann 5b374543cb plugged memory leak.
2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpsessioninfo-aux.c
	(gimp_session_info_aux_new_from_props): plugged memory leak.

2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphistogramview.c
	(gimp_histogram_view_set_background): fixed refcounting	issue.
	This plugs the memory leak I tried to fix in 
GimpHistogramEditor.


svn path=/trunk/; revision=26271
2008-07-22 10:34:21 +00:00
Sven Neumann 4368010863 added new method gimp_histogram_duplicate().
2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/base/gimphistogram.[ch]: added new method
	gimp_histogram_duplicate().

	* app/widgets/gimphistogrameditor.c
	(gimp_histogram_editor_frozen_update): instead of recalculating
	the histogram, use a duplicate for the background histogram.


svn path=/trunk/; revision=26270
2008-07-22 09:29:35 +00:00
Sven Neumann 48e6da318d reverted last change, it did not plug the leak.
2008-07-22  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphistogrameditor.c 
(gimp_histogram_editor_set_image):
	reverted last change, it did not plug the leak.


svn path=/trunk/; revision=26269
2008-07-22 08:53:40 +00:00
Sven Neumann 460fe413fc plugged a small memory leak.
2008-07-22  Sven Neumann  <sven@gimp.org>

        * app/gui/session.c (session_init): plugged a small memory leak.


svn path=/trunk/; revision=26268
2008-07-22 06:51:59 +00:00
Sven Neumann c610b2daad always unset and ref the histograms. Plugs a memory leak reported by
2008-07-21  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphistogrameditor.c
	(gimp_histogram_editor_set_image): always unset and ref the
	histograms. Plugs a memory leak reported by valgrind.


svn path=/trunk/; revision=26263
2008-07-21 20:27:33 +00:00
Simon Budig 3bf754621c incorporate the velocity.
2008-07-21  Simon Budig  <simon@gimp.org>

	* app/core/gimpcoords.c: incorporate the velocity.


svn path=/trunk/; revision=26261
2008-07-21 19:39:35 +00:00
Sven Neumann 488f656cd2 plugged a not so small memory leak.
2008-07-21  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.c (gimp_draw_tool_on_vectors_handle):
	plugged a not so small memory leak.


svn path=/trunk/; revision=26260
2008-07-21 19:22:27 +00:00
Sven Neumann 6f4f43e714 plugged another small memory leak.
2008-07-21  Sven Neumann  <sven@gimp.org>

        * app/actions/windows-actions.c (windows_actions_dock_notify):
        plugged another small memory leak.


svn path=/trunk/; revision=26259
2008-07-21 19:05:35 +00:00
Sven Neumann d0baa3c3dd plugged a small memory leak.
2008-07-21  Sven Neumann  <sven@gimp.org>

	* app/menus/file-menu.c (file_menu_open_recent_query_tooltip):
	plugged a small memory leak.


svn path=/trunk/; revision=26258
2008-07-21 19:02:30 +00:00
Sven Neumann 7c6c5cd6d4 added boolean property 'emulate-brush-dynamics', in preparation for bug
2008-07-21  Sven Neumann  <sven@gimp.org>

	* app/core/gimpstrokedesc.[ch]: added boolean property
	'emulate-brush-dynamics', in preparation for bug #543706.

	* app/dialogs/stroke-dialog.c: added a toggle for the new 
parameter.


svn path=/trunk/; revision=26255
2008-07-21 15:45:53 +00:00
Michael Natterer c4777516ba app/gui/splash.c don't use gtk_box_pack_start_defaults(), it got
2008-07-21  Michael Natterer  <mitch@gimp.org>

	* app/gui/splash.c
	* plug-ins/common/*.c: don't use gtk_box_pack_start_defaults(),
	it got deprecated in GTK+ trunk.


svn path=/trunk/; revision=26252
2008-07-21 13:41:00 +00:00
Martin Nordholts aa27ae1bd0 Don't expose implementation details and extend the interface with trivial
2008-07-19  Martin Nordholts  <martinn@svn.gnome.org>

	* app/widgets/gimpnavigationview.[ch]: Don't expose implementation
	details and extend the interface with trivial new functions.

	* app/display/gimpnavigationeditor.c
	(gimp_navigation_editor_popup): Use the new interface instead of
	directly accessing the members of the navigation view.

svn path=/trunk/; revision=26236
2008-07-19 19:00:08 +00:00
Sven Neumann 9d17a53267 moved last motion stuff to the end
svn path=/trunk/; revision=26233
2008-07-18 11:58:57 +00:00
Sven Neumann 92661af96c removed delta_time, delta_x, delta_y, distance and random from the
2008-07-18  Sven Neumann  <sven@gimp.org>

	* app/core/core-types.h: removed delta_time, delta_x, delta_y,
	distance and random from the GimpCoords struct. These don't need
	to be kept here and they can't be properly interpolated.

	* app/core/gimpcoords.c: changed accordingly.

	* app/xcf/xcf-load.c (xcf_load_vector): the size of the 
GimpCoords
	struct changed.

	* app/display/gimpdisplayshell.[ch] (struct _GimpDisplayShell):
	added some members to store values from the last event that are
	needed in gimp_display_shell_eval_event() and which are not any
	longer part of GimpCoords.

	* app/display/gimpdisplayshell-coords.c
	(gimp_display_shell_eval_event): changed accordingly.
	
	* app/paint/gimppaintoptions.c: calculate a random number when 
one
	is needed.

	* app/paint/gimpbrushcore.c (gimp_brush_core_interpolate):
	GimpCoords doesn't have a "random" field any longer.


svn path=/trunk/; revision=26232
2008-07-18 11:56:05 +00:00
Sven Neumann dbf3201a85 initialize all members of the GimpCoords struct.
2008-07-18  Sven Neumann  <sven@gimp.org>

	* app/core/core-types.h (GIMP_COORDS_DEFAULT_VALUES): initialize
	all members of the GimpCoords struct.


svn path=/trunk/; revision=26231
2008-07-18 11:01:10 +00:00
Sven Neumann 7447eeb09c also mix in the new members of the GimpCoords struct.
2008-07-17  Sven Neumann  <sven@gimp.org>

	* app/core/gimpcoords.c (gimp_coords_mix): also mix in the new
	members of the GimpCoords struct.


svn path=/trunk/; revision=26230
2008-07-17 20:02:02 +00:00
Sven Neumann 154e185df5 formatting.
2008-07-17  Sven Neumann  <sven@gimp.org>

	* app/core/gimpcoords.c (gimp_coords_mix): formatting.


svn path=/trunk/; revision=26229
2008-07-17 19:52:55 +00:00
Sven Neumann 1acaf94143 formatting.
2008-07-17  Sven Neumann  <sven@gimp.org>

	* app/vectors/gimpbezierstroke.c: formatting.


svn path=/trunk/; revision=26228
2008-07-17 19:49:40 +00:00
Sven Neumann 7cd338205c fixed typo pointed out by Žygimantas Beručka.
2008-07-17  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcolorizetool.c: fixed typo pointed out by
	Žygimantas Beručka.


svn path=/trunk/; revision=26226
2008-07-17 19:13:12 +00:00
Sven Neumann caa4c529f5 removed 'use_pressure' field from GimpPaintCore.
2008-07-17  Sven Neumann  <sven@gimp.org>

	* app/paint/gimppaintcore.[ch]: removed 'use_pressure' field 
from
	GimpPaintCore.
	
	* app/paint/gimppaintoptions.[ch]: removed 'use_pressure' 
parameter.

	* app/paint/gimpairbrush.c
	* app/paint/gimpbrushcore.c
	* app/paint/gimpclone.c
	* app/paint/gimpconvolve.c
	* app/paint/gimpdodgeburn.c
	* app/paint/gimperaser.c
	* app/paint/gimpheal.c
	* app/paint/gimppaintbrush.c
	* app/paint/gimpsmudge.c
	* app/tools/gimppainttool.c: changed accordingly.


svn path=/trunk/; revision=26225
2008-07-17 19:00:13 +00:00
Tor Lillqvist 3c9234d5ba Use -Wl,--large-address-aware on Windows so that we can use more that 2 GB
2008-07-17  Tor Lillqvist  <tml@novell.com>

	* app/Makefile.am (win32_ldflags): Use -Wl,--large-address-aware
	on Windows so that we can use more that 2 GB user data space (if
	available; i.e. if running on a 64-bit OS, or a 32-bit OS booted
	with /3GB). See discussion in bug #522073.


svn path=/trunk/; revision=26220
2008-07-17 11:34:19 +00:00
Sven Neumann 66b0b1d498 fixed documentation (bug #542972).
2008-07-15  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/edit.pdb: fixed documentation (bug #542972).

	* app/pdb/edit-cmds.c
	* libgimp/gimpedit_pdb.c: regenerated.


svn path=/trunk/; revision=26193
2008-07-14 22:52:14 +00:00
Sven Neumann f92a070fa8 added new PDB function gimp-palette-get-colors that retrieves all colors
2008-07-14  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/palette.pdb: added new PDB function
	gimp-palette-get-colors that retrieves all colors from a palette
	in a single call. Based on patches from bug #332206.

	* app/pdb/palette-cmds.c
	* app/pdb/internal-procs.c
	* libgimp/gimppalette_pdb.[ch]: regenerated.
	
	* libgimp/gimp.def: updated.


svn path=/trunk/; revision=26192
2008-07-14 14:46:50 +00:00
Sven Neumann cf9768e5b9 added mapping from GIMP_TYPE_COLOR_ARRAY to GIMP_PDB_COLORARRAY.
2008-07-14  Sven Neumann  <sven@gimp.org>

	* app/pdb/gimp-pdb-compat.c 
(gimp_pdb_compat_arg_type_from_gtype):
	added mapping from GIMP_TYPE_COLOR_ARRAY to GIMP_PDB_COLORARRAY.


svn path=/trunk/; revision=26190
2008-07-14 14:41:20 +00:00
Sven Neumann 81131c0bb4 Add new PDB data type PDB_COLORARRAY for using arrays of GimpRGB colors as
2008-07-14  Sven Neumann  <sven@gimp.org>

	Add new PDB data type PDB_COLORARRAY for using arrays of GimpRGB
	colors as argument or return value.

	* libgimpbase/gimpbaseenums.[ch] (enum GimpPDBArgType): replaced
	the unused GIMP_PDB_BOUNDARY with GIMP_PDB_COLORARRAY.

	* libgimpbase/gimpprotocol.h: increased GIMP_PROTOCOL_VERSION.
	(struct _GPParam): added d_colorarray entry to the union.

	* libgimpbase/gimpprotocol.c
	* libgimp/gimp.[ch]
	* app/pdb/gimp-pdb-compat.c
	* app/plug-in/plug-in-params.c
	* app/plug-in/gimpplugin-message.c
	* tools/pdbgen/pdb.pl: deal with the new data type.

	* tools/pdbgen/enums.pl: regenerated.

	* plug-ins/pygimp/pygimp-pdb.c
	* plug-ins/script-fu/scheme-wrapper.c: handle the new data type.


svn path=/trunk/; revision=26189
2008-07-14 14:09:16 +00:00
Sven Neumann fbbf39e138 changed cursor key event prefix from "key-" to "cursor-".
2008-07-14  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontrollerkeyboard.c: changed cursor key event
	prefix from "key-" to "cursor-".

	* etc/controllerrc: changed accordingly. Also removed default
	bindings for cursor keys without modifiers as many tools use the
	cursor keys already.


svn path=/trunk/; revision=26188
2008-07-14 11:43:38 +00:00
Sven Neumann eeed0029bf added some line breaks to improve readability.
2008-07-14  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): added some line breaks to
	improve readability.


svn path=/trunk/; revision=26187
2008-07-14 09:41:16 +00:00
Martin Nordholts 805a3f5f8b Allow to choose what axes to center on.
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.[ch]
	(gimp_display_shell_center_image): Allow to choose what axes to
	center on.

	(gimp_display_shell_scale_fill)
	(gimp_display_shell_scale_fit_in): Explicitly center on both axes.

	* app/display/gimpdisplayshell.c (gimp_display_shell_fill): Center
	the image in the filled display shell. Rather hackish, but seems
	to work fine.

svn path=/trunk/; revision=26185
2008-07-13 20:23:15 +00:00
Sven Neumann f56bc8493f app/widgets/Makefile.am app/widgets/gimpdbusservice.[ch] removed here ...
2008-07-13  Sven Neumann  <sven@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/gimpdbusservice.[ch]
	* app/widgets/dbus-service.xml: removed here ...

	* app/gui/Makefile.am
	* app/gui/gimpdbusservice.[ch]
	* app/gui/dbus-service.xml: ... and moved here.
	(gimp_dbus_service_activate): raise the first display instead of
	the toolbox.

	* app/gui/gui-unique.c (gui_unique_win32_idle_open): same change
	here, raise the display instead of the toolbox.

	* app/unique.c: changed accordingly.


svn path=/trunk/; revision=26184
2008-07-13 19:49:32 +00:00
Sven Neumann e6e549a2d6 app/unique.c on Win32, if the gimp binary is started without filenames,
2008-07-13  Sven Neumann  <sven@gimp.org>

	* app/unique.c
	* app/gui/gui-unique.c: on Win32, if the gimp binary is started
	without filenames, raise the toolbox, just as we do in the DBus
	code path.


svn path=/trunk/; revision=26183
2008-07-13 19:04:38 +00:00
Sven Neumann 8746d0d0b7 removed trailing whitespace
svn path=/trunk/; revision=26182
2008-07-13 18:00:06 +00:00
Aurimas Juška 7ea57f5c80 check for NULL pointer to prevent crash when there are no filenames
2008-07-13  Aurimas Juška  <aurisj@svn.gnome.org>

	* app/unique.c (gimp_unique_win32_open): check for NULL pointer to
	prevent crash when there are no filenames provided.


svn path=/trunk/; revision=26179
2008-07-13 16:27:58 +00:00
Martin Nordholts fe0d07de9f Get rid of non-intelligent scrollbar stepper sensitivity code.
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_new): Get rid
	of non-intelligent scrollbar stepper sensitivity code.

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_scroll_clamp_offsets): Add intelligent
	scrollbar stepper sensitivity code.

svn path=/trunk/; revision=26178
2008-07-13 14:48:44 +00:00
Martin Nordholts 60fb7eda29 Consistency cleanup.
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_setup_hscrollbar_with_value): Consistency
	cleanup.

svn path=/trunk/; revision=26177
2008-07-13 14:33:04 +00:00
Martin Nordholts 909e46c9aa New function. (gimp_display_shell_scale_fill)
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_center_image): New function.
	(gimp_display_shell_scale_fill)
	(gimp_display_shell_scale_fit_in): Center the image at the end.

svn path=/trunk/; revision=26176
2008-07-13 14:09:05 +00:00
Martin Nordholts 59a5825e23 Use gimp_display_shell_get_scaled_image_size() instead of inaccurately
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_setup_hscrollbar_with_value)
	(gimp_display_shell_setup_vscrollbar_with_value): Use
	gimp_display_shell_get_scaled_image_size() instead of inaccurately
	calculate that information locally.

svn path=/trunk/; revision=26175
2008-07-13 12:22:10 +00:00
Martin Nordholts a93373fdd9 BORDER_PEN_WIDTH is a normal constant, no need for voodoo.
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpnavigationeditor.c
	(gimp_navigation_editor_popup): BORDER_PEN_WIDTH is a normal
	constant, no need for voodoo.

svn path=/trunk/; revision=26170
2008-07-13 09:11:42 +00:00
Martin Nordholts e0cf43aea3 New function that contains logic previously kept in
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_get_scaled_image_size): New function that
	contains logic previously kept in gimp_display_shell_draw_area().

	* app/display/gimpdisplayshell-draw.c
	(gimp_display_shell_draw_area): Use the new function.

svn path=/trunk/; revision=26168
2008-07-13 07:40:11 +00:00
Martin Nordholts 121849e7ca Don't ask gimp_display_shell_set_initial_scale() for display size, we
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_fill): Don't
	ask gimp_display_shell_set_initial_scale() for display size, we
	don't care anyway.

svn path=/trunk/; revision=26167
2008-07-13 06:25:23 +00:00
Martin Nordholts 4aeaa83f9e The following change is conceptually based on a patch by Alexia Death and
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	The following change is conceptually based on a patch by
	Alexia Death and implements the core functionality for
	bug #362915.

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_scroll_clamp_offsets): Clamp the offsets in
	such a way that allows to scroll beyond the image border.

	(gimp_display_shell_setup_hscrollbar_with_value)
	(gimp_display_shell_setup_vscrollbar_with_value): Put common
	scrollbar range setup code here.

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): Use above helper functions for
	setting up scrollbar range.

	* app/display/gimpdisplayshell-callbacks.c: Handle adjustment of
	the scrollbar range when they are about to change value.

	* app/display/gimpdisplayshell.c: Always keep the scrollbar
	steppers sensitive to user input.

svn path=/trunk/; revision=26166
2008-07-12 14:48:09 +00:00
Martin Nordholts fb32ff3efd Add short doc for gimp_display_shell_center_around_image_coordinate()
svn path=/trunk/; revision=26163
2008-07-12 14:26:49 +00:00
Martin Nordholts 9f5c347d4e Replace gimp_display_shell_scroll() with
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c:
	Replace gimp_display_shell_scroll() with
	gimp_display_shell_center_around_image_coordinate() since that is
	easier to map to something sensible when we allow to scroll beyond
	image border.

	* app/display/gimpnavigationeditor.c
	(gimp_navigation_editor_marker_changed): Adapt to the new
	interface.

svn path=/trunk/; revision=26162
2008-07-12 14:20:54 +00:00
Martin Nordholts 1fb0f1d82d Remove invalid TODO.
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_get_viewport): Remove invalid TODO.

svn path=/trunk/; revision=26161
2008-07-12 14:09:16 +00:00
Martin Nordholts 2e86bdab85 Added VOID__DOUBLE_DOUBLE_DOUBLE_DOUBLE marshaller.
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/core/gimpmarshal.list: Added
	VOID__DOUBLE_DOUBLE_DOUBLE_DOUBLE marshaller.

	* app/widgets/gimpnavigationview.c: Make the "marker-changed"
	signal also pass the marker width and height as parameters.

	* app/display/gimpnavigationeditor.c: Updated accordingly.

svn path=/trunk/; revision=26160
2008-07-12 13:53:31 +00:00