Commit graph

10633 commits

Author SHA1 Message Date
Martin Nordholts a93373fdd9 BORDER_PEN_WIDTH is a normal constant, no need for voodoo.
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpnavigationeditor.c
	(gimp_navigation_editor_popup): BORDER_PEN_WIDTH is a normal
	constant, no need for voodoo.

svn path=/trunk/; revision=26170
2008-07-13 09:11:42 +00:00
Martin Nordholts e0cf43aea3 New function that contains logic previously kept in
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_get_scaled_image_size): New function that
	contains logic previously kept in gimp_display_shell_draw_area().

	* app/display/gimpdisplayshell-draw.c
	(gimp_display_shell_draw_area): Use the new function.

svn path=/trunk/; revision=26168
2008-07-13 07:40:11 +00:00
Martin Nordholts 121849e7ca Don't ask gimp_display_shell_set_initial_scale() for display size, we
2008-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_fill): Don't
	ask gimp_display_shell_set_initial_scale() for display size, we
	don't care anyway.

svn path=/trunk/; revision=26167
2008-07-13 06:25:23 +00:00
Martin Nordholts 4aeaa83f9e The following change is conceptually based on a patch by Alexia Death and
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	The following change is conceptually based on a patch by
	Alexia Death and implements the core functionality for
	bug #362915.

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_scroll_clamp_offsets): Clamp the offsets in
	such a way that allows to scroll beyond the image border.

	(gimp_display_shell_setup_hscrollbar_with_value)
	(gimp_display_shell_setup_vscrollbar_with_value): Put common
	scrollbar range setup code here.

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): Use above helper functions for
	setting up scrollbar range.

	* app/display/gimpdisplayshell-callbacks.c: Handle adjustment of
	the scrollbar range when they are about to change value.

	* app/display/gimpdisplayshell.c: Always keep the scrollbar
	steppers sensitive to user input.

svn path=/trunk/; revision=26166
2008-07-12 14:48:09 +00:00
Martin Nordholts fb32ff3efd Add short doc for gimp_display_shell_center_around_image_coordinate()
svn path=/trunk/; revision=26163
2008-07-12 14:26:49 +00:00
Martin Nordholts 9f5c347d4e Replace gimp_display_shell_scroll() with
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c:
	Replace gimp_display_shell_scroll() with
	gimp_display_shell_center_around_image_coordinate() since that is
	easier to map to something sensible when we allow to scroll beyond
	image border.

	* app/display/gimpnavigationeditor.c
	(gimp_navigation_editor_marker_changed): Adapt to the new
	interface.

svn path=/trunk/; revision=26162
2008-07-12 14:20:54 +00:00
Martin Nordholts 1fb0f1d82d Remove invalid TODO.
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_get_viewport): Remove invalid TODO.

svn path=/trunk/; revision=26161
2008-07-12 14:09:16 +00:00
Martin Nordholts 2e86bdab85 Added VOID__DOUBLE_DOUBLE_DOUBLE_DOUBLE marshaller.
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/core/gimpmarshal.list: Added
	VOID__DOUBLE_DOUBLE_DOUBLE_DOUBLE marshaller.

	* app/widgets/gimpnavigationview.c: Make the "marker-changed"
	signal also pass the marker width and height as parameters.

	* app/display/gimpnavigationeditor.c: Updated accordingly.

svn path=/trunk/; revision=26160
2008-07-12 13:53:31 +00:00
Martin Nordholts 0024ff8048 The scrollbars should be setup using the new offset, not the old
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): The scrollbars should be setup
	using the new offset, not the old counterpart.

svn path=/trunk/; revision=26154
2008-07-12 10:27:20 +00:00
Sven Neumann 70cb604509 formatting.
2008-07-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: formatting.


svn path=/trunk/; revision=26151
2008-07-12 09:07:04 +00:00
Sven Neumann 0fc3b637ea added GIMP_TYPE_COLOR_ARRAY and GIMP_TYPE_PARAM_COLOR_ARRAY in preparation
2008-07-12  Sven Neumann  <sven@gimp.org>

	* app/core/gimpparamspecs.[ch]: added GIMP_TYPE_COLOR_ARRAY and
	GIMP_TYPE_PARAM_COLOR_ARRAY in preparation for fixing bug 
#332206.


svn path=/trunk/; revision=26150
2008-07-12 08:20:14 +00:00
Martin Nordholts 6445b614c7 Renamed the variables sx and sy to sw and sh.
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): Renamed the variables sx and sy
	to sw and sh.

svn path=/trunk/; revision=26148
2008-07-12 07:14:22 +00:00
Martin Nordholts a33d80107b Kill disp_[xy]offset! We now keep store that information by using negative
2008-07-12  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.c: Kill disp_[xy]offset! We now
	keep store that information by using negative values in
	offset_[xy].

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_scroll_clamp_offsets)
	(gimp_display_shell_get_scaled_image_viewport_offset): Adjust
	accordingly to preserve current behaviour.

	(gimp_display_shell_get_disp_offset): New function to get the old
	disp_[xy]offset based on the new offset_[xy].

	(gimp_display_shell_get_render_start_offset): New function to get
	th old offset_[xy] based on the new offset_[xy].

	* app/display/gimpdisplayshell-draw.c
	* app/display/gimpdisplayshell-scale.c
	* app/display/gimpdisplayshell-render.c: Get rid of
	disp_[xy]offset and use
	gimp_display_shell_get_render_start_offset() and
	gimp_display_shell_get_disp_offset() instead.

svn path=/trunk/; revision=26146
2008-07-12 07:00:46 +00:00
Martin Nordholts da6205f349 Remove #if zeroed debug output.
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): Remove #if zeroed debug output.

svn path=/trunk/; revision=26145
2008-07-11 21:31:20 +00:00
Martin Nordholts ed12651cdd Add #include "gimpdisplayshell-scroll.h"
svn path=/trunk/; revision=26144
2008-07-11 21:26:14 +00:00
Martin Nordholts 3356a5b47e Restructure the way the rulers are setup, partly by making use of the new
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): Restructure the way the rulers
	are setup, partly by making use of the new nifty
	gimp_display_shell_get_scaled_image_viewport_offset().

svn path=/trunk/; revision=26143
2008-07-11 21:08:34 +00:00
Martin Nordholts 998aac8b53 Remove two lines I forgot to remove in previous commit
svn path=/trunk/; revision=26142
2008-07-11 20:30:59 +00:00
Martin Nordholts 968fa2b25e We can use gimp_display_shell_get_scaled_image_viewport_offset() here
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-transform.c
	(gimp_display_shell_transform_xy_f)
	(gimp_display_shell_untransform_xy_f): We can use
	gimp_display_shell_get_scaled_image_viewport_offset() here

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_get_scaled_viewport): and here.

svn path=/trunk/; revision=26141
2008-07-11 20:28:37 +00:00
Martin Nordholts dc6f184a17 const- and g_return_if_fail-ify.
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_get_viewport)
	(gimp_display_shell_get_scaled_viewport)
	(gimp_display_shell_get_scaled_image_viewport_offset): const- and
	g_return_if_fail-ify.

svn path=/trunk/; revision=26140
2008-07-11 20:03:36 +00:00
Sven Neumann 00ef6ab9ec simplified.
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprotatetool.c (gimp_rotate_tool_key_press): 
simplified.


svn path=/trunk/; revision=26139
2008-07-11 19:38:28 +00:00
Martin Nordholts 18c89550fa New function to replace any occurance of
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_get_scaled_image_viewport_offset): New
	function to replace any occurance of

	  shell->disp_[xy]offset - shell->offset_[xy]

	that is just an implementation specific way of saying the same
	thing.

	* app/display/gimpdisplayshell-draw.c
	* app/display/gimpdisplayshell-transform.c: Make the code less
	implementation dependant by using the new function.

svn path=/trunk/; revision=26137
2008-07-11 19:31:45 +00:00
Martin Nordholts 74b89e5493 Update comment.
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-draw.c
	(gimp_display_shell_draw_area): Update comment.

svn path=/trunk/; revision=26135
2008-07-11 18:32:27 +00:00
Tor Lillqvist 5d805657c1 Fix g_slice_new() use.
2008-07-11  Tor Lillqvist  <tml@novell.com>

	* app/gui/gui-unique.c (idle_open_data_new): Fix g_slice_new()
	use.


svn path=/trunk/; revision=26133
2008-07-11 16:53:09 +00:00
Tor Lillqvist 26780439ba Drop duplicated #include <gegl.h>.
2008-07-11  Tor Lillqvist  <tml@novell.com>

	* app/app.c: Drop duplicated #include <gegl.h>.


svn path=/trunk/; revision=26132
2008-07-11 16:47:35 +00:00
Sven Neumann 48148af6c1 dispatch opening to an idle handler.
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/gui/gui-unique.c: dispatch opening to an idle handler.


svn path=/trunk/; revision=26129
2008-07-11 13:56:07 +00:00
Tor Lillqvist 0edb0e7ec6 Include <windows.h> on Windows. (gui_unique_win32_init): Drop unused
2008-07-11  Tor Lillqvist  <tml@novell.com>

	* app/gui/gui-unique.c: Include <windows.h> on Windows.
	(gui_unique_win32_init): Drop unused variable.


svn path=/trunk/; revision=26125
2008-07-11 12:40:41 +00:00
Tor Lillqvist 10cc717b88 Check GError being unset correctly. (gimp_unique_win32_open): Add missing
2008-07-11  Tor Lillqvist  <tml@novell.com>

	* app/unique.c (gimp_unique_filename_to_uri): Check GError being
	unset correctly.
	(gimp_unique_win32_open): Add missing semicolon.


svn path=/trunk/; revision=26124
2008-07-11 12:38:53 +00:00
Sven Neumann c6a3b41f38 actually call gui_unique_win32_exit()
svn path=/trunk/; revision=26123
2008-07-11 11:32:50 +00:00
Sven Neumann 15033a594b app/core/gimpscanconvert.c app/vectors/gimpbezierstroke.c
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/core/gimpscanconvert.c
	* app/vectors/gimpbezierstroke.c

	* app/vectors/gimpvectors.c: include <cairo.h> instead of
	<cairo/cairo.h>.


svn path=/trunk/; revision=26121
2008-07-11 10:37:58 +00:00
Sven Neumann 3ba8295b5c app/unique.c merged code from bug #410439 to provide builtin
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/unique.c
	* app/gui/gui-unique.[ch]: merged code from bug #410439 to 
provide
	builtin gimp-win-remote functionality for Win32. This is 
untested
	and most probably doesn't even compile.


svn path=/trunk/; revision=26120
2008-07-11 10:31:27 +00:00
Sven Neumann 681b788626 app/gui/Makefile.am new files providing functionality to ensure a unique
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/gui/Makefile.am
	* app/gui/gui-unique.[ch]: new files providing functionality to
	ensure a unique GUI instance of GIMP. Code split out of gui.c.

	* app/gui/gui.c: changed accordingly.


svn path=/trunk/; revision=26119
2008-07-11 09:40:09 +00:00
Sven Neumann 0cf63ba421 moved some common code back to main.c
svn path=/trunk/; revision=26118
2008-07-11 09:16:23 +00:00
Sven Neumann 30cc37c5fe app/Makefile.am new files containing functionality to check for an already
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am 
	* app/unique.[ch]: new files containing functionality to check 
for
	an already running instance of GIMP of notifying it about files 
to
	open. Code split out of main.c.

	* app/main.c: changed accordingly.


svn path=/trunk/; revision=26117
2008-07-11 09:08:07 +00:00
Sven Neumann c6260c55f2 removed misleading comment.
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/main.c (gimp_init_malloc): removed misleading comment.


svn path=/trunk/; revision=26116
2008-07-11 08:22:53 +00:00
Sven Neumann c7a8fc98eb formatting, to improve readability.
2008-07-11  Sven Neumann  <sven@gimp.org>

	* app/base/color-balance.c (color_balance_create_lookup_tables):
	formatting, to improve readability.


svn path=/trunk/; revision=26115
2008-07-11 06:22:17 +00:00
Martin Nordholts 06bd569012 Extend the interface with this function.
2008-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_get_viewport): Extend the interface with this
	function.

	* app/display/gimpnavigationeditor.c
	(gimp_navigation_editor_update_marker): Use it here.

svn path=/trunk/; revision=26114
2008-07-11 03:20:17 +00:00
Martin Nordholts 7fee886d49 Actually add gimpdisplayshell-private.h to SVN version control
svn path=/trunk/; revision=26113
2008-07-10 20:25:11 +00:00
Martin Nordholts 19325009fa Extend the interface with this function
2008-07-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_get_scaled_viewport): Extend the interface
	with this function

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_update_handle_sizes): Forget anything we knew
	about how to interpret the icky GimpDisplayShell offset variables

svn path=/trunk/; revision=26111
2008-07-10 20:19:17 +00:00
Martin Nordholts 8f21264592 Make gimp_display_shell_scroll() a sane public interface for scrolling and
2008-07-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]: Make
	gimp_display_shell_scroll() a sane public interface for scrolling
	and call the old version gimp_display_shell_scroll_private()

	* app/display/gimpnavigationeditor.c: Adapt to the saner version
	of gimp_display_shell_scroll()

	* app/display/gimpdisplayshell-callbacks.c: 
	* app/display/gimpdisplayshell-autoscroll.c: Use the private
	version of gimp_display_shell_scroll()

	* app/display/Makefile.am: Added gimpdisplayshell-private.h

svn path=/trunk/; revision=26110
2008-07-10 19:23:22 +00:00
Martin Nordholts abd52cc491 The return value of gimp_display_shell_scroll() is not used anywhere, make
2008-07-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]: The return value of
	gimp_display_shell_scroll() is not used anywhere, make it void.

svn path=/trunk/; revision=26109
2008-07-10 18:44:30 +00:00
Sven Neumann fa9ca40d25 changed expander title to "Brush Dynamics".
2008-07-10  Sven Neumann  <sven@gimp.org>

	* app/tools/gimppaintoptions-gui.c (gimp_paint_options_gui):
	changed expander title to "Brush Dynamics".


svn path=/trunk/; revision=26105
2008-07-10 10:33:49 +00:00
Sven Neumann ee6c7db882 some changes to the dialog that is shown if the help browser is missing.
2008-07-10  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphelp.c: some changes to the dialog that is 
shown
	if the help browser is missing.


svn path=/trunk/; revision=26104
2008-07-10 10:12:34 +00:00
Sven Neumann b85545eb4d swallow informational messages if there aren't handled by the statusbar.
2008-07-10  Sven Neumann  <sven@sven-sun.berlin.jpk.com>

	* app/display/gimpdisplayshell-progress.c
	(gimp_display_shell_progress_message): swallow informational
	messages if there aren't handled by the statusbar.


svn path=/trunk/; revision=26101
2008-07-10 09:42:36 +00:00
Sven Neumann a97d5de211 renamed gimp_data_name_compare() to gimp_data_compare() and changed it to
2008-07-10  Sven Neumann  <sven@sven-sun.berlin.jpk.com>

	* app/core/gimpdata.[ch]: renamed gimp_data_name_compare() to
	gimp_data_compare() and changed it to keep the data in three
	groups: internal, writable and system resource files. Inside the
	groups the sorting order is alphabetical.

	* app/core/gimpdatafactory.c (gimp_data_factory_new): changed
	accordingly.


svn path=/trunk/; revision=26100
2008-07-10 09:08:54 +00:00
Sven Neumann 7e4e4ac5d2 renamed parameter.
2008-07-10  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdatafactory.[ch] (gimp_data_factory_new): renamed
	parameter.


svn path=/trunk/; revision=26099
2008-07-10 08:41:17 +00:00
Sven Neumann 72799c954c fixed misplaced debug output.
2008-07-09  Sven Neumann  <sven@gimp.org>

        * app/core/gimp-user-install.c (gimp_user_install_detect_old):
        fixed misplaced debug output.


svn path=/trunk/; revision=26096
2008-07-09 14:46:42 +00:00
Sven Neumann 23459bf568 if a save dialog is active for this image, then don't allow to close it.
2008-07-09  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-close.c (gimp_display_shell_close):
	if a save dialog is active for this image, then don't allow to
	close it. Fixes bug #511965.

svn path=/trunk/; revision=26095
2008-07-09 10:59:19 +00:00
Sven Neumann 1fe4281317 don't accept a progress message if the status bar is already showing a
2008-07-09  Sven Neumann  <sven@gimp.org>

	* app/display/gimpstatusbar.c (gimp_statusbar_progress_message):
	don't accept a progress message if the status bar is already
	showing a temporary message.

svn path=/trunk/; revision=26094
2008-07-09 10:45:21 +00:00
Sven Neumann 462d7c18b9 don't paint while the Shift key is pressed for line drawing (bug #529434).
2008-07-09  Sven Neumann  <sven@gimp.org>

	* app/tools/gimppainttool.c (gimp_paint_tool_motion): don't 
paint
	while the Shift key is pressed for line drawing (bug #529434).


svn path=/trunk/; revision=26090
2008-07-09 06:45:47 +00:00
Sven Neumann 11a5d20892 changed button label and added an icon.
2008-07-07  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphelp.c (gimp_help_query_user_manual_online):
	changed button label and added an icon.


svn path=/trunk/; revision=26085
2008-07-07 18:32:53 +00:00