Commit graph

9213 commits

Author SHA1 Message Date
Michael Natterer 37a3f95d16 tools/pdbgen/pdb/display.pdb (diplay_is_valid)
2007-04-26  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/display.pdb (diplay_is_valid)
	* tools/pdbgen/pdb/drawable.pdb (drawable_is_valid)
	* tools/pdbgen/pdb/image.pdb (image_is_valid)
	* tools/pdbgen/pdb/vectors.pdb (vectors_is_valid): it's the
	argument flag "no_success" which turns off validation, not
	"no_validate" (how obvious). Also fixed drawable and vectors
	procedures to check for !gimp_item_is_removed() instead of
	gimp_item_is_attached() (a newly created item is unattached
	but valid).

	* app/pdb/display_cmds.c
	* app/pdb/drawable_cmds.c
	* app/pdb/image_cmds.c
	* app/pdb/vectors_cmds.c: regenerated.


svn path=/trunk/; revision=22349
2007-04-26 17:54:23 +00:00
Sven Neumann 3075f763ad app/paint-funcs/paint-funcs.c (gaussian_blur_region)
2007-04-26  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c (gaussian_blur_region)
	* plug-ins/common/blur.c (blur)
	* plug-ins/common/gauss.c (do_encoded_lre) (do_full_lre): reduce
	rounding errors.

	* plug-ins/common/checkerboard.c (checkerboard_dialog): layout
	improvements.

svn path=/trunk/; revision=22345
2007-04-26 14:30:07 +00:00
Michael Natterer 6369e06ece removed bogus "return" from void function. Fixes bug #433339, patch from
2007-04-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpbrush.c (gimp_brush_scale_size): removed bogus
	"return" from void function. Fixes bug #433339, patch from Eric
	Lamarque.


svn path=/trunk/; revision=22335
2007-04-25 16:04:06 +00:00
Michael Natterer 54737072a0 added #warning to use GParamSpecString's features once we depend on a
2007-04-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpparamspecs.c (gimp_param_string_validate): added
	#warning to use GParamSpecString's features once we depend on a
	fixed version.


svn path=/trunk/; revision=22330
2007-04-25 14:38:20 +00:00
Michael Natterer d6fd55064b added "gboolean non_empty" to require the string being non-empty. Changed
2007-04-25  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpparamspecs.[ch] (struct GimpParamSpecString)
	(gimp_param_spec_string): added "gboolean non_empty" to require
	the string being non-empty. Changed validation accordingly.
	Also fixed validation for static strings (we were happily
	freeing and modifying them before).

	* app/xcf/xcf.c: filenames should be non-empty.
	* app/pdb/gimp-pdb-compat.c: compat strings shouldn't.

	* tools/pdbgen/app.pl: add support for $arg->{non_empty} and
	changed generation of calls to gimp_param_spec_string().

	* tools/pdbgen/pdb/brush_select.pdb
	* tools/pdbgen/pdb/edit.pdb
	* tools/pdbgen/pdb/vectors.pdb
	* tools/pdbgen/pdb/plug_in.pdb
	* tools/pdbgen/pdb/gradient.pdb
	* tools/pdbgen/pdb/palette_select.pdb
	* tools/pdbgen/pdb/palette.pdb
	* tools/pdbgen/pdb/fileops.pdb
	* tools/pdbgen/pdb/progress.pdb
	* tools/pdbgen/pdb/procedural_db.pdb
	* tools/pdbgen/pdb/font_select.pdb
	* tools/pdbgen/pdb/pattern_select.pdb
	* tools/pdbgen/pdb/unit.pdb
	* tools/pdbgen/pdb/brush.pdb
	* tools/pdbgen/pdb/gradient_select.pdb
	* tools/pdbgen/pdb/buffer.pdb: require non-empty strings for data
	object names, procedure names, unit strings, PDB data identifiers
	and buffer names. Removed some manual strlen() checks, all other
	places just got better error reporting for free (proper validation
	error instead of unspecific execution error).

	* app/pdb/*_cmds.c: regenerated.


svn path=/trunk/; revision=22329
2007-04-25 14:23:05 +00:00
Sven Neumann 681764e4e8 round pixel values instead if just casting the float to an integer. Fixes
2007-04-25  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c (convolve_region): round pixel values
	instead if just casting the float to an integer. Fixes bug #432978.

svn path=/trunk/; revision=22322
2007-04-25 11:46:14 +00:00
Sven Neumann 8bfd436f31 whitespace cleanup.
2007-04-25  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c: whitespace cleanup.

svn path=/trunk/; revision=22321
2007-04-25 11:36:39 +00:00
Sven Neumann e3813131b7 also use the middle mouse button for panning.
2007-04-25  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpscrolledpreview.c: also use the middle mouse
	button for panning.

	* plug-ins/common/nova.c: override the default mouse handling of
	the GimpScrolledPreview and allow to reposition the center using
	the left mouse button. Fixes bug #364432.

	* app/tools/gimprectangletool.c: formatting.

svn path=/trunk/; revision=22319
2007-04-25 10:10:43 +00:00
Sven Neumann f92f6d1708 fiddle with test_config_LDFLAGS to make test-config link again.
2007-04-24  Sven Neumann  <sven@gimp.org>

	* app/config/Makefile.am: fiddle with test_config_LDFLAGS to make
	test-config link again.

svn path=/trunk/; revision=22309
2007-04-24 16:00:42 +00:00
Sven Neumann 5313214382 use GQuark for locale and help domains to avoid duplicating the same
2007-04-24  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginprocedure.[ch]: use GQuark for locale and
	help domains to avoid duplicating the same strings many times.

	* app/plug-in/gimppluginmanager-restore.c: removed FIXME.


svn path=/trunk/; revision=22304
2007-04-24 10:28:28 +00:00
Michael Natterer 687fc2d415 set the default plug-in locale domain on all GimpPlugInDefs which don't
2007-04-24  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimppluginmanager-restore.c
	(gimp_plug_in_manager_restore): set the default plug-in locale
	domain on all GimpPlugInDefs which don't register a locale domain
	themselves. Fixes bug #430146.


svn path=/trunk/; revision=22303
2007-04-24 09:35:42 +00:00
Michael Natterer 89329ada9f tools/pdbgen/pdb/brush.pdb (brush_rename) tools/pdbgen/pdb/gradient.pdb
2007-04-22  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/brush.pdb (brush_rename)
	* tools/pdbgen/pdb/gradient.pdb (gradient_rename)
	* tools/pdbgen/pdb/palette.pdb (palette_rename): don't allow the
	empty string as new name. Fixes bug #431845.

	* app/pdb/brush_cmds.c
	* app/pdb/gradient_cmds.c
	* app/pdb/palette_cmds.c: regenerated.


svn path=/trunk/; revision=22301
2007-04-22 12:17:41 +00:00
Sven Neumann 31ca80fd17 app/widgets/dbus-service.xml use "uri" instead of "filename" in the D-Bus
2007-04-21  Sven Neumann  <sven@gimp.org>

	* app/widgets/dbus-service.xml
	* app/widgets/gimpdbusservice.[ch]: use "uri" instead of 
"filename"
	in the D-Bus methods.


svn path=/trunk/; revision=22298
2007-04-21 18:09:16 +00:00
Sven Neumann 46ff5adf19 don't override LDFLAGS, use AM_LDFLAGS instead.
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am: don't override LDFLAGS, use AM_LDFLAGS 
instead.


svn path=/trunk/; revision=22287
2007-04-18 18:38:15 +00:00
Sven Neumann 44cefcc818 app/plug-in/Makefile.am app/plug-in/gimppluginmanager.[ch] moved
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/Makefile.am
	* app/plug-in/gimppluginmanager.[ch]
	* app/plug-in/gimppluginmanager-restore.[ch]: moved
	gimp_plug_in_manager_restore() to it's own file.

	* app/core/gimp.c: changed accordingly.

	* app/Makefile.am (LDFLAGS): convince the linker to do its job.


svn path=/trunk/; revision=22286
2007-04-18 15:06:05 +00:00
Sven Neumann 91dc2e614e added another helper function to improve readability
svn path=/trunk/; revision=22284
2007-04-18 14:28:47 +00:00
Sven Neumann 76b1f3ca3f try to improve readability by moving code to helper functions.
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginmanager.c (gimp_plug_in_manager_restore):
	try to improve readability by moving code to helper functions.

svn path=/trunk/; revision=22283
2007-04-18 14:23:20 +00:00
Sven Neumann 3d5a8450da added a function that returns all file extensions registered in the
2007-04-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimpinterpreterdb.[ch]: added a function that
	returns all file extensions registered in the interpreter db.

	* app/plug-in/gimppluginmanager.c (gimp_plug_in_manager_restore):
	if the PATHEXT environment variable is set, append all registered
	file extensions to it. This way GIMP can recognize Python scripts
	as plug-ins on platforms where the executable bit is unknown.


svn path=/trunk/; revision=22282
2007-04-18 13:21:20 +00:00
Sven Neumann 49b8176aa5 Allow other applications to open images in GIMP as if they were new images
2007-04-17  Sven Neumann  <sven@gimp.org>

	Allow other applications to open images in GIMP as if they were
	new images (without associating a filename). Fixes bug #423118.

	* app/file/file-open.[ch]: added parameter 'as_new' to
	file_open_image() and its variants.

	* app/actions/data-commands.c
	* app/actions/documents-commands.c
	* app/actions/file-commands.c
	* app/core/gimpimagefile.c
	* app/dialogs/file-open-dialog.c
	* app/dialogs/file-open-location-dialog.c
	* app/widgets/gimptoolbox.c
	* app/widgets/gimptoolbox-dnd.c: changed accordingly.

	* app/app.[ch]
	* app/main.c: added new command-line option '--as-new'.

	* app/widgets/gimpdbusservice.[ch]
	* app/widgets/dbus-service.xml: added new method "OpenAsNew" to the
	D-Bus interface.

	* docs/gimp.1.in: document the new command-line option.


svn path=/trunk/; revision=22264
2007-04-17 15:54:01 +00:00
Michael Natterer e198e7cba3 app/config/gimprc.c app/plug-in/gimppluginmanager.c
2007-04-17  Michael Natterer  <mitch@gimp.org>

	* app/config/gimprc.c
	* app/plug-in/gimppluginmanager.c
	* app/plug-in/gimpplugin.c
	* app/gui/themes.c: don't translate --verbose or g_printerr()
	messages, they are debugging output that often end up in bugzilla
	and should not depend on the locale.


svn path=/trunk/; revision=22262
2007-04-17 14:25:09 +00:00
Sven Neumann 4ea83b2c60 documentation fix.
2007-04-16  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: documentation fix.


svn path=/trunk/; revision=22258
2007-04-16 15:02:51 +00:00
Michael Natterer dfd1309b19 app/widgets/Makefile.am app/widgets/widgets-types.h remove
2007-04-16  Michael Natterer  <mitch@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpcellrendereraccel.[ch]: remove GimpCellRenererAccel.

	* app/widgets/gimpactionview.c: use GtkCellRendererAccel instead.
	If an action has no label, use its name as label. Always show the
	"Name" column because there are too many actions with confusingly
	similar names.


svn path=/trunk/; revision=22256
2007-04-16 13:43:31 +00:00
Sven Neumann 467581b790 INSTALL configure.in require gtk+ >= 2.10.6.
2007-04-16  Sven Neumann  <sven@gimp.org>

	* INSTALL
	* configure.in
	* app/gui/gui.c (gui_sanity_check): require gtk+ >= 2.10.6.


svn path=/trunk/; revision=22255
2007-04-16 12:39:06 +00:00
Michael Natterer f2acde4c60 app/base/base-types.h remove redundant and inconsistently used MaskBuf
2007-04-13  Michael Natterer  <mitch@gimp.org>

	* app/base/base-types.h
	* app/base/temp-buf.[ch]: remove redundant and inconsistently used
	MaskBuf type and API.

	* app/core/gimpbrush-scale.c
	* app/paint/gimpbrushcore.[ch]: use TempBuf and its API instead.
	This also optimizes away a useless memset() on brush scaling,
	we completely fill each of the created buffers anyway.


svn path=/trunk/; revision=22249
2007-04-13 14:04:37 +00:00
Sven Neumann 9870749e1a implement GimpTool::key_press and delegate to the rectangle tool or the
2007-04-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangleselecttool.c: implement
	GimpTool::key_press and delegate to the rectangle tool or the 
edit
	selection tool. This resurrects positioning of floating 
selections
	with the cursor keys.


svn path=/trunk/; revision=22244
2007-04-12 20:07:38 +00:00
Sven Neumann 4f6c5c7a24 added a note that calling this function may cause data loss.
2007-04-12  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/display.pdb (display_delete): added a note that
	calling this function may cause data loss.

	* app/pdb/display_cmds.c
	* libgimp/gimpdisplay_pdb.c: regenerated.


svn path=/trunk/; revision=22243
2007-04-12 16:32:20 +00:00
Sven Neumann 65f2809545 if a plug-in or script registered with a DISPLAY argument after the
2007-04-12  Sven Neumann  <sven@gimp.org>

	* app/actions/plug-in-commands.c: if a plug-in or script
	registered with a DISPLAY argument after the run-mode argument,
	then pass the ID of the active display to the script, optionally
	followed by image and drawable IDs.

	* plug-ins/script-fu/scheme-wrapper.c
	* plug-ins/script-fu/script-fu-enums.h
	* plug-ins/script-fu/script-fu-interface.c
	* plug-ins/script-fu/script-fu-scripts.c
	* plug-ins/script-fu/script-fu-types.h: added SF-DISPLAY parameter.

svn path=/trunk/; revision=22241
2007-04-12 15:56:57 +00:00
Sven Neumann c68c91c94d app/tools/gimplevelstool.c app/tools/gimpcurvestool.c app/xcf/xcf-save.c
2007-04-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.c
	* app/tools/gimpcurvestool.c
	* app/xcf/xcf-save.c
	* app/xcf/xcf-load.c
	* app/widgets/gimppaletteeditor.c
	* app/widgets/gimpcolormapeditor.c
	* app/widgets/gimpcolorframe.c: get rid of compiler warnings about
	dereferencing type-punned pointers.


svn path=/trunk/; revision=22238
2007-04-12 14:48:04 +00:00
Mukund Sivaraman bc5843031b Fixes a bug (#428493) where gimp_statusbar_push_temp() expects vaargs and
2007-04-11  Mukund Sivaraman  <muks@mukund.org>

        * app/display/gimpstatusbar.c: Fixes a bug (#428493) where
          gimp_statusbar_push_temp() expects vaargs and
          gimp_statusbar_progress_message() directly passes a message
          to it as the format string.. in this case the message
          contains % (in the filename) and no arguments.


svn path=/trunk/; revision=22231
2007-04-11 09:42:51 +00:00
Michael Natterer 7cb18110b1 app/paint/gimpperspectiveclone.c #include "libgimpmath/gimpmath.h"
2007-04-09  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpperspectiveclone.c
	* app/paint/gimppaintoptions.c: #include "libgimpmath/gimpmath.h"


svn path=/trunk/; revision=22225
2007-04-09 11:54:44 +00:00
Michael Natterer c6733ac891 app/base/Makefile.am removed these files.
2007-04-01  Michael Natterer  <mitch@gimp.org>

	* app/base/Makefile.am
	* app/base/brush-scale.[ch]: removed these files.

	* app/core/Makefile.am
	* app/core/gimpbrush-scale.[ch]: added the functions here as
	static utility functions. Also move the default implementations of
	GimpBrush::scale_size(), ::scale_mask() and ::scale_pixmap() here,
	including their utility functions.

	* app/core/gimpbrush.c: remove all scale stuff and
	include "gimpbrush-scale.h" instead.

	(gimp_brush_get_new_preview): use GimpBrush's scale functions
	instead of the now private ones. Cleanup.

	(gimp_brush_scale_mask)
	(gimp_brush_scale_pixmap): return a copy of the buf for
	scale == 1.0.


svn path=/trunk/; revision=22213
2007-04-01 13:38:22 +00:00
Michael Natterer 00be2f5f8c use SQR(x) instead of x*x.
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdrawable-blend.c: use SQR(x) instead of x*x.


svn path=/trunk/; revision=22211
2007-03-31 16:45:19 +00:00
Michael Natterer b2ef4856b0 set core->saved_proj_tiles to NULL after unrefing them.
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimppaintcore.c (gimp_paint_core_start): set
	core->saved_proj_tiles to NULL after unrefing them.

	* app/paint/gimppaintcore.h: whitespace fixes.


svn path=/trunk/; revision=22210
2007-03-31 16:43:41 +00:00
Michael Natterer 3adb312e12 made the GimpRectangleOptionsPrivate struct public (ha ha).
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleoptions.[ch]: made the
	GimpRectangleOptionsPrivate struct public (ha ha).

	(gimp_rectangle_options_gui): replaced the "Auto shrink selection"
	toggle by a normal button that needs to be clicked explicitely.

	* app/tools/gimprectangletool.c: access members of
	GimpRectangleOptionsPrivate directly instead of reading them into
	local variables using g_object_get(), this makes the code quite
	more readable. Some code cleanup.

	(gimp_rectangle_tool_button_release): get rid of the confusing
	auto-shrink madness on button release...

	(gimp_rectangle_tool_start)
	(gimp_rectangle_tool_halt): ...instead, connect to the option's
	auto shrink button and shrink on "clicked".


svn path=/trunk/; revision=22209
2007-03-31 16:38:55 +00:00
Michael Natterer 0d7ccd8f56 read the "operation" member of GimpSelectionOptions directly.
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleselecttool.c: read the "operation" member
	of GimpSelectionOptions directly.

	* app/tools/gimpellipseselecttool.c (gimp_ellipse_select_tool_draw):
	chain up instead of calling gimp_rectangle_tool_draw() directly,
	don't #include "gimprectantletool.h".


svn path=/trunk/; revision=22208
2007-03-31 16:22:57 +00:00
Michael Natterer 58bea5b1b6 access the GimpCropOptions structure directly to read the "layer_only"
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcroptool.c: access the GimpCropOptions structure
	directly to read the "layer_only" option (don't use g_object_get),
	some code cleanup.


svn path=/trunk/; revision=22207
2007-03-31 16:07:05 +00:00
Michael Natterer 6e422b5211 Statusbar messages shouldn't depend on the emission of unrelated signals:
2007-03-31  Michael Natterer  <mitch@gimp.org>

	Statusbar messages shouldn't depend on the emission of unrelated
	signals:

	* app/widgets/gimpuimanager.c (gimp_ui_manager_connect_proxy):
	connect to the menu items' "select" and "deselect" signals here...

	(gimp_ui_manager_item_realize): ...instead of here.


svn path=/trunk/; revision=22206
2007-03-31 12:25:03 +00:00
Michael Natterer 6fd436f9cb app/actions/dialogs-actions.c app/actions/dock-actions.c
2007-03-31  Michael Natterer  <mitch@gimp.org>

	* app/actions/dialogs-actions.c
	* app/actions/dock-actions.c
	* app/actions/edit-actions.c
	* app/actions/file-actions.c
	* app/actions/help-actions.c
	* app/actions/layers-actions.c
	* app/actions/plug-in-actions.c
	* app/actions/tools-actions.c
	* app/actions/vectors-actions.c
	* app/actions/view-actions.c
	* app/actions/window-actions.c: add many missing action tooltips
	and fixed some broken/inconsistent ones. Sorry for the big string
	change but the inconsistenties were just too big to ship 2.4 like
	that.


svn path=/trunk/; revision=22204
2007-03-31 11:38:47 +00:00
Sven Neumann 04b0433c84 cosmetics
svn path=/trunk/; revision=22202
2007-03-30 10:18:05 +00:00
Sven Neumann 05d6439d9d hardcode the result of log (1.0 / 255.0) and avoid a useless call to
2007-03-30  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c: hardcode the result of
	log (1.0 / 255.0) and avoid a useless call to sqrt().

svn path=/trunk/; revision=22201
2007-03-30 10:14:30 +00:00
Sven Neumann f51e694972 compare square of errors instead of calculating the square root. Rewritten
2007-03-30  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpheal.c (gimp_heal_laplace_iteration)
	(gimp_heal_laplace_loop): compare square of errors instead of
	calculating the square root. Rewritten loop to avoid code duplication.

svn path=/trunk/; revision=22200
2007-03-30 09:53:43 +00:00
Sven Neumann e2b83b288c app/tools/gimpdrawtool.[ch] app/tools/gimpperspectiveclonetool.c compare
2007-03-30  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch]
	* app/tools/gimpperspectiveclonetool.c
	* app/tools/gimptransformtool.c: compare squared distances.

svn path=/trunk/; revision=22198
2007-03-30 09:41:18 +00:00
Sven Neumann 4c33327046 hardcode the result of sqrt(5).
2007-03-30  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw_guides):
	hardcode the result of sqrt(5).


svn path=/trunk/; revision=22196
2007-03-30 09:26:48 +00:00
Michael Natterer ca83552cd6 don't compare the result of sqrt() with something, compare the original
2007-03-29  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.c (gimp_tool_check_click_distance): don't
	compare the result of sqrt() with something, compare the original
	value with something's square instead.


svn path=/trunk/; revision=22195
2007-03-29 19:00:45 +00:00
Sven Neumann 410d8a5546 cosmetisc
svn path=/trunk/; revision=22194
2007-03-29 14:09:12 +00:00
Sven Neumann ed93588115 moved generation of the lookup table to it's own function. Also changed
2007-03-29  Sven Neumann  <sven@gimp.org>

	* app/core/gimpbrushgenerated.c (gimp_brush_generated_calc): moved
	generation of the lookup table to it's own function. Also changed
	SUPERSAMPLING from 5 to 4. Let's see if someone complains...


svn path=/trunk/; revision=22193
2007-03-29 14:04:54 +00:00
Sven Neumann 3e5bb50311 app/pdb/layer_cmds.c regenerated.
2007-03-28  Sven Neumann  <sven@gimp.org>

	* app/pdb/layer_cmds.c
	* libgimp/gimplayer_pdb.c: regenerated.


svn path=/trunk/; revision=22189
2007-03-28 06:36:56 +00:00
Sven Neumann fe0b95b6bc app/widgets/gimpdbusservice.[ch] added a boolean return value to the D-Bus
2007-03-27  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpdbusservice.[ch]
	* app/widgets/dbus-service.xml: added a boolean return value to
	the D-Bus Open method.


svn path=/trunk/; revision=22182
2007-03-27 20:12:44 +00:00
Sven Neumann 518b13d17b changed file_open_from_command_line() to deal with a single filename only.
2007-03-27  Sven Neumann  <sven@gimp.org>

	* app/file/file-open.[ch]: changed file_open_from_command_line()
	to deal with a single filename only.

	* app/widgets/gimpdbusservice.[ch]
	* app/widgets/dbus-service.xml: changed the D-Bus Open method to
	take only a single filename.

	* app/app.c
	* app/main.c: changed accordingly.


svn path=/trunk/; revision=22181
2007-03-27 19:40:31 +00:00
Sven Neumann aa3eff52bd oops, fixed the onject path
svn path=/trunk/; revision=22172
2007-03-26 21:23:34 +00:00
Sven Neumann b2c2d9902a app/widgets/dbus-service.xml be more specific in the D-Bus service and
2007-03-26  Sven Neumann  <sven@gimp.org>

	* app/widgets/dbus-service.xml
	* app/widgets/gimpdbusservice.h: be more specific in the D-Bus
	service and interface name.


svn path=/trunk/; revision=22171
2007-03-26 21:19:30 +00:00
Sven Neumann 9ae026c39e Make XOR color configurable (bug #421466):
2007-03-23  Sven Neumann  <sven@gimp.org>

	Make XOR color configurable (bug #421466):

	* app/config/gimprc-blurbs.h
	* app/config/gimpdisplayconfig.[ch]: added gimprc option for the
	XOR color.

	* app/display/gimpcanvas.[ch]: keep a reference to the Gimp object
	and take the XOR color from GimpDisplayConfig.

	* app/display/gimpdisplayshell.c: pass gimp to gimp_canvas_new().

svn path=/trunk/; revision=22164
2007-03-23 09:25:28 +00:00
Sven Neumann ce489b17ae allow adding a mask to a layer without alpha channel (bug #316207).
2007-03-22  Sven Neumann  <sven@gimp.org>

	* app/core/gimplayer.c (gimp_layer_add_mask): allow adding a mask
	to a layer without alpha channel (bug #316207).

svn path=/trunk/; revision=22163
2007-03-22 17:58:42 +00:00
Sven Neumann 09c39298e4 don't call gimp_zoom_model_zoom() before assigning shell->display. Fixes
2007-03-21  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_new): don't
	call gimp_zoom_model_zoom() before assigning shell->display. Fixes
	bug #421044.


svn path=/trunk/; revision=22158
2007-03-21 16:34:10 +00:00
Sven Neumann e9b050d244 fixed typo spotted by Bill Skaggs.
2007-03-21  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpblendtool.c (gimp_blend_tool_button_release): fixed
	typo spotted by Bill Skaggs.

svn path=/trunk/; revision=22157
2007-03-21 16:06:11 +00:00
Sven Neumann 40f2a1d670 be more robust to avoid crashes like bug #420595.
2007-03-21  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-preview.c
	(gimp_display_shell_trace_tri_edge): be more robust to avoid
	crashes like bug #420595.

svn path=/trunk/; revision=22155
2007-03-21 11:58:29 +00:00
Michael Natterer 1c233b6fb6 disallow passing a NULL image.
2007-03-20  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcursorview.[ch] (gimp_color_frame_update_cursor):
	disallow passing a NULL image.

	(gimp_color_frame_clear_cursor): new function that clears the
	cursor view.

	* app/widgets/gimpcolorframe.c (gimp_color_frame_update): if
	color_frame->sample_valid is FALSE, don't do any color
	transformations and don't construct any string because none
	of them is going to be used (all labels will show "n/a").

	* app/display/gimpstatusbar.[ch]: renamed set_cursor() API
	to update_cursor().

	* app/display/gimpdisplayshell-cursor.c
	(gimp_display_shell_update_cursor): move variables to local
	scopes. Follow GimpStatusbar API change. Cleanup.

	(gimp_display_shell_clear_cursor): ditto. Follow GimpColorFrame
	API change.


svn path=/trunk/; revision=22153
2007-03-20 19:03:34 +00:00
Michael Natterer 5ba99bdacd app/actions/plug-in-actions.c GimpPlugInProcedure has a boolean member
2007-03-19  Michael Natterer  <mitch@gimp.org>

	* app/actions/plug-in-actions.c
	* app/menus/plug-in-menus.c: GimpPlugInProcedure has a boolean
	member "file_proc" now, use it instead of checking prefixes,
	extensions and magics manually.

	* app/plug-in/gimppluginprocedure.c
	(gimp_plug_in_procedure_set_mime_type)
	(gimp_plug_in_procedure_set_thumb_loader): set
	plug_in_proc->file_proc to TRUE here too.

	* plug-ins/common/pnm.c: register "image/x-portable-anymap" as
	mime-type and "pnm" as extension for file-pnm-save so it's
	recognized as file procedure.


svn path=/trunk/; revision=22152
2007-03-20 10:41:35 +00:00
Michael Natterer e82a31ad91 Make sure we create actions for all plug-in procedures which have a
2007-03-19  Michael Natterer  <mitch@gimp.org>

	Make sure we create actions for all plug-in procedures which have
	a menu_label, so it's possible to assign shortcuts to them.
	Fixes bug #371300.

	* app/actions/plug-in-actions.c (plug_in_actions_setup): removed
	duplicate code and simply call plug_in_actions_register_procedure()
	on all actions, it already does all needed checks and signal
	connections by itself.

	(plug_in_actions_update)
	(plug_in_actions_register_procedure)
	(plug_in_actions_unregister_procedure): unified checks for whether
	a plug-in procedure needs an action or not: it needs either a
	menu_label or menu_paths and must not have extensions, prefixes or
	magics.

	* libgimp/gimp.c (gimp_install_procedure): document that it's
	possible to install shortcut-only procedures by registering a
	menu_label but no menu_paths.


svn path=/trunk/; revision=22147
2007-03-19 14:41:23 +00:00
Michael Natterer c0011477fb cosmetic cleanup.
2007-03-18  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpbrushcore.c: cosmetic cleanup.


svn path=/trunk/; revision=22144
2007-03-18 20:47:12 +00:00
Michael Natterer aa21da9799 remove parameter "gdouble scale" and use core->scale.
2007-03-18  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpbrushcore.c
	(gimp_brush_core_scale_mask)
	(gimp_brush_core_scale_pixmap)
	(gimp_brush_core_get_brush_mask): remove parameter
	"gdouble scale" and use core->scale.

	(gimp_brush_core_paste_canvas)
	(gimp_brush_core_replace_canvas)
	(gimp_brush_core_get_brush_mask)
	(gimp_brush_core_color_area_with_pixmap): don't pass core->scale.
	As below, passing anything else makes no sense.

	(gimp_brush_core_interpolate): cleanup.


svn path=/trunk/; revision=22143
2007-03-18 20:13:55 +00:00
Michael Natterer e968a7ff4f removed parameters "GimpImage *dest" (because it's always the passed
2007-03-18  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpbrushcore.[ch]
	(gimp_brush_core_color_area_with_pixmap): removed parameters
	"GimpImage *dest" (because it's always the passed drawable's
	image) and "gdouble scale" (because passing anything but
	brush_core->scale makes no sense whatsoever).

	* app/paint/gimppaintbrush.c (_gimp_paintbrush_motion): changed
	accordingly.


svn path=/trunk/; revision=22142
2007-03-18 19:58:57 +00:00
Michael Natterer 83981ef404 simplified brush scale calculation by making sure that brush_core->scale
2007-03-18  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpbrushcore.c: simplified brush scale calculation by
	making sure that brush_core->scale always contains a value that's
	suited as input for gimp_brush_scale_mask/pixmap() (bug #419290).

	(gimp_brush_core_calc_brush_size): removed this function. All
	places can now call gimp_brush_scale_size() directly with
	core->scale as parameter.

	(gimp_brush_core_calc_brush_scale): new function which returns
	a linear scale factor which contains both the area-based pressure
	scale factor and the linear paint options scale factor.

	(gimp_brush_core_start)
	(gimp_brush_core_get_paint_area): use the new function instead
	of doing these calculations manually.

	(gimp_brush_core_interpolate): remove call to
	gimp_brush_core_scale_brush_size() and use core->scale directly.

	(gimp_brush_core_get_paint_area)
	(gimp_brush_core_scale_mask)
	(gimp_brush_core_scale_pixmap): use gimp_brush_scale_size()
	instead of the removed gimp_brush_core_scale_brush_size().

	(gimp_brush_core_create_bound_segs): use only
	paint_options->brush_scale here since the canvas brush preview
	always has to asume full pressure.

	* app/core/gimpbrush.c (gimp_brush_scale_size): special case
	scale == 1.0 and return the mask's width/height without calling
	the virtual function.


svn path=/trunk/; revision=22141
2007-03-18 19:48:36 +00:00
Michael Natterer 6515dc60b4 jikes, the offset is to be interpreted as offset from the start of the
2007-03-18  Michael Natterer  <mitch@gimp.org>

	* app/file/file-utils.c (file_check_single_magic): jikes, the
	offset is to be interpreted as offset from the start of the file
	for offset >= 0, not offset > 0.


svn path=/trunk/; revision=22140
2007-03-18 17:08:08 +00:00
Michael Natterer 0845a11c55 alow negative offsets in magics and interpret them as relative to the end
2007-03-17  Michael Natterer  <mitch@gimp.org>

	* app/file/file-utils.c (file_check_single_magic): alow negative
	offsets in magics and interpret them as relative to the end of the
	file.

	(file_utils_find_proc)
	(file_check_magic_list): some cleanup.

	* plug-ins/common/tga.c (query): register the magic string
	"TRUEVISION-XFILE.\0" 18 bytes before the end of the file.
	This way, "new style" TGA files are detected regardless of
	their filename. "old style" TGA files still need the right
	extension to be treated as TGA. Added "vda", "icb" and "vst"
	to the list of extensions. Fixes bug #133798.


svn path=/trunk/; revision=22138
2007-03-17 19:44:55 +00:00
Michael Natterer 24a8095025 Make the height of the previews in data editors configurable. Fixes bug
2007-03-17  Michael Natterer  <mitch@gimp.org>

	Make the height of the previews in data editors configurable.
	Fixes bug #337757.

	* app/widgets/gimpdataeditor.[ch]: add member "view" which needs
	to be set by subclasses. Add style property "minimal-height" which
	defaults to 96. Add style_set() implementation which sets
	editor->view's height to the configured value.

	* app/widgets/gimpbrusheditor.[ch]
	* app/widgets/gimpgradienteditor.[ch]
	* app/widgets/gimppaletteeditor.[ch]: use data_editor->view for
	storing the view widget and removed own view members. Remove
	separate #defines for the view's default width and height, it's
	width follows the dialog anyway.

	* themes/Default/gtkrc: document the default value of 96.

	* themes/Small/gtkrc: set it to 64.


svn path=/trunk/; revision=22137
2007-03-17 18:20:19 +00:00
Michael Natterer 68b4585959 register the tool with GIMP_PAINT_OPTIONS_CONTEXT_MASK and
2007-03-17  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpvectortool.c (gimp_vector_tool_register):
	register the tool with GIMP_PAINT_OPTIONS_CONTEXT_MASK and
	GIMP_CONTEXT_GRADIENT_MASK so its tool options are suited
	as parameter object for stroking (the stroke button in the
	tool options was using default values before).


svn path=/trunk/; revision=22135
2007-03-17 15:24:17 +00:00
Michael Natterer cefff5f07f don't just g_free() the GValueArray after we memcpy()-stole its values
2007-03-16  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimppluginprocframe.c
	(gimp_plug_in_proc_frame_get_return_vals): don't just g_free() the
	GValueArray after we memcpy()-stole its values because this both
	leaks the contained array of GValues and crashes with glib trunk
	where GValueArray is slice-allocated. Instead, free the array of
	GValues manually, set it to NULL and use g_value_array_free().


svn path=/trunk/; revision=22134
2007-03-16 14:24:02 +00:00
Michael Natterer dd4042df85 Fix stuck progress bars (bug #393832):
2007-03-16  Michael Natterer  <mitch@gimp.org>

	Fix stuck progress bars (bug #393832):

	* app/plug-in/gimpplugin-progress.[ch] (gimp_plug_in_progress_end):
	added PlugInProcFrame parameter instead of blindly using the topmost
	in the procedure stack...

	* app/plug-in/gimppluginprocframe.c
	(gimp_plug_in_proc_frame_dispose): ...because we call it from here,
	when the proc_frame is already removed from the procedure stack.

	Unrelated:

	* plug-ins/script-fu/scripts/difference-clouds.scm: use
	RUN-INTERACTVE instead of 0, added (gimp-displays-flush)

	* plug-ins/common/snoise.c (solid_noide): update the progress to
	1.0 after rendering.


svn path=/trunk/; revision=22131
2007-03-15 23:39:32 +00:00
Michael Natterer 40718dc7e4 app/tools/gimpaligntool.c app/tools/gimpcolorpickertool.c
2007-03-15  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpaligntool.c
	* app/tools/gimpcolorpickertool.c
	* app/tools/gimppainttool.c
	* app/tools/gimpvectortool.c: remove gimp_tool_pop_status() from
	control() implementations because GimpTool does this generically now.

	* app/tools/gimpblendtool.c
	* app/tools/gimpselectiontool.c: remove entire control()
	implementations because they were doing nothing else.


svn path=/trunk/; revision=22128
2007-03-15 17:32:50 +00:00
Michael Natterer 9f650d77f5 "adj" is a GtkObject not a GtkWidget, also moved it to its local scope.
2007-03-15  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimppaintoptions-gui.c (gimp_paint_options_gui): "adj"
	is a GtkObject not a GtkWidget, also moved it to its local scope.


svn path=/trunk/; revision=22127
2007-03-15 17:08:06 +00:00
Michael Natterer 4359b1c98d check if tool->display is there before dereferencing it (bug #418504).
2007-03-15  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_halt): check
	if tool->display is there before dereferencing it (bug #418504).

	(gimp_rectangle_tool_start): add "display" parameter and set
	tool->display here.

	(gimp_rectangle_tool_button_press): pass the display to start()
	and don't set tool->display here.


svn path=/trunk/; revision=22125
2007-03-15 09:21:47 +00:00
Michael Natterer e4aeb7d616 Make the status display stuff local to GimpTool:
2007-03-14  Michael Natterer  <mitch@gimp.org>

	Make the status display stuff local to GimpTool:

	* app/tools/tool_manager.c (tool_manager_control_active): don't
	call gimp_tool_clear_status().

	* app/tools/gimptool.[ch]: make gimp_tool_clear_status() a
	private function. Move call to gimp_tool_clear_status() from
	real_control() to control(). Check the status_displays too in
	gimp_tool_real_has_display() and gimp_tool_has_image() so the
	normal mechanism of control(HALT)ing (and thus popping all
	status messages) the tool on display close works.


svn path=/trunk/; revision=22124
2007-03-14 23:07:00 +00:00
Michael Natterer c16484b71c Fix stuck statusbar messages when changing tools (bug #398913):
2007-03-14  Michael Natterer  <mitch@gimp.org>

	Fix stuck statusbar messages when changing tools (bug #398913):

	* app/tools/gimptool.[ch]: keep a list of status_displays around.
	Update the list in all status push, replace and pop functions.
	Added gimp_tool_clear_status() which removes the status messages
	from all displays in the list. Call the function from
	gimp_tool_real_control(HALT).

	* app/tools/tool_manager.c (tool_manager_control_active): if we
	can't call gimp_tool_control() because we have no display to pass,
	still call gimp_tool_clear_status() so the messages go away from
	displays the tool was only hovering.


svn path=/trunk/; revision=22123
2007-03-14 21:33:09 +00:00
Michael Natterer bb6530592f require either "procedure" or "prog" being non-NULL, not both of them at
2007-03-14  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimpplugin.c (gimp_plug_in_new): require either
	"procedure" or "prog" being non-NULL, not both of them at the same
	time. Get the executable name from the procedure if the procedure
	was passed.

	* app/plug-in/gimppluginmanager-call.c
	(gimp_plug_in_manager_call_run): pass a NULL prog since we already
	pass the procedure.


svn path=/trunk/; revision=22122
2007-03-14 20:03:10 +00:00
Sven Neumann 2e551e08fd sprinkled some const qualifiers and removed obscure shift code in favor of
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-render.c: sprinkled some const
	qualifiers and removed obscure shift code in favor of letting the
	compiler do this optimization.


svn path=/trunk/; revision=22121
2007-03-14 14:37:04 +00:00
Sven Neumann b95ead41e3 renamed newly added members to scale_x and scale_y and removed the
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell.[ch]: renamed newly added members
	to scale_x and scale_y and removed the SCALEFACTOR macros.

	* app/display/gimpdisplayshell-handlers.c
	* app/display/gimpdisplayshell-render.c
	* app/display/gimpdisplayshell-scale.c
	* app/display/gimpdisplayshell-transform.c
	* app/display/gimpnavigationeditor.c
	* app/tools/gimpforegroundselecttool.c
	* app/tools/gimprectangletool.c: changed accordingly.


svn path=/trunk/; revision=22120
2007-03-14 10:26:19 +00:00
Michael Natterer 94fe72a220 app/core/gimpbrush.c some minor fixes and stylistic paranoia i overlooked
2007-03-14  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpbrush.c
	* app/core/gimpbrushgenerated.c: some minor fixes and stylistic
	paranoia i overlooked in last night's late review.


svn path=/trunk/; revision=22119
2007-03-14 10:23:18 +00:00
Sven Neumann 74927c03a4 cache the display scale factors in the GimpDisplayShell struct and
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell.[ch]: cache the display scale
	factors in the GimpDisplayShell struct and recalculate it in
	gimp_display_shell_scale_factor_changed().

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_set_dot_for_dot)
	* app/display/gimpdisplayshell-handlers.c
	(gimp_display_shell_resolution_changed_handler)
	(gimp_display_shell_monitor_res_notify_handler): update the scale
	factors by calling gimp_display_shell_scale_factor_changed().

	* app/display/gimpdisplayshell-transform.c
	* app/display/gimpnavigationeditor.c: code cleanup.


svn path=/trunk/; revision=22118
2007-03-14 10:01:08 +00:00
Sven Neumann 7688860072 documentation.
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c (struct _PixelSurround): documentation.


svn path=/trunk/; revision=22117
2007-03-14 09:13:12 +00:00
Sven Neumann 8d53504d82 moved calculations out of MIN() macro.
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/base/siox.c (siox_drb): moved calculations out of MIN() macro.

svn path=/trunk/; revision=22116
2007-03-14 08:52:00 +00:00
Sven Neumann 642fd34b50 limit brush scale to [0.01, 10.0]
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/paint/gimppaintoptions.c: limit brush scale to [0.01, 
10.0]


svn path=/trunk/; revision=22115
2007-03-14 08:07:21 +00:00
Sven Neumann 21a0bf9f7b minor cleanups, moved calculations out of the MIN() macro, avoid unneeded
2007-03-14  Sven Neumann  <sven@gimp.org>

	* app/base/brush-scale.c: minor cleanups, moved calculations out
	of the MIN() macro, avoid unneeded floating-point calculations.


svn path=/trunk/; revision=22114
2007-03-14 07:29:43 +00:00
Martin Nordholts e3d9198cc4 Made brushes upscalable by using scale_region. Downscaling still uses
2007-03-14  Martin Nordholts  <martinn@svn.gnome.org>

	Made brushes upscalable by using scale_region. Downscaling still
	uses functions in app/base/brush-scale.c (because of better
	performance). Parametric brushes of course recalculates masks
	instead of using bitmap scaling. Fixes bug #65030.

	* app/core/gimpbrush.[ch]: Added a private scale_buf method which
	uses scale_region (with GIMP_INTERPOLATION_LINEAR) to scale its
	masks and pixmaps. Also added public virtual method scale_size to
	GimpBrush (overridden by GimpBrushGenerated) which calculates the
	buffer sizes for a given brush scaled with a given scale.

	* app/core/gimpbrushgenerated.c: Implemented the new scale_size
	method inherited from GimpBrush, and modified
	gimp_brush_generated_calc to use this helper function.

	* app/tools/gimppaintoptions-gui.c (gimp_paint_options_gui): Made
	the brush Scale-slider logarithmic.

	* app/paint/gimppaintoptions.c (gimp_paint_options_class_init):
	Changed Scale scale to [0.0, 10.0].

	* app/paint/gimpbrushcore.c:
	(gimp_brush_core_calc_brush_size): Refactored 'get brush size' code
	to where it belongs, in GimpBrush-classes, and allowed scales
	larger than 1.0.


svn path=/trunk/; revision=22113
2007-03-14 00:18:01 +00:00
Michael Natterer e8edf3f408 added new ugly function gimp_dialog_factory_hide_dialog() which does
2007-03-13  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdialogfactory.[ch]: added new ugly function
	gimp_dialog_factory_hide_dialog() which does gtk_widget_hide() and
	sets the stored visibility state to GIMP_DIALOG_VISIBILITY_INVISIBLE
	in order to avoid re-showing dialogs that were already insivible due
	to TAB-toggling when we gtk_widget_hided them.

	* app/tools/gimptransformtool.c
	* app/tools/gimpimagemaptool.c: use the new function instead of
	gtk_widget_hide() to hide tool dialogs. Fixes bug #414006.


svn path=/trunk/; revision=22111
2007-03-13 22:55:07 +00:00
Sven Neumann 54f709ec06 added a g_return_if_fail() check to catch bug #414006.
2007-03-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptransformtool.c (gimp_transform_tool_response):
	added a g_return_if_fail() check to catch bug #414006.


svn path=/trunk/; revision=22108
2007-03-13 07:43:37 +00:00
Sven Neumann 8374e79e49 code cosmetics.
2007-03-12  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-transform.c: code cosmetics.



svn path=/trunk/; revision=22106
2007-03-12 15:38:08 +00:00
Michael Natterer ef30d0079c lots of fixes and changes:
2007-03-12  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpmagnifytool.[ch]: lots of fixes and changes:

	- Request click events and use them instead of looking at the
	  distance the mouse travelled ourselves.
	- Also zoom when the user draws a very thin rectangle or just a
	  line, there is no reason to treat that as click.
	- Changed all calculations and stored values to double so the tool
	  continues to work smoothly at high zoom levels.
	- Fix scale calculation when zooming out (was totally b0rk).
	- Changed offset calculation when zooming out so that the current
	  viewport ends up within the drawn rectangle (which is the
	  opposite of what zooming in does).


svn path=/trunk/; revision=22105
2007-03-12 14:36:49 +00:00
Sven Neumann 4d44bacd74 deal with gimp_plug_in_procedure_get_label() returning NULL
svn path=/trunk/; revision=22104
2007-03-12 13:07:18 +00:00
Sven Neumann c63d0506ca gimp_plug_in_get_undo_desc() uses gimp_plug_in_procedure_get_label(). Made
2007-03-12  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimpplugin.[ch]: gimp_plug_in_get_undo_desc() uses
	gimp_plug_in_procedure_get_label(). Made the return value const.

	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/message.pdb
	* tools/pdbgen/pdb/undo.pdb: changed accordingly.

	* app/actions/plug-in-actions.c: cosmetics.

	* app/pdb/undo_cmds.c
	* app/pdb/message_cmds.c
	* app/pdb/drawable_cmds.c: regenerated.


svn path=/trunk/; revision=22103
2007-03-12 13:04:32 +00:00
Michael Natterer 4648f542cf app/core/gimpbrush.[ch] app/core/gimpbrushgenerated.c
2007-03-12  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpbrush.[ch]
	* app/core/gimpbrushgenerated.c
	* app/tools/gimppaintoptions-gui.c
	* app/base/brush-scale.[ch]
	* app/base/temp-buf.[ch]
	* app/paint/gimppaintoptions.c
	* app/paint/gimpbrushcore.c: revert last commit. The patch needs
	more review and it's easier to start from quare one than have
	patches on top of patches.


svn path=/trunk/; revision=22101
2007-03-12 09:33:57 +00:00
Michael Schumacher a4e81c3a6c Made brushes scalable (both up and down) by using existing scaling
2007-03-11  Michael Schumacher  <schumaml@cvs.gnome.org>

	Made brushes scalable (both up and down) by using existing
	scaling routines, and also refactored some brush-code. Patch by
	Martin Nordholts. Fixes bug #65030.

	* app/paint/gimpbrushcore.c:
	(gimp_brush_core_calc_brush_length_scale) Refactored 'get brush
	size' code to where it belongs, in GimpBrush-classes, and renamed
	gimp_brush_core_calc_brush_size to
	gimp_brush_core_calc_brush_length_scale.

	* app/paint/gimppaintoptions.c (gimp_paint_options_class_init):
	Changed Scale scale to [0.0, 100.0].

	* app/base/temp-buf.[ch] (mask_buf_new): Change signature to also
	take a bpp parameter.

	* app/base/brush-scale.[ch]: Changed brush_scale_(mask|pixmap) to
	the new brush_scale_buf, which uses existing scaling routines
	(scale_region) instead of dedicated down-scaling only routines.

	* app/tools/gimppaintoptions-gui.c (gimp_paint_options_gui): Made
	the brush Scale-slider logarithmic.

	* app/core/gimpbrushgenerated.c: Implemented the new
	get_scaled_size method inherited from GimpBrush, and modified
	gimp_brush_generated_calc to use this helper function.

	* app/core/gimpbrush.[ch]: Added public virtual method
	get_scaled_size to GimpBrush, overridden by GimpBrushGenerated,
	which calculates the buffer sizes for a given brush scaled with a
	given scale. Also changed calls to brush_scale_(mask|pixmap) to
	the new brush_scale_buf.

svn path=/trunk/; revision=22099
2007-03-11 16:28:08 +00:00
Sven Neumann 5eb341d2a5 removed default label from enum switch statement.
2007-03-10  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpeditselectiontool.c 
(gimp_edit_selection_tool_motion):
	removed default label from enum switch statement.


svn path=/trunk/; revision=22098
2007-03-10 22:35:21 +00:00
Sven Neumann 2d7f6cb50b unset the progress_active flag before popping the progress message
svn path=/trunk/; revision=22097
2007-03-10 22:10:56 +00:00
Sven Neumann 414eb93d72 while the statusbar is being used as a progress bar, only show progress
2007-03-10  Sven Neumann  <sven@gimp.org>

	* app/display/gimpstatusbar.c (gimp_statusbar_update): while the
	statusbar is being used as a progress bar, only show progress
	messages.


svn path=/trunk/; revision=22096
2007-03-10 22:07:42 +00:00
Sven Neumann 8fd67e0e95 cache the result of gimp_plug_in_procedure_get_label() and made the return
2007-03-10  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginprocedure.[ch]: cache the result of
	gimp_plug_in_procedure_get_label() and made the return value 
const.


	* app/actions/plug-in-actions.c
	* app/plug-in/gimpplugin-cleanup.c
	* app/plug-in/gimppluginmanager.c
	* app/widgets/gimpfiledialog.c
	* app/widgets/gimpfileprocview.c
	* app/widgets/gimpimagepropview.c: changed accordingly.

	* app/file/file-open.c
	* app/file/file-save.c: include the plug-in name (or actually 
the
	label) in the error messages.


svn path=/trunk/; revision=22095
2007-03-10 21:22:22 +00:00
Michael Natterer 4ddfeb7ddc don't include libgimpmath/gimpmathtypes.h
2007-03-10  Michael Natterer  <mitch@gimp.org>

	* app/core/core-types.h: don't include libgimpmath/gimpmathtypes.h

	* app/base/base-types.h: include it here. Also include
	libgimpcolor/gimpcolortypes.h


svn path=/trunk/; revision=22094
2007-03-10 19:31:07 +00:00
Michael Natterer 34130a569e forgot to commit this file.
svn path=/trunk/; revision=22093
2007-03-10 15:27:47 +00:00
Michael Natterer 55c9c20843 added value GIMP_BUTTON_RELEASE_NO_MOTION.
2007-03-10  Michael Natterer  <mitch@gimp.org>

	* app/tools/tools-enums.[ch] (enum GimpButtonReleaseType): added
	value GIMP_BUTTON_RELEASE_NO_MOTION.

	* app/tools/gimptool.[ch]: when click events are requested and the
	click was too long for a "click" event, send a NO_MOTION event if
	the pointer didn't move at all.

	* app/tools/gimpbucketfilltool.c: treat NO_MOTION as tool
	confirmation too.

	* app/tools/gimpfreeselecttool.c: request click events and treat
	both CLICK and NO_MOTION as tool confirmation.

	* app/tools/gimprectangletool.c: ignore NO_MOTION.


svn path=/trunk/; revision=22091
2007-03-10 15:07:56 +00:00
Sven Neumann 4e43d3048f fixed build of test-config.
2007-03-09  Sven Neumann  <sven@gimp.org>

	* app/config/Makefile.am: fixed build of test-config.


svn path=/trunk/; revision=22086
2007-03-09 19:29:31 +00:00
Michael Natterer 83d3a750d4 include "libgimpmath/gimpmathtypes.h" instead of "libgimpmath/gimpmath.h".
2007-03-09  Michael Natterer  <mitch@gimp.org>

	* app/core/core-types.h: include "libgimpmath/gimpmathtypes.h"
	instead of "libgimpmath/gimpmath.h".

	* app/core/gimpbrush.h
	* app/paint/gimppaintcore.h
	* app/paint/gimpperspectiveclone.h
	* app/text/gimptext.h
	* app/tools/gimptransformtool.h: include gimpvector.h and
	gimpmatrix.h explicitely where they are needed in public structs.

	* app/*/*.c
	* tools/pdbgen/pdb/paths.pdb: include "libgimpmath/gimpmath.h"
	where needed.

	* app/pdb/paths_cmds.c: regenerated.


svn path=/trunk/; revision=22084
2007-03-09 13:00:01 +00:00
Michael Natterer 974a74004f remove useless includes. Some minor cleanup.
2007-03-09  Michael Natterer  <mitch@gimp.org>

	* app/tools/*.c: remove useless includes. Some minor cleanup.


svn path=/trunk/; revision=22083
2007-03-09 11:10:40 +00:00
Sven Neumann 101d1b6512 replaced inner loop by a call to memcpy.
2007-03-09  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: replaced inner loop by a call to memcpy.


svn path=/trunk/; revision=22082
2007-03-09 10:18:25 +00:00
Sven Neumann 7758757d89 Much better fix which doesn't slow down handling of out-of-bounds requests
and also covers a corner case that the previous fix didn't handle. 

svn path=/trunk/; revision=22081
2007-03-09 09:53:21 +00:00
Sven Neumann 3760f9ec49 fixed handling of uncovered regions.
2007-03-09  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: fixed handling of uncovered 
regions.


svn path=/trunk/; revision=22080
2007-03-09 09:19:57 +00:00
Sven Neumann e62825eecc added missing call to gimp_rectangle_tool_update_options (). Fixes bug
2007-03-09  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_key_press):
	added missing call to gimp_rectangle_tool_update_options (). 
Fixes
	bug #416268.


svn path=/trunk/; revision=22079
2007-03-09 07:16:18 +00:00
Raphael Quinet 2c1e06c107 make the new feature visible in the status bar (alas, this implies a new
2007-03-09  Raphael Quinet  <raphael@gimp.org>

	* app/tools/gimpblendtool.c (gimp_blend_tool_push_status): make
	the new feature visible in the status bar (alas, this implies a
	new translatable string).

svn path=/trunk/; revision=22078
2007-03-08 23:33:55 +00:00
Michael Natterer e9029e04e0 renamed members and added last_x and last_y to remember the last mouse
2007-03-08  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpblendtool.h (struct GimpBlendTool): renamed
	members and added last_x and last_y to remember the last mouse
	coords.

	* app/tools/gimpblendtool.c: changed accordingly. Take drawable
	offset into account in button_release() and remove offset
	calculations from all other places. Enabled using ALT for moving
	the entire line.


svn path=/trunk/; revision=22077
2007-03-08 18:07:38 +00:00
Sven Neumann 012ecd81f5 do one less call to tile_manager_get_tile().
2007-03-08  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c (pixel_surround_get_data): do one less
	call to tile_manager_get_tile().


svn path=/trunk/; revision=22076
2007-03-08 16:38:53 +00:00
Michael Natterer 8fcb05e6e7 request click events, removed target_x,y struct members and button_press()
2007-03-08  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpbucketfilltool.[ch]: request click events, removed
	target_x,y struct members and button_press() implementation and
	use the coords passed in button_release(). Also make sure that
	a click has no effect in areas where we show the bad corsor.


svn path=/trunk/; revision=22075
2007-03-08 15:32:58 +00:00
Sven Neumann a092677a4d fixed boundary case.
2007-03-08  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: fixed boundary case.

svn path=/trunk/; revision=22073
2007-03-08 14:50:19 +00:00
Sven Neumann f663cb8bc4 app/tools/gimpperspectivetool.c app/tools/gimpscaletool.c
2007-03-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpperspectivetool.c
	* app/tools/gimpscaletool.c
	* app/tools/gimprotatetool.c
	* app/tools/gimpfliptool.c
	* app/tools/gimpsheartool.c
	* app/tools/gimptransformtool.[ch]: removed shell_desc member 
from
	GimpTransformToolClass and just use the tool blurb instead.


svn path=/trunk/; revision=22067
2007-03-08 08:21:39 +00:00
Sven Neumann 18efb16d5e added missing call to gimp_rectangle_tool_rectangle_changed(). Fixes bug
2007-03-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_key_press):
	added missing call to gimp_rectangle_tool_rectangle_changed().
	Fixes bug #415833.


svn path=/trunk/; revision=22066
2007-03-08 06:52:41 +00:00
Sven Neumann 1bdb26be15 describe usage of modifiers as suggested in bug #415796.
2007-03-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpvectoroptions.c (gimp_vector_options_gui): 
describe
	usage of modifiers as suggested in bug #415796.


svn path=/trunk/; revision=22065
2007-03-07 19:48:38 +00:00
Sven Neumann c9073a2449 reduced number of calls to tile_manager_get_tile().
2007-03-07  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c (pixel_surround_lock): reduced number
	of calls to tile_manager_get_tile().


svn path=/trunk/; revision=22064
2007-03-07 17:57:10 +00:00
Michael Natterer c2c21a30f2 Clean up fix for bug #328001:
2007-03-07  Michael Natterer  <mitch@gimp.org>

	Clean up fix for bug #328001:

	* app/tools/gimpeditselectiontool.[ch] (process_event_queue_keys):
	made private again.

	(gimp_edit_selection_tool_translate): new function which has an
	additional GimpTransformType parameter to determine what transform
	to perform. Do all the work here, ignoring the key event's
	modifier state.

	(gimp_edit_selection_tool_key_press): just determine the transform
	type from the key event's modifier state and call
	gimp_edit_selection_tool_translate().

	* app/tools/gimpmovetool.c (gimp_move_tool_key_press): removed all
	code and call gimp_edit_selection_tool_translate() with
	options->move_type. Moved the function to its proper place in the
	file.


svn path=/trunk/; revision=22063
2007-03-07 09:34:47 +00:00
Sven Neumann 4d76165127 keep an internal buffer filled with the background color and use it for
2007-03-07  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: keep an internal buffer filled with
	the background color and use it for out of bounds requests. 
Speed
	up filling the internal buffer by copying data row-by-row.


svn path=/trunk/; revision=22062
2007-03-06 23:32:25 +00:00
Sven Neumann f878258e5d Patch by Martin Nordholts. Fixes bug #328001.
2007-03-06  Sven Neumann  <sven@gimp.org>

	Patch by Martin Nordholts. Fixes bug #328001.

	* app/tools/gimpeditselectiontool.[ch] 
(process_event_queue_keys):
	Made process_event_queue_keys public for use of gimpmovetool.c.
	Still needs to be renamed and moved to another place.

	* app/tools/gimpmovetool.c (gimp_move_tool_key_press): Created
	gimp_move_tool_key_press() which takes care of events that
	gimp_edit_selection_tool_key_press() is not is able to
	handle. Otherwise just pass key events on to that method.


svn path=/trunk/; revision=22058
2007-03-06 19:56:08 +00:00
Michael Natterer d741af2656 if the user clicks inside an existing selection, initialize the rectangle
2007-03-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleselecttool.c
	(gimp_rect_select_tool_execute): if the user clicks inside an
	existing selection, initialize the rectangle tool to the entire
	selection, not just to the part of it that is within the active
	drawable. Also removed some dead code.


svn path=/trunk/; revision=22049
2007-03-05 21:03:02 +00:00
Sven Neumann 7044701112 added missing cast.
2007-03-05  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpstrokeeditor.c: added missing cast.


svn path=/trunk/; revision=22048
2007-03-05 20:28:31 +00:00
Michael Natterer e6fb62d4ac Makes default Select -> Border behaviour consistent, and makes 'sticky
2007-03-05  Michael Natterer  <mitch@gimp.org>

	Makes default Select -> Border behaviour consistent, and makes
	'sticky image edges' optional by adding a checkbox in the Border
	Selection dialog. Patch by Martin Nordholts. Fixes bug #350009.

	* app/actions/select-commands.c (select_border_cmd_callback)
	(select_border_callback): Added edge-lock checkbox to dialog and
	modified calls accordingly.

	* app/paint-funcs/paint-funcs.c (border_region)
	(compute_transition): Fixed algorithm. (compute_transition is a
	helper function to the algorithm). Also clarified many parts of
	the algorithm with comments.

	* app/paint-funcs/paint-funcs.h
	* app/core/gimpchannel.[ch]
	* app/core/gimpselection.c: Added gboolean edge_lock to function
	calls/signatures.

	* app/pdb/selection_cmds.c: Regenerated. 


svn path=/trunk/; revision=22047
2007-03-05 20:21:23 +00:00
Michael Natterer 395b06ad8b added typdef GimpMemsizeFunc.
2007-03-05  Michael Natterer  <mitch@gimp.org>

	* app/core/core-types.h: added typdef GimpMemsizeFunc.

	* app/core/gimp-utils.[ch]: added _foreach() variants of
	GHashTable, GList and GSList functions which take GimpMemsizeFunc
	callbacks. Added gimp_parasite_get_memsize(). Added "data_size"
	parameter to gimp_g_hash_table_get_memsize().

	* app/core/gimp.c
	* app/core/gimppalette.c
	* app/core/gimpparasitelist.c
	* app/pdb/gimppdb.c
	* app/plug-in/gimppluginmanager.c: use the new functions instead
	of itering manually or ignoring the containers' elements. Changed
	callers of gimp_g_hash_table_get_memsize().


svn path=/trunk/; revision=22046
2007-03-05 20:09:46 +00:00
Michael Natterer 1bfc742f03 don't pass random strings to g_print() without running them through %s.
2007-03-04  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpobject.c (gimp_object_get_memsize): don't pass
	random strings to g_print() without running them through %s.
	Fixes crash/warning when the string contains '%'.


svn path=/trunk/; revision=22042
2007-03-04 21:38:50 +00:00
Hans Breuer f8b13080e4 updated
2007-03-04  Hans Breuer  <hans@breuer.org>

	* **/makefile.msc app/gimpcore.def : updated


svn path=/trunk/; revision=22041
2007-03-04 19:04:42 +00:00
Sven Neumann f1692ea6fc app/display/gimpdisplayshell.[ch] only change the remembered last scale
2007-03-04  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell.[ch]
	* app/display/gimpdisplayshell-scale.c: only change the 
remembered
	last scale value if the last change occured more than a second 
ago.

	* app/tools/gimprectangletool.c: fixed compiler warnings.


svn path=/trunk/; revision=22040
2007-03-04 10:27:17 +00:00
Michael Natterer 4dd7d18b06 use gimp_drawable_bytes_with_alpha() instead of manually adding alpha to
2007-03-01  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdrawable-blend.c (gimp_drawable_blend): use
	gimp_drawable_bytes_with_alpha() instead of manually adding
	alpha to the value returned by gimp_drawable_bytes()


svn path=/trunk/; revision=22037
2007-03-01 17:53:56 +00:00
Raphael Quinet ff6ca82828 don't suggest Shift when a new point cannot be added to point 0.
2007-02-29  Raphael Quinet  <raphael@gimp.org>

	* app/tools/gimpmeasuretool.c (gimp_measure_tool_cursor_update): 
	don't suggest Shift when a new point cannot be added to point 0.

svn path=/trunk/; revision=22031
2007-03-01 08:52:37 +00:00
Raphael Quinet 89c4abd6ea added status bar help messages explaining the usage of the modifiers.
2007-02-28  Raphael Quinet  <raphael@gimp.org>

	* app/tools/gimpmeasuretool.[ch]: added status bar help messages
	explaining the usage of the modifiers.

	* app/tools/gimpvectortool.c (gimp_vector_tool_status_update):
	suggest Ctrl for edit mode, to close the path or move handles.

	* app/tools/gimpcroptool.c (gimp_crop_tool_button_release):
	"press enter" should be "press Enter", as in the other tools.

svn path=/trunk/; revision=22030
2007-02-28 22:35:37 +00:00
Sven Neumann 8353fafbc5 made labels selectable.
2007-02-28  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpmeasuretool.c: made labels selectable.

svn path=/trunk/; revision=22029
2007-02-28 16:46:55 +00:00
João S. O. Bueno Calligaris d7b7bb40b9 removes recursive code when adjusting rectangle size. Fixes bug #410234.
2007-02-28  João S. O. Bueno Calligaris <gwidion@mpc.com.br>

        * app/tools/gimprectangletool.c: removes recursive code
        when adjusting rectangle size. Fixes bug #410234.

svn path=/trunk/; revision=22028
2007-02-28 16:05:52 +00:00
Sven Neumann 6e59aec825 simplified callers and moved calculations out of the SQR() macro.
2007-02-28  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptool.c (gimp_tool_check_click_distance):
	simplified callers and moved calculations out of the SQR() macro.


svn path=/trunk/; revision=22027
2007-02-28 16:00:26 +00:00
Sven Neumann 0af9507ab8 don't change the selection while the tool is active. Fixes bug #398185.
2007-02-28  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangleselecttool.c
	(gimp_rect_select_tool_rectangle_changed): don't change the
	selection while the tool is active. Fixes bug #398185. Thanks to
	Martin Nordholts for investigating this problem.

	* app/tools/gimprectangletool.c: minor cleanup.


svn path=/trunk/; revision=22025
2007-02-28 13:08:09 +00:00
Michael Natterer 9e15c24251 need to check the distance in screen coords, not image coords.
2007-02-28  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.c (gimp_tool_check_click_distance): need to
	check the distance in screen coords, not image coords.

	* app/tools/gimpmovetool.c (gimp_move_tool_button_release): forgot
	two manual checks for GDK_BUTTON3_MASK.


svn path=/trunk/; revision=22024
2007-02-28 13:04:20 +00:00
Michael Natterer b60fbd3324 even more whitespace cleanup.
2007-02-28  Michael Natterer  <mitch@gimp.org>

	* app/core/gimp-transform-resize.c: even more whitespace cleanup.


svn path=/trunk/; revision=22023
2007-02-28 11:17:29 +00:00
Sven Neumann a75dc8a046 removed trailing whitespace.
2007-02-28  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-resize.c: removed trailing whitespace.


svn path=/trunk/; revision=22022
2007-02-28 09:14:40 +00:00
Sven Neumann c294d9bc94 app/core/gimpimage-scale.c app/core/gimpimage-rotate.c
2007-02-28  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-scale.c
	* app/core/gimpimage-rotate.c
	* app/core/gimpimage-resize.c
	* app/core/gimpimage-flip.c: cosmetics.


svn path=/trunk/; revision=22021
2007-02-28 08:57:17 +00:00
Sven Neumann bcbca9b612 documentation.
2007-02-27  Sven Neumann  <sven@gimp.org>

        * app/base/pixel-surround.c: documentation.


svn path=/trunk/; revision=22020
2007-02-27 21:55:52 +00:00
Michael Natterer d40c0a5883 clean up last commit a bit. Pass the recorded button_press_coords to
2007-02-27  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.[ch]: clean up last commit a bit. Pass the
	recorded button_press_coords to GimpTool::button_release() when a
	click was detected.


svn path=/trunk/; revision=22019
2007-02-27 21:40:35 +00:00
Sven Neumann 54cfb83fec increased default value for "undo-size" to 64 MB.
2007-02-27  Sven Neumann  <sven@gimp.org>

	* app/config/gimpcoreconfig.c: increased default value for
	"undo-size" to 64 MB.

	* app/config/gimpguiconfig.c: increased default value for
	'max-new-image-size' to 128 MB.


svn path=/trunk/; revision=22017
2007-02-27 21:13:49 +00:00
Michael Natterer 83eb96db21 added "gboolean wants_click" member and getters/setters.
2007-02-27  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptoolcontrol.[ch]: added "gboolean wants_click"
	member and getters/setters.

	* app/tools/gimptool.[ch] (struct GimpTool): added members
	in_click_distance, press_coords and press_time.

	(gimp_tool_button_press): if the tool wants click events, record
	press_coords and press_time.

	(gimp_tool_motion): check if we are still in click distance.

	(gimp_tool_button_release): ditto. If we are still in click
	distance, synthesize a motion event back to the recorded
	press_coords and send the tool release_type = CLICK.

	(gimp_tool_check_click_distance): utility function which checks
	the current coords and time against the recorded ones, using
	gtk-double-click-time and gtk-double-click-distance as thresholds.

	* app/tools/gimpcroptool.c
	* app/tools/gimprectangleselecttool.c: request click events
	and handle them.

	* app/tools/gimprectangletool.[ch]: handle click events. Removed
	gimp_rectangle_tool_no_movement().


svn path=/trunk/; revision=22016
2007-02-27 21:11:35 +00:00
Michael Natterer d7ed63948c Step one towards enabling tool cancellation by other means than mouse
2007-02-27  Michael Natterer  <mitch@gimp.org>

	Step one towards enabling tool cancellation by other means than
	mouse button 3 and towards proper "clicked" semantics.

	* app/tools/tools-enums.[ch]: added enum GimpButtonReleaseType
	which can be one of { NORMAL, CANCEL, CLICK } (click is curently
	unused).

	* app/tools/gimptool.[ch] (GimpTool::button_release): added
	"release_type" parameter.

	(gimp_tool_button_release): if the state contains
	GDK_BUTTON3_MASK, call the tool's button_release() with CANCEL,
	use NORMAL otherwise.

	* app/tools/gimpaligntool.c
	* app/tools/gimpblendtool.c
	* app/tools/gimpbrightnesscontrasttool.c
	* app/tools/gimpbucketfilltool.c
	* app/tools/gimpcolortool.c
	* app/tools/gimpcroptool.c
	* app/tools/gimpcurvestool.c
	* app/tools/gimpeditselectiontool.c
	* app/tools/gimpforegroundselecttool.c
	* app/tools/gimpfreeselecttool.c
	* app/tools/gimpiscissorstool.c
	* app/tools/gimpmagnifytool.c
	* app/tools/gimpmeasuretool.c
	* app/tools/gimpmovetool.c
	* app/tools/gimppainttool.c
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.[ch]
	* app/tools/gimpregionselecttool.c
	* app/tools/gimptransformtool.c
	* app/tools/gimpvectortool.c (button_release): added
	"release_type" parameters and get rid of own checks for
	GDK_BUTTON3_MASK.


svn path=/trunk/; revision=22015
2007-02-27 18:55:12 +00:00
Michael Natterer e172a72c63 set the gradient-type and gradient-repeat combo boxes to ELLIPSIZE_END so
2007-02-27  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpblendoptions.c (gimp_blend_options_gui): set the
	gradient-type and gradient-repeat combo boxes to ELLIPSIZE_END so
	the blend options can be one tool icon size smaller without
	scrolling horizontally.


svn path=/trunk/; revision=22014
2007-02-27 18:44:55 +00:00
Sven Neumann 4a6b039f88 update the progress less often.
2007-02-27  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/scale-funcs.c: update the progress less often.

svn path=/trunk/; revision=22013
2007-02-27 16:59:24 +00:00
Sven Neumann 776f7973b2 follow the internal API change
svn path=/trunk/; revision=22011
2007-02-27 11:10:17 +00:00
Sven Neumann 6852fc8068 allow the parent progress to be NULL. Documented the API.
2007-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpsubprogress.[ch]: allow the parent progress to be NULL.
	Documented the API.

	* app/core/gimpimage-scale.c: use the sub-progress unconditionally.


svn path=/trunk/; revision=22010
2007-02-27 11:03:18 +00:00
Sven Neumann 5b5082a433 app/core/Makefile.am app/core/core-types.h added GimpSubProgress, an
2007-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/Makefile.am
	* app/core/core-types.h
	* app/core/gimpsubprogress.[ch]: added GimpSubProgress, an 
object
	that implements the GimpProgress interface and maps progress
	information to a sub-range of the parent progress.

	* app/core/gimpimage-scale.c (gimp_image_scale): use the new 
object.


svn path=/trunk/; revision=22009
2007-02-27 09:39:31 +00:00
Sven Neumann 99e507de58 removed a redundant condition and marked another one as unlikely.
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c (normalize_coords): removed a
	redundant condition and marked another one as unlikely.


svn path=/trunk/; revision=22008
2007-02-26 19:43:14 +00:00
Sven Neumann b3ec8a219d app/core/gimpimage-scale.c cosmetics.
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-scale.c
	* app/actions/image-commands.c: cosmetics.


svn path=/trunk/; revision=22007
2007-02-26 18:53:07 +00:00
Sven Neumann f267e26644 just redraw the canvas
svn path=/trunk/; revision=22006
2007-02-26 16:03:14 +00:00
Sven Neumann 352d64ab5e cosmetics
svn path=/trunk/; revision=22005
2007-02-26 15:32:54 +00:00
Sven Neumann e644c56ce0 queue a redraw of the display shell instead of exposing the transform
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptransformtool.c (gimp_transform_tool_doit): queue
	a redraw of the display shell instead of exposing the transform
	preview. Removes annoying flicker when the tool is finished.


svn path=/trunk/; revision=22004
2007-02-26 15:12:26 +00:00
Sven Neumann e2ae556117 moved common code to an inlined function. gimp_transform_region_lanczos()
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c: moved common code to an
	inlined function. gimp_transform_region_lanczos() now also does
	supersampling.  Removed boundary checks and clamping as
	PixelSurround and read_pixel_data_1() already deal with this for
	us. Gives another small speedup.


svn path=/trunk/; revision=21999
2007-02-26 14:16:31 +00:00
Sven Neumann 6b7996a3e7 use PixelSurround instead of read_pixel_data_1(). This yields a dramatic
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c (gimp_transform_region_lanczos):
	use PixelSurround instead of read_pixel_data_1(). This yields a
	dramatic speedup.


svn path=/trunk/; revision=21998
2007-02-26 13:36:50 +00:00
Sven Neumann ca30a115b3 iterate over tiles instead of rows in the destination buffer.
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c (gimp_transform_region_lanczos):
	iterate	over tiles instead of rows in the destination buffer.


svn path=/trunk/; revision=21997
2007-02-26 13:03:51 +00:00
Sven Neumann 43d2cde05f moved linear and cubic code to their own functions and let them iterate
2007-02-24  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c (gimp_transform_region): moved
	linear and cubic code to their own functions and let them iterate
	over tiles instead of rows in the destination buffer.


svn path=/trunk/; revision=21996
2007-02-26 11:50:02 +00:00
Sven Neumann cc6a517f5b added more const qualifiers.
2007-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c: added more const qualifiers.


svn path=/trunk/; revision=21992
2007-02-26 09:33:13 +00:00
Sven Neumann 4232b8fa4e operate on tiles instead of iterating row by row.
2007-02-24  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c 
(gimp_transform_region_nearest):
	operate on tiles instead of iterating row by row.


svn path=/trunk/; revision=21988
2007-02-24 16:40:56 +00:00
Sven Neumann ef28e94e7f moved nearest-neighbor code to it's own function to improve performance
2007-02-24  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c (gimp_transform_region):
	moved nearest-neighbor code to it's own function to improve
	performance and readability.


svn path=/trunk/; revision=21987
2007-02-24 15:49:25 +00:00
Sven Neumann db72bf1358 moved lanczos code into it's own function to improve readability.
2007-02-23  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c (gimp_transform_region): 
moved
	lanczos code into it's own function to improve readability.


svn path=/trunk/; revision=21986
2007-02-23 19:04:19 +00:00
Sven Neumann 74776dd44e cosmetics
svn path=/trunk/; revision=21985
2007-02-23 16:35:38 +00:00
Sven Neumann 6788bffb5c do less tile lock and release operations by reusing the last locked tile
2007-02-23  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.[ch]: do less tile lock and release
	operations by reusing the last locked tile if possible. Allow to
	call pixel_surround_lock() several times without unlocking.

	* app/core/gimp-transform-region.c: don't unlock the PixelSurround
	so that the locked tile can be reused. Yields about 30% speedup
	for transformations.


svn path=/trunk/; revision=21984
2007-02-23 16:19:42 +00:00
Sven Neumann 9a30c767a2 code cleanup.
2007-02-23  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c (pixel_surround_lock): code cleanup.


svn path=/trunk/; revision=21981
2007-02-23 10:59:02 +00:00
Sven Neumann c0c273f9ce allocate the PixelSurround struct and its buffer in one chunk.
2007-02-22  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-surround.c: allocate the PixelSurround struct and
	its buffer in one chunk.


svn path=/trunk/; revision=21980
2007-02-23 10:10:44 +00:00
Sven Neumann 9d32b72c6f app/base/base-types.h hide PixelSurround struct and cleaned up the
2007-02-22  Sven Neumann  <sven@gimp.org>

	* app/base/base-types.h
	* app/base/pixel-surround.[ch]: hide PixelSurround struct and
	cleaned up the PixelSurround API.

	* app/core/gimp-transform-region.c: changed accordingly. Also
	sprinkled some const qualifiers.

svn path=/trunk/; revision=21978
2007-02-23 09:50:42 +00:00
Sven Neumann 3f7c188f59 made tile_ref_count a static variable and added a function to access it.
2007-02-22  Sven Neumann  <sven@gimp.org>

	* app/base/tile.[ch]: made tile_ref_count a static variable and
	added a function to access it.  Declared other (unused) global
	counters as static variables and moved them into #ifdefs.

	* app/base/tile-swap.c: use the function instead of declaring
	tile_ref_count as extern.

	* app/base/tile-manager.c
	* app/base/pixel-surround.c: cosmetics.


svn path=/trunk/; revision=21975
2007-02-22 22:28:24 +00:00
Sven Neumann fbdafbb7cd use a named template to avoid code duplication.
2007-02-22  Sven Neumann  <sven@gimp.org>

	* app/dialogs/authors.xsl: use a named template to avoid code
	duplication.


svn path=/trunk/; revision=21972
2007-02-22 08:04:16 +00:00
Sven Neumann d9b5f03230 added an explicit dependency on authors.h.
2007-02-21  Sven Neumann  <sven@gimp.org>

	* app/dialogs/Makefile.am: added an explicit dependency on authors.h.


svn path=/trunk/; revision=21969
2007-02-21 16:47:36 +00:00
Tor Lillqvist 0adf7e22da Guard against event being NULL.
2007-02-20  Tor Lillqvist  <tml@novell.com>

	* app/widgets/gimpcontrollereditor.c
	(gimp_controller_editor_sel_changed): Guard against event being
	NULL.


svn path=/trunk/; revision=21963
2007-02-20 19:50:32 +00:00
Sven Neumann 80e2e6bf47 changed XPath expression to only match on contributors that have been
2007-02-20  Sven Neumann  <sven@gimp.org>

        * app/dialogs/authors.xsl: changed XPath expression to only match
        on contributors that have been active in the 2.4 development cycle.


svn path=/trunk/; revision=21959
2007-02-20 11:39:40 +00:00
Sven Neumann 63e7ba1bfc let authors.h depend on authors.xsl.
2007-02-20  Sven Neumann  <sven@gimp.org>

	* app/dialogs/Makefile.am: let authors.h depend on authors.xsl.

	* app/dialogs/authors.h: removed from repository, it's 
generated.

	* app/dialogs/authors.xsl: only include contributors that have
	contributed to GIMP 2.x. We might want to limit this even 
further.


svn path=/trunk/; revision=21956
2007-02-20 00:31:33 +00:00
Karine Delvare cca7049d61 authors.dtd added mandatory last-active attribute, and added several 2.4
2007-02-19  Karine Delvare  <edhel@gimp.org>

	* authors.dtd
	* authors.xml: added mandatory last-active attribute, and added
	several 2.4 contributors.

	* AUTHORS
	* app/dialogs/authors.h: regenerated.


svn path=/trunk/; revision=21955
2007-02-19 21:09:18 +00:00
Michael Natterer 4ed0eb238f app/plug-in/gimpplugin.c (gimp_plug_in_add_temp_proc) remove duplicate
2007-02-19  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimpplugin.c (gimp_plug_in_add_temp_proc)
	* app/plug-in/gimpplugindef.c (gimp_plug_in_def_add_procedure):
	remove duplicate procedures before adding the new one.
	
	* app/plug-in/gimpplugin-message.c
	(gimp_plug_in_handle_proc_install): don't remove duplicates here.


svn path=/trunk/; revision=21945
2007-02-19 09:36:19 +00:00
Michael Natterer be5fbd643e app/plug-in/Makefile.am app/plug-in/plug-in-types.h removed...
2007-02-19  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/Makefile.am
	* app/plug-in/plug-in-types.h
	* app/plug-in/plug-in-def.[ch]: removed...

	* app/plug-in/gimpplugindef.[ch]: ...and added as object. Merged
	locale and help domain setters into one function each.

	* app/plug-in/gimpplugin-message.c
	* app/plug-in/gimpplugin.[ch]
	* app/plug-in/gimppluginmanager-call.[ch]
	* app/plug-in/gimppluginmanager-file.c
	* app/plug-in/gimppluginmanager.c
	* app/plug-in/plug-in-rc.c
	* tools/pdbgen/pdb/plug_in.pdb: changed accordingly.

	* app/pdb/plug_in_cmds.c: regenerated.


svn path=/trunk/; revision=21944
2007-02-19 01:16:05 +00:00
Michael Natterer ab239c3d63 app/text/gimptext-parasite.c use g_strtod() instead of atof() because
2007-02-18  Michael Natterer  <mitch@gimp.org>

	* app/text/gimptext-parasite.c
	* plug-ins/flame/libifs.c: use g_strtod() instead of atof()
	because these files have to parse strings that never had a clearly
	specified format.

	* plug-ins/script-fu/tinyscheme/scheme.c
	* plug-ins/imagemap/imap_cern.l
	* plug-ins/imagemap/imap_csim.l
	* plug-ins/imagemap/imap_csim.y
	* plug-ins/imagemap/imap_ncsa.l: use g_ascii_strtod() instead of
	atof() because scheme code and imagemap files with wrong decimal
	separators are clearly broken and should be rejected.

	* plug-ins/imagemap/imap_cern_lex.c
	* plug-ins/imagemap/imap_csim_lex.c
	* plug-ins/imagemap/imap_csim_parse.c
	* plug-ins/imagemap/imap_ncsa_lex.c: regenerated.

	* plug-ins/common/sample_colorize.c: round numbers using sane code
	instead of sprintf() and atod().

	* plug-ins/Lighting/lighting_ui.c: removed some dead code.


svn path=/trunk/; revision=21942
2007-02-18 20:01:48 +00:00
Sven Neumann 4be5892ef3 show an informational message in the statusbar. There is otherwise no
2007-02-18  Sven Neumann  <sven@gimp.org>

	* app/actions/edit-commands.c (edit_copy_cmd_callback): show an
	informational message in the statusbar. There is otherwise no
	indication that something has happened.


svn path=/trunk/; revision=21940
2007-02-18 18:50:55 +00:00
Michael Natterer 36a955a5ef add "locale_domain" and "help_domain" members and APIs to get/set them.
2007-02-18  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimppluginprocedure.[ch]: add "locale_domain" and
	"help_domain" members and APIs to get/set them. Removed locale and
	help domain parameters from all other functions.

	* app/plug-in/gimpplugin.c (gimp_plug_in_add_temp_proc)
	* app/plug-in/plug-in-def.c (plug_in_def_add_procedure)
	(plug_in_def_set_locale_domain_name)
	(plug_in_def_set_help_domain_name): make sure all plug-in procedures
	have locale and help domains.

	* app/plug-in/gimppluginmanager.[ch]: removed function
	gimp_plug_in_manager_get_label().

	* app/plug-in/gimppluginmanager.c
	* app/plug-in/gimpplugin-cleanup.c
	* app/actions/plug-in-actions.c
	* app/widgets/gimpfiledialog.c
	* app/widgets/gimpfileprocview.c
	* app/widgets/gimpimagepropview.c: changed (simplified) accordingly.


svn path=/trunk/; revision=21937
2007-02-18 14:25:34 +00:00
Sven Neumann 1504a7f5bd skip Windows ICO as writable format. It's not well suited as a general
2007-02-18  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimppixbuf.c (gimp_pixbuf_targets_add): skip 
Windows
	ICO as writable format. It's not well suited as a general image
	exchange format and the GdkPixbuf save routine seems to be 
buggy.


svn path=/trunk/; revision=21936
2007-02-18 08:57:16 +00:00
Michael Natterer d212161c00 app/core/gimp-utils.[ch] app/core/gimp.c app/widgets/gimpcontrollerinfo.c
2007-02-17  Michael Natterer  <mitch@gimp.org>

	* app/core/gimp-utils.[ch]
	* app/core/gimp.c
	* app/widgets/gimpcontrollerinfo.c
	* libgimpwidgets/gimpcontroller.c: removed various boolean_handled
	signal accumulators and use g_signal_accumulator_true_handled().


svn path=/trunk/; revision=21933
2007-02-17 11:45:59 +00:00
Sven Neumann 207d8d1ee1 use GTK_STOCK_SAVE as icon for the message dialog.
2007-02-16  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-close.c: use GTK_STOCK_SAVE as icon
	for the message dialog.

	* app/actions/data-commands.c (data_delete_cmd_callback): improved
	delete dialog.


svn path=/trunk/; revision=21928
2007-02-16 12:59:10 +00:00
Sven Neumann ccafc8d3bd app/actions/plug-in-actions.c added utility function to retrieve the
2007-02-14  Sven Neumann  <sven@gimp.org>

	* app/actions/plug-in-actions.c
	* app/plug-in/gimppluginprocedure.[ch]: added utility function to
	retrieve the translated blurb of a plug-in procedure. Make sure
	that gettext isn't called with the empty string.


svn path=/trunk/; revision=21917
2007-02-14 13:38:09 +00:00
Sven Neumann d09c931131 when multi-line strings end up being passed to the statusbar, only show
2007-02-14  Sven Neumann  <sven@gimp.org>

	* app/display/gimpstatusbar.c: when multi-line strings end up
	being passed to the statusbar, only show the first line.


svn path=/trunk/; revision=21916
2007-02-14 13:13:40 +00:00
Sven Neumann 462b5e0b45 update the progress less often.
2007-02-13  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-convert.c: update the progress less often.


svn path=/trunk/; revision=21913
2007-02-13 16:33:41 +00:00
Sven Neumann 0d5bf0ffda don't use button as parent widget, it might be NULL.
2007-02-13  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontrollerlist.c 
(gimp_controller_list_edit_clicked):
	don't use button as parent widget, it might be NULL.


svn path=/trunk/; revision=21907
2007-02-13 08:08:57 +00:00
Sven Neumann 0a203e30c4 libgimpwidgets/Makefile.am libgimpwidgets/gimpwidgetstypes.h
2007-02-12  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/Makefile.am
	* libgimpwidgets/gimpwidgetstypes.h
	* libgimpwidgets/gimpwidgets.h
	* libgimpwidgets/gimpstringcombobox.[ch]: added GimpStringComboBox.

	* libgimpwidgets/gimppropwidgets.[ch]: added a prop widget
	constructor that uses the new widget.

	* libgimpwidgets/gimpwidgets.def: updated.

	* app/widgets/gimpcontrollereditor.c: use a GimpStringComboBox if
	the module specifies a tree model with string values.

	* modules/gimpinputdevicestore.c: minor cleanup.

	* modules/controller_linux_input.c: keep a pointer to the input
	device store and unref it in the finalizer.


svn path=/trunk/; revision=21900
2007-02-12 15:29:45 +00:00
Sven Neumann 4f6e2969c6 use a GimpDialog instead of a GimpViewableDialog.
2007-02-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontrollerlist.c (gimp_controller_list_edit_clicked):
	use a GimpDialog instead of a GimpViewableDialog.


svn path=/trunk/; revision=21899
2007-02-12 13:12:47 +00:00
Sven Neumann 32514d2d82 app/widgets/gimppropwidgets.c most property widgets rely on a writable
2007-02-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimppropwidgets.c
	* libgimpwidgets/gimppropwidgets.c: most property widgets rely on
	a writable property. Check for that or make the widget non-editable
	if the G_PARAM_WRITABLE flag is unset.


svn path=/trunk/; revision=21898
2007-02-12 11:01:08 +00:00
Sven Neumann 0f3392aac5 fine-tuning
svn path=/trunk/; revision=21897
2007-02-12 10:39:50 +00:00
Sven Neumann 6ea68a7d48 minor refactoring.
2007-02-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontrollereditor.c: minor refactoring.

	* libgimpwidgets/gimppropwidgets.c (gimp_prop_label_new): allow
	this function to be used with properties that are transformable 
to
	string values, not only with string properties.


svn path=/trunk/; revision=21896
2007-02-12 08:44:25 +00:00
Michael Natterer b1093d65a3 plug leak introduced with last commit: simply always use the deserialized
2007-02-11  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpcontainer.c (gimp_container_deserialize): plug leak
	introduced with last commit: simply always use the deserialized
	name, also on ojects already existing in the container.


svn path=/trunk/; revision=21890
2007-02-11 12:48:41 +00:00
Michael Natterer 8cffeb0689 Made templates say "ppi" instead of "dpi". Fixes bug #376990:
2007-02-10  Michael Natterer  <mitch@gimp.org>

	Made templates say "ppi" instead of "dpi". Fixes bug #376990:

	* app/core/gimp-templates.c
	(gimp_templates_migrate_get_child_by_name): find the child also
	if the name differs only in the substrings "dpi" and "ppi".

	* app/core/gimpcontainer.c (gimp_container_deserialize): if we
	found a child, give it the deserialized name if it isn't the same
	as its old name.

	* etc/templaterc: applied patch from Michael Schumacher that
	replaces "dpi" by "ppi".


svn path=/trunk/; revision=21888
2007-02-10 10:37:20 +00:00
Michael Natterer f5f93181da renamed newly added functions to gimp_environ_table_str_hash() and
2007-02-09  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimpenvirontable.c: renamed newly added functions to
	gimp_environ_table_str_hash() and gimp_environ_table_str_equal()
	and always use them. Move the #ifdef G_OS_WIN32 inside the
	functions.


svn path=/trunk/; revision=21884
2007-02-09 16:10:21 +00:00
Tor Lillqvist 822065c0b0 Win32-only case- insensitive hash and equality functions.
2007-02-09  Tor Lillqvist  <tml@novell.com>

	* app/plug-in/gimpenvirontable.c
	(gimp_environ_table_case_insensitive_hash)
	(gimp_environ_table_case_insensitive_equal): Win32-only case-
	insensitive hash and equality functions.
	(gimp_environ_table_load): On Win32, use the above functions for
	the vars hash table. This fixes the problem that occurs when the
	actual PATH environment variable is spelled Path (as it seems to
	often be), but the default.env file as set up by the installer
	provides PATH. They didn't match so both would be passed to the
	plug-in child process, and apparently which one then was used to
	look for DLLs was more or less random. If it was the original
	Path, it didn't contain the directories the installer put in PATH
	in default.env, and plug-ins didn't find the DLLs.


svn path=/trunk/; revision=21883
2007-02-09 11:45:00 +00:00
Sven Neumann 538378e79c moved ratio entry up.
2007-02-09  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangleoptions.c: moved ratio entry up.


svn path=/trunk/; revision=21880
2007-02-09 08:36:27 +00:00
Michael Natterer 181c9efbba ellipsize the module info labels so they don't make the dialog grow when
2007-02-09  Michael Natterer  <mitch@gimp.org>

	* app/dialogs/module-dialog.c (dialog_info_init): ellipsize the
	module info labels so they don't make the dialog grow when
	browsing the module list.


svn path=/trunk/; revision=21879
2007-02-08 23:38:29 +00:00
Sven Neumann d1a2697c80 moved duplicated code to utility function
2007-02-09  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: moved duplicated code to
	utility function gimp_rectangle_tool_set_highlight().


svn path=/trunk/; revision=21878
2007-02-08 23:19:57 +00:00
Michael Natterer 1da4a19fe7 app/paint/paint-types.h move opaque typedefs of object instances to
2007-02-08  Michael Natterer  <mitch@gimp.org>

	* app/paint/paint-types.h
	* app/paint/*.h: move opaque typedefs of object instances to
	paint-types.h, don't typedef empty class stuctures as their parent
	class (gtk-doc gets confused), cleanups.


svn path=/trunk/; revision=21877
2007-02-08 22:58:22 +00:00
Sven Neumann b76ad2b84e app/tools/gimprectangleoptions.c moved code around.
2007-02-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangleoptions.c
	* app/widgets/gimppropwidgets.[ch]: moved code around.


svn path=/trunk/; revision=21876
2007-02-08 22:49:50 +00:00
Sven Neumann aba50bbc14 code cleanup. Pack the widgets the way we usually do this.
2007-02-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangleoptions.c (gimp_rectangle_options_gui):
	code cleanup. Pack the widgets the way we usually do this.


svn path=/trunk/; revision=21875
2007-02-08 16:59:40 +00:00
Sven Neumann aac28d11ca applied patch from Robert Helgesson. Adds documentation (bug #405760).
2007-02-08  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-scale.c: applied patch from Robert
	Helgesson. Adds documentation (bug #405760).

svn path=/trunk/; revision=21874
2007-02-08 16:40:46 +00:00
Sven Neumann fbc67ff207 reduced default spacing.
2007-02-08  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpenumwidgets.c
	(gimp_enum_stock_box_new_with_range): reduced default spacing.

	* app/tools/gimpcurvestool.c (gimp_curves_tool_dialog): don't
	increase the box's spacing.

	* app/tools/gimprectangleoptions.c: added portrait/landscape
	buttons.

	* app/widgets/gimppropwidgets.c (gimp_prop_aspect_ratio_new):
	reduced default width of entry.  Swap width and height when the
	aspect changes and fixed-aspect is chosen.

svn path=/trunk/; revision=21873
2007-02-08 16:36:23 +00:00