This was added in commits 447d9bbc56 and fb6328b9ad.
With it, the validation succeeds. Still I am actually not sure that is
proper appdata format. Also we have issues of metadata not shown for our
flatpak package, and I am wondering if this could be the issue.
So let's get rid of this hack.
Also temporarily commenting out the appdata unit test because it fails
without, because of a bug in appstream-util. This bug has been fixed
since, but there are no releases containing this fix yet.
See: https://github.com/hughsie/appstream-glib/issues/234
We'll reactivate the tests later.
This reverts commit e5dcd80957.
So apparently this is not the right fix (for the original flatpak issue)
and we already have the icon specified in the desktop file.
Let's just cancel this commit until we understand better the problem.
In other words, number the release candidates: 2.10.0~rc*.
In any case, this makes `rpmdev-vercmp` to consider them before 2.10.0,
unlike using a hyphen separator.
Though I still leave the <releases> trick from commit fb6328b9ad so that
our unit test succeeds, since `appstream-util` still considers the other
order.
Adding today's (hopeful) date.
Also removing the trick from commit 447d9bbc56 because the bug in
appstream-util has been fixed, but adding the same trick elsewhere for
another bug in this validation script:
https://github.com/hughsie/appstream-glib/issues/234
I was hoping others would review this <release> text before submitting
it to translators, but no such luck there. Anyway let's uncomment now
because translators need to get the text sooner than later if we want as
many localized version of the appdata text as possible at release.
Everyone if you want to review the English and the contents of this tag,
do it now!
GIMP 2.10 is 2.10.0 and "2.10 RC1" is "2.10.0-RC1".
I also update directly the Polish msgid and msgstr (only language having
a translation on time, though it's our fault!) to avoid the translation
getting fuzzy uselessly.
I let the "rc" as lowercase in version property of <release> tag,
assuming the more official/parsable name should be lowercase. Not sure
if it makes sense.
The first validation command was actually failing but the test was not,
because only the last return value is taken into account, obviously. Add
a '&&' between the commands.
Also test against the built files, not the templates (in particular
because `appstream-util` doesn't like .in.in templates, and anyway it's
always better to test against the finale file).
Finally move to "validate-relax" test for the time being.
"validate-strict" actually makes a bunch of errors, but I can't make the
time to look at these now. Let's just settle with basic validation at
least.
- appstream-util returns a "style-invalid" error: "<ul> cannot start a
description [(null)]". So I add a <p> introduction to the 2.9.8
<release> tag. This was part of unit test failure on the appdata file.
- I also add a type property for 2.9.8. This is a new property which I
proposed and which just got accepted in the appstream specification:
https://github.com/ximion/appstream/pull/158
- I add <release> tags for all previous 2.9.x releases. No description
for these, just a type property. But feel free to propose patches
adding short non-technical description for these.
Note: it was originally proposed in the bug report to use the appdata
file in place of NEWS (and have this one generated from appdata). But
after discussion with appstream project, appdata is expected to be
concise, non-technical and more "marketing" than exhaustive. This is
quite a different usage than NEWS which is more an exhaustive summary of
new features and major changes. So these 2 files will likely remain
distinct.
Please everyone, review the contents of this <release> tag so that we
can quickly uncomment it and submit it for translation. This is what
will be featured in software installers. Let's make it a concise yet
interesting overview of the 2.10 release.
I completely forgot to rename the appstream file according to the new
ID. While doing so, I also make it a .in.in file, with initial
processing by the autotools. Indeed I need @GIMP_COMMAND@ to be replaced
by AC_CONFIG_FILES().
Finally I fix a badly closed XML tag (which reminds me I should always
test a commit, even when it's a simple non-C 1-liner change!).
From AppStream docs:
«
In previous AppStream releases, the <id/> was used to associate metainfo
files with their .desktop files to merge in data from .desktop files
into the AppStream generator's final output. In modern metainfo files,
the component-ID for desktop-application components can be an arbitrary
string (matching the naming rules applying to all AppStream metadata),
while the <launchable/> tag is used to associate .desktop files with
their metainfo files.
»
... used for Flatpak.
Additional comments by Jehan after review:
«
This is not only to sync with flatpak. This format is the recommended
format in AppStream spec, even though many historical application still
use the old format.
If ever we decide to propose a dbus service, this may even become
required.
However just changing this is not enough for a proper ID change. I will
make additional change in further commits.
»
Let's start from here. I don't think it needs to be too long, just a
summary of the most awesome changes, I'd say.
Let's leave it commented out for now, until the description is finished
and ready for localization. This is the description which may appear in
software installers using appstream metadata.
Did a bit of archeology to get all the dates back.
I didn't add any description. Not sure if we should bother that much for
older versions (but most probably for upcoming version, would be
useful).
I also wanted to add URLs to the various news for each release, but
appstream-util would fail, telling that hyperlinks are not allowed
inside <p>. Unfortunately <release> tag cannot have a <url> child (nor a
property) according to appstream docs. So for now, I'll just stick to
date listing.
To have the name and summary translatable, rename as .in file, add
underscore on localizable tags and add to POTFILES.in.
Also clean out trailing whitespace and weird characters, add indentation
and fix tag s/updatecontact/update_contact/.
Finally add an appstream-util validation so that the file syntax is
checked during a `make check`.
This way we can be warned quickly about any AppStream issue (cf. bug
782759). This test requires web access for screenshot verification.
Packagers are invited to use --without-appdata-test option if they want
to skip the test (for instance if build environment has restricted
network access).
Command line: appstream-util validate-strict gimp.appdata.xml.in
This fixes only the following warning:
value-missing : <!-- Copyright [year] [name] --> is not present
Screenshot has not the right ratio. We will have to find one or more
replacement screenshots.
The only reason "gimp" can be used to search for the software (for
instance in GNOME overview) is because it is the Exec (the short name
is written neither in the Name nor Comment sections). When packaged by
systems like flatpak, this key is changed to `flatpak run ...` and
searching "gimp" does not even return the software!
Adding a Keywords entry to our desktop file fixes this.
Apart from "gimp", I take the opportunity to add other relevant keywords
from our website which currently would not display GIMP as a result:
graphic design illustration painting.
Rather than just discovering them by chance, a simple grep and some
search and replace are much more efficient! :-)
Cleaning only done on C and automake files.
