graphics/gimp
graphics/gimp
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp synced 2024-10-19 06:14:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge request 4 - Generated .c sources are used as headers...

Browse source 
...Generate .h files instead.

Generate proper .c and .h files for color-picker and tool cursors in
the directories where they are built, and stop including them in other
.c files.
This commit is contained in:
Michael Natterer 2018-05-28 17:25:18 +02:00
parent 7fab74f431
commit a9592a59c8
9 changed files with 35 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/widgets/.gitignore vendored
View file

@ -6,3 +6,5 @@
/libappwidgets.a /libappwidgets.a
/libappwidgets.la /libappwidgets.la
/xgen-wec /xgen-wec
/gimp-tool-cursors.c
/gimp-tool-cursors.h

19
app/widgets/Makefile.am
View file

@ -456,10 +456,14 @@ libappwidgets_a_sources = \
gimpwindowstrategy.c \ gimpwindowstrategy.c \
gimpwindowstrategy.h gimpwindowstrategy.h
libappwidgets_a_built_sources = widgets-enums.c libappwidgets_a_built_sources = \
gimp-tool-cursors.c \
gimp-tool-cursors.h \
widgets-enums.c
libappwidgets_a_SOURCES = \ libappwidgets_a_SOURCES = \
$(libappwidgets_a_built_sources) $(libappwidgets_a_sources) $(libappwidgets_a_built_sources) \
$(libappwidgets_a_sources)
# #
@ -492,3 +496,14 @@ $(srcdir)/widgets-enums.c: xgen-wec
touch $@ 2> /dev/null \ touch $@ 2> /dev/null \
|| true; \ || true; \
fi fi
gimp-tool-cursors.h: $(top_builddir)/cursors/gimp-tool-cursors.gresource.xml
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) \
--sourcedir=$(top_srcdir)/cursors --generate-header \
--target=$@ $(top_builddir)/cursors/gimp-tool-cursors.gresource.xml
gimp-tool-cursors.c: gimp-tool-cursors.h
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) \
--sourcedir=$(top_srcdir)/cursors --generate-source \
--target=$@ $(top_builddir)/cursors/gimp-tool-cursors.gresource.xml

2
app/widgets/gimpcursor.c
View file

@ -23,8 +23,6 @@
#include "gimpcursor.h" #include "gimpcursor.h"
#include "cursors/gimp-tool-cursors.c"
#define cursor_default_x_hot 10 #define cursor_default_x_hot 10
#define cursor_default_y_hot 10 #define cursor_default_y_hot 10

4
cursors/.gitignore vendored
View file

@ -1,8 +1,4 @@
/Makefile /Makefile
/Makefile.in /Makefile.in
/.xvpics
/.thumbnails
/gimp-color-picker-cursors.c
/gimp-color-picker-cursors.gresource.xml /gimp-color-picker-cursors.gresource.xml
/gimp-tool-cursors.c
/gimp-tool-cursors.gresource.xml /gimp-tool-cursors.gresource.xml

15
cursors/Makefile.am
View file

@ -87,10 +87,6 @@ EXTRA_DIST = \
$(CURSOR_IMAGES) \ $(CURSOR_IMAGES) \
gimp-tool-cursors.xcf gimp-tool-cursors.xcf
noinst_DATA = \
gimp-tool-cursors.c \
gimp-color-picker-cursors.c
CLEANFILES = \ CLEANFILES = \
$(noinst_DATA) \ $(noinst_DATA) \
gimp-tool-cursors.gresource.xml \ gimp-tool-cursors.gresource.xml \
@ -108,12 +104,6 @@ gimp-tool-cursors.gresource.xml: $(CURSOR_IMAGES) Makefile.am
echo ' </gresource>' >> $@; \ echo ' </gresource>' >> $@; \
echo '</gresources>' >> $@ ) echo '</gresources>' >> $@ )
gimp-tool-cursors.c: gimp-tool-cursors.gresource.xml
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) \
--sourcedir=$(srcdir) --generate-source \
--target=$@ gimp-tool-cursors.gresource.xml
gimp-color-picker-cursors.gresource.xml: $(CURSOR_IMAGES) Makefile.am gimp-color-picker-cursors.gresource.xml: $(CURSOR_IMAGES) Makefile.am
$(AM_V_GEN) ( rm -f $@; \ $(AM_V_GEN) ( rm -f $@; \
echo '<?xml version="1.0" encoding="UTF-8"?>' > $@; \ echo '<?xml version="1.0" encoding="UTF-8"?>' > $@; \
@ -129,8 +119,3 @@ gimp-color-picker-cursors.gresource.xml: $(CURSOR_IMAGES) Makefile.am
done; \ done; \
echo ' </gresource>' >> $@; \ echo ' </gresource>' >> $@; \
echo '</gresources>' >> $@ ) echo '</gresources>' >> $@ )
gimp-color-picker-cursors.c: gimp-color-picker-cursors.gresource.xml
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) \
--sourcedir=$(srcdir) --generate-source \
--target=$@ gimp-color-picker-cursors.gresource.xml

2
libgimpwidgets/.gitignore vendored
View file

@ -13,3 +13,5 @@
/*.trs /*.trs
/*.log /*.log
/xgen-wec /xgen-wec
/gimp-color-picker-cursors.c
/gimp-color-picker-cursors.h

16
libgimpwidgets/Makefile.am
View file

@ -194,8 +194,10 @@ libgimpwidgets_sources = \
gimpzoommodel.h gimpzoommodel.h
libgimpwidgets_built_sources = \ libgimpwidgets_built_sources = \
gimpwidgetsenums.c \ gimp-color-picker-cursors.c \
gimpwidgetsmarshal.c \ gimp-color-picker-cursors.h \
gimpwidgetsenums.c \
gimpwidgetsmarshal.c \
gimpwidgetsmarshal.h gimpwidgetsmarshal.h
libgimpwidgets_extra_sources = gimpwidgetsmarshal.list libgimpwidgets_extra_sources = gimpwidgetsmarshal.list
@ -345,6 +347,16 @@ gimpwidgetsmarshal.c: gimpwidgetsmarshal.h
&& cp xgen-wmc $(@F) \ && cp xgen-wmc $(@F) \
&& rm -f xgen-wmc xgen-wmc~ && rm -f xgen-wmc xgen-wmc~
gimp-color-picker-cursors.h: $(top_builddir)/cursors/gimp-color-picker-cursors.gresource.xml
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) \
--sourcedir=$(top_srcdir)/cursors --generate-header \
--target=$@ $(top_builddir)/cursors/gimp-color-picker-cursors.gresource.xml
gimp-color-picker-cursors.c: gimp-color-picker-cursors.h
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) \
--sourcedir=$(top_srcdir)/cursors --generate-source \
--target=$@ $(top_builddir)/cursors/gimp-color-picker-cursors.gresource.xml
# #
# test programs, not installed # test programs, not installed

2
libgimpwidgets/gimppickbutton-default.c
View file

@ -39,8 +39,6 @@
#include "gimppickbutton-private.h" #include "gimppickbutton-private.h"
#include "gimpwidgetsutils.h" #include "gimpwidgetsutils.h"
#include "cursors/gimp-color-picker-cursors.c"
#include "libgimp/libgimp-intl.h" #include "libgimp/libgimp-intl.h"

2
libgimpwidgets/gimppickbutton-quartz.c
View file

@ -27,8 +27,6 @@
#include "gimppickbutton-private.h" #include "gimppickbutton-private.h"
#include "gimppickbutton-quartz.h" #include "gimppickbutton-quartz.h"
#include "cursors/gimp-color-picker-cursors.c"
#ifdef GDK_WINDOWING_QUARTZ #ifdef GDK_WINDOWING_QUARTZ
#import <AppKit/AppKit.h> #import <AppKit/AppKit.h>
#include <Carbon/Carbon.h> /* For virtual key codes ... */ #include <Carbon/Carbon.h> /* For virtual key codes ... */