graphics/gimp
graphics/gimp
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gimp synced 2024-10-21 12:02:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

use gtk_target_list_add() instead of gtk_target_list_add_table() because

Browse source 
2004-06-29  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdnd.c: use gtk_target_list_add() instead of
	gtk_target_list_add_table() because the latter prepends the
	targets to the internal list which screws the order (== priority)
	of DND targets.

	* app/widgets/gimpselectiondata.c: added some more checks for
	failed drops (selection_data->length < 0).
This commit is contained in:
Michael Natterer 2004-06-29 13:20:30 +00:00 committed by Michael Natterer
parent 0acea7350e
commit 3f5e10c1d6
3 changed files with 24 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ChangeLog
View file

@ -1,3 +1,13 @@
2004-06-29 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpdnd.c: use gtk_target_list_add() instead of
gtk_target_list_add_table() because the latter prepends the
targets to the internal list which screws the order (== priority)
of DND targets.
* app/widgets/gimpselectiondata.c: added some more checks for
failed drops (selection_data->length < 0).
2004-06-29 Philip Lafleur <plafleur@cvs.gnome.org>
* plug-ins/common/unsharp.c: The preview's row buffer was

20
app/widgets/gimpdnd.c
View file

@ -764,7 +764,11 @@ gimp_dnd_data_source_add (GimpDndType data_type,
if (target_list)
{
gtk_target_list_add_table (target_list, &dnd_data->target_entry, 1);
GdkAtom atom = gdk_atom_intern (dnd_data->target_entry.target, TRUE);
gtk_target_list_add (target_list, atom,
dnd_data->target_entry.flags,
dnd_data->target_entry.info);
}
else
{
@ -805,9 +809,7 @@ gimp_dnd_data_source_remove (GimpDndType data_type,
if (target_list)
{
GdkAtom atom;
atom = gdk_atom_intern (dnd_data->target_entry.target, TRUE);
GdkAtom atom = gdk_atom_intern (dnd_data->target_entry.target, TRUE);
if (atom != GDK_NONE)
gtk_target_list_remove (target_list, atom);
@ -856,7 +858,11 @@ gimp_dnd_data_dest_add (GimpDndType data_type,
if (target_list)
{
gtk_target_list_add_table (target_list, &dnd_data->target_entry, 1);
GdkAtom atom = gdk_atom_intern (dnd_data->target_entry.target, TRUE);
gtk_target_list_add (target_list, atom,
dnd_data->target_entry.flags,
dnd_data->target_entry.info);
}
else
{
@ -883,9 +889,7 @@ gimp_dnd_data_dest_remove (GimpDndType data_type,
if (target_list)
{
GdkAtom atom;
atom = gdk_atom_intern (dnd_data->target_entry.target, TRUE);
GdkAtom atom = gdk_atom_intern (dnd_data->target_entry.target, TRUE);
if (atom != GDK_NONE)
gtk_target_list_remove (target_list, atom);

4
app/widgets/gimpselectiondata.c
View file

@ -184,7 +184,7 @@ gimp_selection_data_get_uris (GtkSelectionData *selection)
g_return_val_if_fail (selection != NULL, NULL);
if (selection->format != 8)
if ((selection->format != 8) || (selection->length < 1))
{
g_warning ("Received invalid file data!");
return NULL;
@ -397,7 +397,7 @@ gimp_selection_data_get_svg (GtkSelectionData *selection,
g_return_val_if_fail (selection != NULL, NULL);
g_return_val_if_fail (length != NULL, NULL);
if (selection->format != 8)
if ((selection->format != 8) || (selection->length < 1))
{
g_warning ("Received invalid SVG data!");
return NULL;