fixed bug 3283, bits of icons protrude outside the
stretch box, by making drawing the box at the actual bounds
instead of insetting three pixels like we were doing.
immediate update of scroll area). Some related bugs
remain, which I'll write up separately
* libnautilus-extensions/nautilus-gnome-extensions.h:
* libnautilus-extensions/nautilus-gnome-extensions.c:
(nautilus_gnome_canvas_set_scroll_region_include_visible_area):
New function, sets scroll region to given parameters,
also forcing visible area to be included.
* libnautilus-extensions/nautilus-icon-container.c:
(update_scroll_region): New function, extracted from
nautilus_icon_container_update_scroll_region, now takes
boolean for whether to include the visible area.
(nautilus_icon_container_update_scroll_region): Now calls
update_scroll_region.
(nautilus_icon_container_update_scroll_region_include_visible_area):
New function, calls update_scroll_region.
(size_allocate): Do no work if allocation hasn't changed. This
didn't help with bug 2068 but is a worthwhile optimization.
* libnautilus-extensions/nautilus-icon-private.h:
Prototype for nautilus_icon_container_update_scroll_region_
include_visible_area
* libnautilus-extensions/nautilus-icon-dnd.c: (handle_local_move):
call ..._include_visible_area when updating scroll region after
drag & drop, instead of just ..._update_scroll_region, so no
origin-shifting occurs.
fixed bug 1280, music view needs alert when it can't iterate
directory
fixed bug 3217, better separation of text in property browser so
it can be translated (ie, "remove a emblem" isn't good); fixed by
making an enum for the current category and using it to case out
for separate messages where appropriate.
fixed the PR2 part of bug 2390, "command:" URI-activating security
hole, by disallowing commands from remote locations. Downgrading
the rest of the bug to usable, when we will implement Frank's other
recommendations.
also, tweaked the error message when we can't open the sound driver to
better reflect reality.
* libnautilus-extensions/nautilus-icon-dnd.c:
(confirm_switch_to_manual_layout): Made the
"switch to manual layout" dialog be a
nautilus_yes_no_dialog instead of the uglier
nautilus_simple_dialog.
* libnautilus-extensions/nautilus-icon-container.c:
(keyboard_icon_reveal_timeout_callback):
* libnautilus-extensions/nautilus-list.c:
(keyboard_row_reveal_timeout_callback): Turned a
pair of FIXMEs into comments explaining why there's
no need to fix.
* src/nautilus-applicable-views.c:
(get_nautilus_navigation_result_from_gnome_vfs_result):
* src/nautilus-applicable-views.h:
* src/nautilus-window-manage-views.c:
(nautilus_window_end_location_change_callback):
Added NAUTILUS_NAVIGATION_RESULT_ACCESS_DENIED and gave it
a unique error message.
changed the sound ability test to use esd_audio_open instead of
opening the sound driver directly. We still need to test this
on systems with no sound hardware.
2000-09-30 Pavel Cisler <pavel@eazel.com>
* libnautilus-extensions/nautilus-file-operations.c:
(handle_xfer_vfs_error):
Fix a case where "NULL" would be displayed for a file name in file
copy error alert.
* libnautilus-extensions/nautilus-file-operations.c:
(handle_xfer_vfs_error):
Rework the "destination not writable" alert to not offer
to try to continue. Add special alert for out of space on destination.
Clean up some.
* libnautilus-extensions/nautilus-file-operations.c: (handle_xfer_duplicate):
Part 2 of fix to 1314 - Move to Trash faild if name conflict in trash.
Handle move to Trash duplicates the same way as copy duplicates.
* libnautilus-extensions/nautilus-file-operations.c:
(nautilus_file_operations_copy_move):
Make in-place copy properly create a duplicate.
Clean up.
* src/nautilus-theme-selector.c: (theme_select_row_callback):
Replace a gnome_vfs_xfer call with a gnome_vfs_xfer_delete_list. The
sync version of gnome_vfs_xfer does not support deleting like the async
one does.
* icons/arlo/Makefile.am:
* icons/arlo/i-regular.xml:
* icons/arlo/i-regular.png:
* icons/arlo/i-regular-aa.png:
* icons/arlo/i-regular-72-aa.png:
Added some more of the document icons, and deleted an old
one that was named wrong.
fixed a series of bugs involving the stretch handles (3084, 3281,
others); I'm not quite finished yet with 3239
changed the name of the property browser window for Arlo
changed the "customize" command to "customization" for Arlo.
* libnautilus-extensions/nautilus-icon-factory.c:
(cache_icon_unref): Fix case where the fallback icon is getting
unref'd so that it properly removes the icon (need to NULL the
prev and next for later reinsertion).
Fixed bug 913 (Any changes to a file while renaming results
in ending the name edit)
* libnautilus-extensions/nautilus-icon-container.c:
(get_icon_being_renamed): New convenience function; gets the
icon being renamed (or NULL) and does some sanity checking.
(key_press_event): Added a FIXME about direct use of nautilus_file.
(nautilus_icon_container_update_icon): Don't end renaming mode
on every update; end renaming mode only if the editable text
of the icon being renamed changed.
(end_renaming_mode): Use get_icon_being_renamed.
* libnautilus-extensions/nautilus-icon-factory.c: (cache_icon_ref),
(cache_icon_unref): Add special cases to handle fallback icon.
(destroy_fallback_icon): Use unref to free the fallback icon.
(load_icon_for_scaling): Handle the fallback icon more like other
icons.
* libnautilus-extensions/nautilus-scalable-font.c:
(nautilus_text_layout_new): Simplify the logic a bit by using
g_strndup.
2000-09-29 Mathieu Lacage <mathieu@eazel.com>
Fix bug 3074: local html files not displayed by mozilla.
* components/mozilla/nautilus-mozilla-content-view.c:
(mozilla_vfs_read_callback), (mozilla_vfs_callback),
(nautilus_mozilla_content_view_load_uri): add a
report_load_underway call where necessary.
2000-09-29 J Shane Culpepper <pepper@eazel.com>
* components/help/converters/gnome-info2html2/html.c:
* components/music/mpg123_handler.h:
* components/services/trilobite/libtrilobite/trilobite-core-utils.c
: (trilobite_open_uri), (trilobite_debug):
* components/services/trilobite/libtrilobite/trilobite-core-utils.h
:
* components/tree/nautilus-tree-model.c:
* libnautilus-extensions/nautilus-ctree.c:
* libnautilus-extensions/nautilus-debug.c:
* libnautilus-extensions/nautilus-directory-background.h:
* libnautilus-extensions/nautilus-horizontal-splitter.c:
* libnautilus-extensions/nautilus-self-checks.c:
* libnautilus-extensions/nautilus-user-level-manager.c:
* src/nautilus-main.h:
Checking lots of little fixes to make the new RedHat 7.0 compiler
work. Mostly newlines and including string.h and/or stdlib.h.
Serveral functions like strcmp are not inlined anymore.
the mozilla component and rpm related code still doesn't build but
all dependencies work now too.
* libnautilus-extensions/nautilus-global-preferences.c:
(proxy_changed), (register_proxy_preferences),
(global_preferences_register): Fix the NULL-passing problem that
was kiling the Tinderbox.
whose address wasn't typed with a trailing slash)
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_make_uri_canonical): New function, calls
nautilus_make_uri_canonical and then strips off the trailing
slash if any.
(nautilus_directory_get_internal): Call this new slightly
stricter function instead of nautilus_make_uri_canonical, to
guarantee that we'll never get two NautilusDirectory objects
for uris that match other than the trailing slash.
(nautilus_self_check_directory): Add test cases for new function.
* libnautilus-extensions/nautilus-file-utilities.c:
(nautilus_make_uri_canonical): Removed #if 0 code whose
equivalent is now in the NautilusDirectory version,
replaced with comment.
fixed bug 2107, music view fails when encountering a broken image file,
by testing for a NULL result from gdk_pixbuf_new_from_file and
handling it accordingly.
that wasn't typed with a trailing slash)
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_make_uri_canonical): New function, calls
nautilus_make_uri_canonical and then strips off the trailing
slash if any.
(nautilus_directory_get_internal): Call this new slightly
stricter function instead of nautilus_make_uri_canonical, to
guarantee that we'll never get two NautilusDirectory objects
for uris that match other than the trailing slash.
(nautilus_self_check_directory): Add test cases for new function.
* libnautilus-extensions/nautilus-file-utilities.c:
(nautilus_make_uri_canonical): Removed #if 0 code whose
equivalent is now in the NautilusDirectory version,
replaced with comment.
finished fixing bug 3342, thumbnailing never gives up on bad images,
by generating a unique "cant thumbnail" icon when thumbnailing fails.
Right now it's using the generic image icon; I still need a better
one from Susan.
2000-09-29 Gene Z. Ragan <gzr@eazel.com>
Fixed bug 2602, Integrate gnome-vfs http proxy setting into Mozilla
component.
* components/mozilla/Makefile.am:
* components/mozilla/nautilus-mozilla-content-view.c:
(nautilus_mozilla_content_view_initialize):
Check for proxy settings and init mozilla to use them.
Fixed bug 2692, Need to let user specify a proxy for Mozilla
component.
* libnautilus-extensions/nautilus-global-preferences.c:
(use_proxy_changed), (proxy_changed),
(global_preferences_register):
When the Nautilus preferences mechanism supports system wide settings,
we should revisit this code and remove the gconf system prefs retrieval
code.
partially fixed bug 3342, thumbnailing never gives up on bad images.
If thumbnailing failed, it would obsessively try over and over since
it was calling nautilus_file_changed even if it failed. Fixed by
calling nautilus_file_changed only when it succeeds. It still will
try once each time you enter the containing directory, and it has
the wrong icon, both of which I'll fix soon.
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_get_internal): Changed file_name_escaped
to file_name in nautilus_str_is_empty call.
file_name_escaped had already been freed at this point
(Doh!). Darin and I believe this to be the cause of
3327. Also freed file_name later, which had been leaking.
* components/tree/nautilus-tree-model.c:
(nautilus_tree_model_get_node): Removed extra debugging
spam from here now that bug seems fixed. We can bring it
back later if necessary.
* configure.in:
Add a --disable-mozilla-component autoconf flag so the component
can be forced disabled even if mozilla development libraries are
detected.
fixed bug 3271, music view doesn't check if sound hardware is
present, by seeing if we can successfully open the sound device.
Still need to fix sound previewing similarily
corrected flawed property frame image accidentally checked in earlier;
also, added test for sound output capability in music view (but not
using it yet)
* icons/arlo/Makefile.am:
* icons/arlo/i-regular.xml:
* icons/arlo/i-regular-96-aa.png:
* icons/arlo/i-regular-192-aa.png:
Added a few regular file icons in the uber-large sizes.
Not sure if these are final yet.
* components/tree/nautilus-tree-model.c
(nautilus_tree_model_get_node, dump_one_file_node): Enhance
debugging output to include hex addresses of files when we hit the
mysterious intermittent failure.
in icon view when using FTP). Now there is no degenerate menu
displayed, but the real menu still doesn't appear due to the
remaining selection bug.
Also did some more work to make some sidebar view failures
less deadly to Nautilus.
* src/file-manager/fm-directory-view.c:
(create_selection_context_menu): Complain and return NULL if
no files are selected.
(fm_directory_view_pop_up_selection_context_menu):
Don't put up a menu at all if create_selection_context_menu
returned NULL.
* src/nautilus-window-private.h:
Added field details->dead_view_name.
* src/nautilus-view-frame.c: (nautilus_view_frame_get_label):
return-if-fail if view frame has already been destroyed but
not finalized (so details is NULL). It used to segfault. I
also changed the one caller I knew about that sometimes called
this function in this situation.
* src/nautilus-window-manage-views.c:
(nautilus_window_set_state_info): in VIEW_ERROR case, store the
name of the (first) failing view frame here, where it can still
be reliably read.
(nautilus_window_update_state): Removed redundant and misleading
window->error_views != NULL check; changed if/else logic to
not check whether new_content_view is also content_view, since
when this check failed the code would assume that new_content_view
was a sidebar panel (I don't know of anyone ever running into
this case though); free and NULL out dead_view_name after
processing first error_view.
(report_sidebar_panel_failure_to_user): Use previously-stored
dead_view_name rather than trusting the view frame to still
have useful information in this case, since it doesn't in
the many cases where it self-destructed when running into
a problem.
(nautilus_window_end_location_change_callback): Tweaked an
error message.
* src/nautilus-window.c: (nautilus_window_destroy):
free details->dead_view_name.
fixed bug 3332, erase emblem was mistakenly included in
properties window.
tweaked images from Susan for the property browser
Susan fixed Eli's time signature bug in the music icon
2000-09-28 Mathieu Lacage <mathieu@eazel.com>
Fix bug 2688. back and forward buttons do not work
with mozilla.
* components/mozilla/nautilus-mozilla-content-view.c:
(nautilus_mozilla_content_view_load_uri),
(mozilla_location_changed_callback),
(mozilla_open_uri_callback): add a flag to remember
when nautilus calls the component and another to remember
when the user clicks on a button.
