Commit graph

21193 commits

Author SHA1 Message Date
Alexandru Fazakas 2727c82900 test: Add copy operations unit test
This patch adds both a sync alternative to the copy operations and a
test for it.
2018-07-20 16:58:33 +03:00
Alexandru Fazakas 1be08bd3a0 test: dir-has-files: Clean up files
We should clean up files/directories after using them for testing.

This patch deletes all create files after using them for the dir-has-files
test.
2018-07-20 12:57:25 +03:00
Carlos Soriano 544c1cca56 pathbar: Extend button menu with extensions and templates
One of the benefits of the new menu on the path bar buttons is that we
show the background menu.

This was the intended design since the start, but we didn't come to
finalize it earlier on.

Now with the 3.30 approaching, this work implements that.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/405
2018-07-19 22:11:52 +02:00
Carlos Soriano 28f2922a91 window-slot: Free bindings on dispose
We were leaking them.
2018-07-19 14:18:44 +00:00
Carlos Soriano 0fcb4dfea6 toolbar: Free the binds on finalize 2018-07-19 14:18:43 +00:00
Carlos Soriano b6eebcc63b window-slot: Adjust another identation 2018-07-19 14:18:43 +00:00
Carlos Soriano af978d25b2 window-slot: Adjust indentation of property 2018-07-19 14:18:43 +00:00
Ernestas Kulik 609bf585fe tests: Remove git conflict indicator from build file
Oops.
2018-07-19 13:23:21 +03:00
Ernestas Kulik 2f8e300d3d tests: Use GMainLoop in search engine test
This removes the need for a display.
2018-07-19 13:20:38 +03:00
Carlos Soriano 7fcc6a9db5 issue templates: Update flatpakref link 2018-07-19 05:49:13 +00:00
Alexandru Fazakas ab31018cda test: Add file-operations-move test
This patch includes the addition of the sync alternative to the
file-operations-move function and a test for it.
2018-07-16 18:51:44 +00:00
Ernestas Kulik 67b6843130 meson.build: Fix application ID
application_id is referenced in data/meson.build, so it’ll be less
annoying to append the profile to it as well.
2018-07-14 15:11:05 +03:00
Ernestas Kulik a9b76916e4 meson.build: Tidy sections up
Now sections (and their boundaries) are more visible, and maybe the file
is more readable all around.
2018-07-14 13:35:24 +03:00
Ernestas Kulik 6d433d35cc application: Check profile, not app ID
It’s a bit more reliable, since now non-empty profile strings mean
non-default profiles.
2018-07-14 13:35:01 +03:00
Carlos Soriano 8d3ab27e1c Flatpak: Give up on Builder formatting the JSON
Builder keeps trying to format the JSON automatically for any change,
which is quite cumbersome since it appears as a changed file on git and
also it's a mess if an actual change happens.

Just accept the defeat and go with whatever Builder wants.
2018-07-14 11:59:56 +02:00
Carlos Soriano 3a7b29ee68 Flatpak: Fix Nautilus URL
Forgot to change it back to upstream.
2018-07-14 11:59:01 +02:00
Carlos Soriano a6f663790a CI: Update to build weekly Gtk4 branch 2018-07-14 11:35:25 +02:00
Carlos Soriano ea8d1d065f Flatpak: Add Gtk4 version
So it can be tested while it's on development
2018-07-14 11:33:57 +02:00
Carlos Soriano d31b8b59de general: Assume development profile if app id is not Nautilus
Instead of checking explicitly for some options, we allow any value as
profile and assume is a development snapshot.

This will help with having Flatpak bundles/refs of different branches
with different purposes.
2018-07-14 11:33:57 +02:00
Carlos Soriano fd309ecfbc Flatpak: Rename nautilus-master to NautilusMaster
So we are consistent on using camel case
2018-07-14 11:33:57 +02:00
Carlos Soriano 4a88f39d09 general: Provide search information on the view itself
With the new search bar design, the search information displayed under
they query editor was not working properly.

Instead, the new design says that the information should be displayed
in the view itself, as a top banner.

This work implements the new design and fixes several issues of sizing
due to the wrong position of the search information label.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/403
2018-07-14 08:06:31 +00:00
Carlos Soriano 2f2647010f window-slot: Disconnect from nautilus_preferences
Seems we forgot to do this on the past, it can cause crashes.
2018-07-14 08:06:30 +00:00
Carlos Soriano 3c1a71e30b window-slot: Remove obsolete searchbar style
With the new design this was not used, remove it.
2018-07-14 08:06:30 +00:00
Xiang Fan a7a31137ae nautilus-canvas-container: Remove the "include visible area" logic.
canvas_set_scroll_region_include_visible_area() was added in
ec054c8098 to fix
https://bugzilla.gnome.org/show_bug.cgi?id=42068 ("Dragging icons
adjusts scroll area in a way that causes immediate scrolling"). This is
no longer the case, because now icons remain in place when being dragged
and are not allowed to be rearranged.

ec054c8098 causes issues relating to extra
scrolling space (#340), hence the removal.

Fixes #340.
2018-07-13 19:18:56 +00:00
Carlos Soriano 21be890204 bookmark-list: Remove unneeded code
g_file_new always returns something.
2018-07-13 15:40:00 +02:00
Yi-Soo An 377070def8 bookmark-list: Use g_auto* macros
According to the documentation, the variables with these macros
are cleaned up in a way appropriate to its type when the variables
go out of scope.
2018-07-13 21:54:23 +09:00
Carlos Soriano beb25f5dde style: Make tags fit into the box
With the new design the tags weren't fitting into the box anymore,
probably due to a style somewhere. Not sure where the issue is, but all
margins from within the tagged entry were 0 pixels.

This commit restores the margins to make the tags fit. This will
eventually go away with the new tagged entry that goes with gtk4, so it
doesn't worth to dig much deeper.
2018-07-13 13:10:49 +02:00
Matej Urbančič cd75bf1e2c Updated Slovenian translation 2018-07-11 21:16:40 +02:00
Sam Hewitt aa89c92c45 general: round pixel_size values of icons to base 16 in .ui files to avoid aliasing 2018-07-11 07:42:37 +00:00
Ernestas Kulik e94894fef6 CI: Use apt-get on Ubuntu
Invoking `apt` triggers a warning about its interface being not stable enough for use in headless setups. That, and I messed up the last commit, so here we are.
2018-07-10 15:49:47 +00:00
Ernestas Kulik 0b8353155a CI: Install libseccomp on Ubuntu and openSUSE 2018-07-10 15:34:21 +00:00
Bruno Lopes da Silva 48d9ac079b Update Brazilian Portuguese translation 2018-07-10 11:38:18 +00:00
Ernestas Kulik c683360a01 CI: Install gsettings-desktop-schemas-devel on OpenSUSE 2018-07-09 07:27:36 +00:00
Ernestas Kulik 7142d4130b CI: Install gsettings-desktop-schemas-dev on Ubuntu 2018-07-09 07:25:25 +00:00
Yi-Soo An c7d29f7d96 bookmark: Use g_auto* macros
According to the documentation, the variables with these macros
are cleaned up in a way appropriate to its type when the variables
go out of scope.
2018-07-04 15:41:25 +09:00
Charles Monzat 480b8927ee Update French translation 2018-07-03 15:02:11 +00:00
Yi-Soo An a945d22b5c dbus-manager: migrate to G_DECLARE_* format
G_DECLARE_* macro is used for emitting the usual declarations.
It is better than previous way for developers.
2018-06-28 14:15:49 +09:00
Fabio Tomat 4c237cff20 Update Friulian translation 2018-06-23 07:39:15 +00:00
Kukuh Syafaat 744a61ede9 Update Indonesian translation 2018-06-23 06:46:22 +00:00
Efstathios Iosifidis 2bf42740fd Update Greek translation 2018-06-22 15:44:33 +00:00
António Fernandes 5d5ed14a74 file: Streamline referencing when applying emblems
Every time we call apply_emblem_to_icon(), we need to declare a second
GIcon beforehand to store the return value, and we need to unref the
original GIcon afterwards.

If the file has got no emblems, the second GIcon is just another
reference to the first one.

Let's simplify this by lending ownership of the GIcon.
2018-06-19 17:49:53 +01:00
António Fernandes e4911691e8 file: Also add emblems on custom icons
Emblems whose names are in metadata::emblems are added to icons, but
this is not happening if the file also has metadata::custom-icon-name.

This may have been a regression from the last refactoring of the icon
loading code (commits a6b88ebde1 to c123b6056b).

Make sure to apply emblems on custom icons as well.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=748736
2018-06-19 17:03:20 +01:00
Daniel Șerbănescu e7391c7e7d Update Romanian translation 2018-06-17 20:00:57 +00:00
Benjamin Steinwender cc081ad223 Update German translation 2018-06-17 12:50:28 +00:00
Carlos Soriano 000c330090 mime-actions: Add activated files to recent
Until now we left applications to add the files to recent if they did
modify them. This usually works, specially for gtk applications, but it
doesn't work for applications using other toolkits.

Recently, as we move towards a more containerized Nautilus with Flatpak
the recent files set by other apps are not accessible, so we need to
add them ourselves when opening in Nautilus.

This work adds every file activated by other app from Nautilus be added
as recent.
2018-06-14 13:21:30 +00:00
Carlos Soriano fd43da06be recent: Remove recent
The custom handling is used only in one place, and it's simply creating
some wrapper around GtkRecentManager.

In a future commit we would need to provide some API for the simple case
of a adding an URI, which is what GtkRecentManager does by default,
so it's even more useless.

This commits removes the recent file.
2018-06-14 13:21:30 +00:00
Wong Heung Sang 3138a4089d pathbar: Properties of Popup show Current Location
Open properties from pathbar popup show properties of view.

We want it to show the properties of current location of pathbar.

Added an action to files-view to handle the properties of pathbar,
because we just want the properties of current directory of files-view

Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/475
2018-06-14 12:28:18 +00:00
António Fernandes 443a7ed5bf flatpak: Update dependency modules source URLs
The YAML files already use the gitlab URLs, while the json doesn't.

The gnome-apps-nightly build script reads the json file, and the
builds have been failing because of this.

Update the json file accordingly.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/485
2018-06-12 22:34:57 +01:00
Carlos Soriano 09f00407eb Meson: Make sure _GNU_SOURCE is set
_GNU_SOURCE is required to be able to use POSIX functions that are not
available on non-Linux system. Specifically, we use sys/types for
requesting user accounts with getpwent and similars.

Usually systems seems to compile with this set, however some systems
like RHEL doesn't assume it so.

Since this is more correct to set it explicitly, this commit does that
by passing an argument to meson project.
2018-06-12 09:14:45 +00:00
Carlos Soriano 41ab60dfa0 file: Make sure we include necessary headers
setpwent is used but we didn't include the necessary headers.

It was building in Fedora because some other header included it,
but that's not the case in RHEL.
2018-06-12 09:14:44 +00:00