We've been reloading if asked to show an existing location but select
a different file, since commit d0b0be2184
The reload is unnecessary, let's just set the new selection.
The wiki is slowly getting deprecated. Replace all wiki links with their
respective replacements.
Only the translation project information still only resides on the wiki.
I've just reverted a workaround to a GtkExpression bug which has been fixed by 14e78663ee
So, depend on the latest development release, which includes this bugfix.
As part of commit f65c2921b0 ("window: Open location entry when
current path is clicked") we allow entering location entry
by clicking the current folder button. This, however, is not at
all obvious, and not only defeats the original intent of the change
but also leads to issues such as the inability to maximize the
nautilus window (by double clicking the current folder).
Hopefully if we make the action more obvious, errors will be
less likely.
Furthermore, with the pending elimination of Other Places
(and replacement by Network View), there's one less way to
access the root file system. This makes the discoverability
of the location entry even more important for people who
want to access '/'.
Also:
- Use AdwHeaderBar
- Use "top" child type to allocate the AdwBanner
- Remove the margins from the listbox since
AdwPreferencesPage already has margins
nautilus_window_slot_set_content_view() used to be a public method[0],
because it used to be called by the action code from window.c[1]
Nowadays it's just unnecessary indirection.
[0] commit 8bee9ef99b
[1] commit c2847953b2
Reloading the directory can be slow and resource-intensive.
Now that the actual grid and list views is not the same object as the
one which loads/monitors the directory (i.e. NautilusFilesView), we
can swap the inner view while keeping the loaded directory unchanged
and the model mostly unchanged.
(I say "mostly" because we need to collapse expanded rows before
switching to grid view, which would otherwise display subfolder
contents as if part of the parent folder.)
Resolves https://gitlab.gnome.org/GNOME/nautilus/-/issues/3042
We can't keep using nautilus_files_view_get_model() if we stop being a
subclass of NautilusFilesView. Additionally, if we want to change view
mode while keeping the model around, we must be able to set a model on
the view after creation. This is one of the final pieces for the plan
detailed in https://gitlab.gnome.org/GNOME/nautilus/-/issues/3042
This change implies we need to cope with the model-less state, i.e.,
guard against model being NULL. Additionally, for list view, it means
the sorter and the expand_as_a_tree flag must be set as soon as the
model gets set the model.
NautilusListBase and its subclasses need these ids, but will soon
stop including nautilus-view.h (through nautilus-files-view.h), when
they become child widgets instead of subclasses of NautilusFilesView
We want to become a child, not a subclass, of NautilusFilesView, as per
https://gitlab.gnome.org/GNOME/nautilus/-/issues/3042
As such, we need to own the scrolled window. But NautilusFilesView still
needs to track scroll changes, for the search extender button, so we also
expose a vadjustment getter.
Nowadays, we have breakpoint-based layouts which take care of ensuring
the sidebar has the desired size.
But the sidebar was itself requesting a size. It was smaller than what
the window layout enforces, so it was not noticed until now that it is
forcing the progress indicator in the sidebar to be clipped off-window.
Do the right and simple thing to fix it.
Now that the progress indicator is in the bottom bar of the
toolbarview, we can simply bind our reveal property to show and
hide the progress indicator.
Set the state of Undo and Redo actions on the construction of a new Window based on the current state.
Also fix the wrong action that was set for Redo.
Fixes: #3263
"Report An Issue" redirects to https://gitlab.gnome.org/GNOME/nautilus/-/issues/new directly.
However, the users that are not logged in, would be greeted by a login screen.
This fix would redirect all users to see all the existing issues, irrespective of whether they are logged in or not.
Fixes: #3220
