Commit graph

19 commits

Author SHA1 Message Date
Nishal Kulkarni
0dfaaaeecd extensions/image-properties: Replace deprecated functions
Build log contains deprecation warnings for gexiv2 functions.
Replaced `gexiv2_metadata_has_tag()` with
`gexiv2_metadata_try_has_tag()` and `gexiv2_metadata_get_orientation()`
with `gexiv2_metadata_try_get_orientation()`

Closes: #2033
2021-12-04 22:54:14 +00:00
Ondrej Holy
8c5fa3eb08 extensions/image-properties: Replace deprecated symbols
The build log contains warnings about deprecated gexiv2 functions. Let's
port to the new API, unpin exiv3 and gexiv2 dependencies in flatpak manifests
and bump the build dependency accordingly to get rid of the warnings.
2021-07-09 15:46:59 +02:00
James Westman
0645e3b9aa image properties: Handle rotated images
Images with EXIF metadata can contain an orientation tag, which indicates the
image should be rotated. In the Image tab of the Properties dialog, swap the
width and height if the image is rotated by 90 or 270 degrees.

Fixes #1590.
2020-11-18 15:17:43 +00:00
Ondrej Holy
fd2e7dfdea general: Run uncrustify script
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
2020-04-05 16:22:26 +00:00
Waqar Ahmed
6784266e3d audio-video-properties:fix string not translatable
"Frames per second" string in audio-video-properties tab was unavailable for translation.

To fix this, handle the string with g_dngettext() and allow for both singular and plural translation.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/990
2020-01-11 19:45:22 +00:00
Philip Withnall
c71adb9761 audio-video-properties: Use ‘frame rate’ and ’bit rate’ not run-ons
‘framerate’ and ‘bitrate’ aren’t dictionary words; add a space to make
them ‘frame rate’ and ‘bit rate’ instead.

This makes them match the ‘sample rate’ string also in that file.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
2019-04-11 12:38:06 +01:00
Albert Vaca Cintora
6114cb8585 Fix build in Clang
I was getting:
error: variable 'string' is used uninitialized whenever 'if' condition is
false [-Werror,-Wsometimes-uninitialized]
2019-03-18 19:37:17 +00:00
Bastien Nocera
3096d7e544 audio-video-properties: Make the framerate more precise
Add a bit more precision to the frames per second property.

Closes: #901
2019-02-13 10:50:08 +00:00
Bastien Nocera
fdc4300ae0 audio-video-properties: Add context to "Unknown" strings
See https://gitlab.gnome.org/GNOME/totem/issues/299
2019-02-13 10:50:08 +00:00
Bastien Nocera
c51899c355 audio-video-properties: Remove unused code 2019-02-13 10:17:54 +00:00
Bastien Nocera
3d9d2ef8d1 audio-video-properties: Use totem_gst_disable_display_decoders() 2019-02-13 10:17:54 +00:00
Bastien Nocera
f826da0fb2 audio-video-properties: Add decoder disabler helper
(Re-)add a helper to disable decoders that require windowing
environments to even be used while gathering metadata.
2019-02-13 10:17:54 +00:00
Bastien Nocera
e9bb1cff99 Add copy/paste of totem's properties window nautilus extension
The code is quite stable and this is basic functionality which is going to be
better in Nautilus rather than relying on extensions, given the quite bad
extension system Nautilus has.

This will also help with the port to gtk4, so we rely in yet another important
extension providing properties pages (which in turn export gtk3 widgets).
2019-02-11 16:03:55 +01:00
Alexandru Fazakas
95ecfc8ea0 general: Remove include guards in favor of pragma once
The traditional include guards are not as easy to handle
and require extra thought into the names.

Pragma once is an easier, more contributor friendly approach.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294

general: Remove include guards in favor of pragma once

The traditional include guards are not as easy to handle
and require extra thought into the names.

Pragma once is an easier, more contributor friendly approach.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
2018-03-19 14:43:38 +02:00
Ernestas Kulik
9e8f138999 general: fix old-style function declarations
Parameterless function declarations imply indeterminate parameter count,
while the implementations take no arguments.
2018-03-01 08:37:49 +00:00
Yaakov Selkowitz
aae465299e extensions: build as modules instead of libraries
Since the extensions are loaded dynamically instead of being linked in,
there is no need to build them as import libraries.
2018-02-17 17:29:50 +02:00
Ernestas Kulik
cdeedcd354 extensions: sendto: modernize code
This mainly removes the manual type definitions.
2018-02-09 06:32:38 +02:00
Ernestas Kulik
6934578ebf sendto-extension: move under extensions/
Now that the image property page is an extension, both extensions can be
held under the same subdirectory. This commit also makes the image
property extension optional.
2018-02-09 06:32:38 +02:00
Ernestas Kulik
14ee0f1cdc general: reimplement image properties as an extension
The image property page is already implemented using the extension API,
but it’s not an extension and relies on a library that is not essential
to Nautilus. This commit builds the image properties as an extension and
introduces some minor refactoring to the code.
2018-02-09 06:32:38 +02:00