Commit graph

76 commits

Author SHA1 Message Date
Ondrej Holy
fd2e7dfdea general: Run uncrustify script
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
2020-04-05 16:22:26 +00:00
Patrick Monnerat
4f334aec5d menu-provider: Fix signal id argument
ITEMS_UPDATED is not the signal id. It's the index for the array of
signal ids.

Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/984
2020-01-04 21:31:11 +00:00
Ernestas Kulik
64c8ca3d13 nautilus-extension: file-info: Tweak punctuation
A bit more readable with a semicolon.
2019-02-17 19:54:11 +00:00
Tomasz Miąsko
4d0330a721 Include pkg-config package name in introspection file.
This effectively adds `<package name="libnautilus-extension"/>` to gir
xml file, which makes it easy to obtain necessary compiler and linker
flags for use in compile time bindings.
2019-01-10 14:19:19 +00:00
Ernestas Kulik
c28776c4b4 nautilus-extension: file-info: Fix doc oops
The same function was accidentally documented twice.
2018-08-26 11:11:33 +03:00
Ernestas Kulik
4ae0361342 docs: Reorganize and fix
This commit completes the sections file with subsections, moves most
documentation to headers (no real reason to, especially given that
changes there may cause unwanted rebuilds, but it feels better to have
it in the headers) and fixes some annotations.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/565
2018-08-03 20:35:47 +03:00
Ernestas Kulik
200a5869b5 build: Allow disabling GIR data generation 2018-07-25 19:06:37 +03:00
Alexandru Fazakas
aa7cfcf01c eel: self-checks: Fix misaligned arguments
A couple of arguments were misaligned, so we placed
them properly.
2018-03-19 14:49:44 +02:00
Alexandru Fazakas
95ecfc8ea0 general: Remove include guards in favor of pragma once
The traditional include guards are not as easy to handle
and require extra thought into the names.

Pragma once is an easier, more contributor friendly approach.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294

general: Remove include guards in favor of pragma once

The traditional include guards are not as easy to handle
and require extra thought into the names.

Pragma once is an easier, more contributor friendly approach.

Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
2018-03-19 14:43:38 +02:00
Ernestas Kulik
df583c2e4a general: Allow running in separate instance
When hacking on Nautilus, it is very inconvenient to have to close any
running instance before running the built version. This commit enables
running three different instances by changing the application ID.
Beside the default “profile” is one crafted for stable flatpak
releases and one for development. The stable flatpak profile adds an
identifying mark to the about dialog to aid collecting information in
bug reports. The development profile is that plus additional styling to
help visually identify the development instance. It also will be used
when generating Flatpak bundles with the help of CI.

Generally, the implementation is slightly hacky to allow all the
different workflows, spanning from regular installations to GNOME
Builder flatpak builds, as each comes with its own quirks.
2018-03-18 22:28:08 +02:00
Carlos Soriano
b6ebffd567 general: Run uncrustify 2018-02-13 20:11:55 +01:00
Ernestas Kulik
0e5815e95a libnautilus-extension: add removed includes back in
Some extensions break because of weird inclusion patterns.

Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/252
2018-02-13 07:22:49 +02:00
Emmanuele Bassi
900d2be31c Ensure that extensions depends on generated headers
The libnautilus-extensions internal dependency must include the
generated enumeration header file, otherwise we may end up building
targets that depend on the library prior to have the header properly
generated.
2018-02-09 13:32:19 +00:00
Ernestas Kulik
7e2605c681 general: refactor extension library
The changes include:

  * adding a single-include header and deprecating
    nautilus-extension-types.h and direct inclusions of individual
    headers;

  * type definition simplifications - this causes some breakages in
    nautilus-file, because NautilusFile used to be typedefed to
    NautilusFileInfo, and that is no longer possible, so the interface
    implementation was moved to static functions and the public
    NautilusFile API provides thin wrappers for them to maintain
    compatibility;

  * documentation cleanups and reorganization;

  * general build rule and code cleanups: mostly g_auto* sprinkled
    around and style changes (sorry)
2018-02-09 06:32:38 +02:00
Ernestas Kulik
2128efccae nautilus-extension: use Meson to generate pkgconfig file
Currently, the pkgconfig file for nautilus-extension is generated by
substituting variables in a template file. That is prone to mistakes and
requires manual tracking of dependencies. Using the pkgconfig module
from Meson helps automate much of the process.
2018-02-09 06:32:38 +02:00
Ernestas Kulik
983892a656 build: general cleanups
This commit does the following:
  * Canonicalize the style:
    * Use two-space indentations.
    * Un-Autotools-ify option names.
    * Don’t align arguments, simply increase indentation.
    * Don’t add a space before opening parenthesis in calls.
  * Remove unused variables.
  * Remove unused dependencies.
  * Remove config.h.meson.
  * Optimize dependencies.
  * Use disabler functionality for libselinux dependency, to save lines.
2018-01-02 12:51:32 +02:00
Ernestas Kulik
767c7ad95a Add license to libnautilus-extension
https://bugzilla.gnome.org/show_bug.cgi?id=785062
2017-08-07 14:50:20 +03:00
Ernestas Kulik
857a90c29b autotools: kill it
We’re moving to Meson this cycle, so this is losing some deadweight.

https://bugzilla.gnome.org/show_bug.cgi?id=780366
2017-03-22 17:18:29 +02:00
Ernestas Kulik
fd50ac5011 meson: set correct libnautilus-extension version in .pc
Currently, when building with Meson, the version of the pkg-config file
for libnautilus-extension is set to the version of the library itself.
This is incompatible with how it was before - the version was set to the
version of Nautilus. That breaks some modules that build extensions
(e.g. file-roller).

https://bugzilla.gnome.org/show_bug.cgi?id=779472
2017-03-03 17:06:18 +01:00
Ernestas Kulik
ed5652c89a general: add support for Meson
Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script to generate a tarball
for releases, since we use libgd as a submodule and Meson does not
handle source distributions.

https://bugzilla.gnome.org/show_bug.cgi?id=778167
2017-02-24 00:24:27 +02:00
Ernestas Kulik
728300331d general: drop git.mk
This commit removes git.mk and adds hand-written gitignore files. That
is needed to ignore build/, which is the directory of choice for Meson
builds.

https://bugzilla.gnome.org/show_bug.cgi?id=778167
2017-02-24 00:24:27 +02:00
Carlos Soriano
838691f27a general: format code with newer Uncrustify
Some issues were fixed, and now we can rerun Uncrustify to format
correctly more part of the code.
2016-11-30 21:35:21 +01:00
Carlos Soriano
52d960542b general: run uncrustify
And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.

https://bugzilla.gnome.org/show_bug.cgi?id=770564
2016-08-29 18:37:10 +02:00
Cosimo Cecchi
ff5a48d133 libnautilus-extension: add gtk-doc documentation coverage
A lot of the library was poorly documented. Make sure the output of the
documentation looks okay.
2015-05-25 20:41:19 -07:00
Cosimo Cecchi
5884eb52b3 libnautilus-extension: remove cusetom i18n header
Just use glib-i18n-lib.h.
2015-05-25 14:49:57 -07:00
Cosimo Cecchi
cbc37d3ecd Don't mention FSF address
Use the website instead.

https://bugzilla.gnome.org/show_bug.cgi?id=721518
2014-02-17 14:41:43 -08:00
Andrés G. Aragoneses
9473dd41c1 build: stop using INCLUDES, deprecated by automake 1.7
We already depend on automake 1.9, so using the replacement of
INCLUDES (AM_CPPFLAGS) won't hurt, especially now that it is
a warning shown by default since automake 1.13, as evidenced by
this build log of mine:

Makefile.am: installing './INSTALL'
eel/Makefile.am:5: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
eel/Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
libnautilus-extension/Makefile.am:7: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
libnautilus-private/Makefile.am:5: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
nautilus-sendto-extension/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
src/Makefile.am:13: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
test/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

Signed-off-by: Alexander Larsson <alexl@redhat.com>
2013-06-18 11:30:31 +02:00
William Jon McCann
d721a8f206 Normalize signal names
https://bugzilla.gnome.org/show_bug.cgi?id=692234
2013-01-22 10:47:54 -05:00
Cosimo Cecchi
c6a1bf5fa5 build: use GNOME_MAINTAINER_MODE_DEFINES
Instead of defining our own set of deprecation cflags.
2012-10-23 20:04:03 -04:00
William Jon McCann
0ab374ea0b Use git.mk 2012-09-17 18:07:25 -04:00
William Jon McCann
988e33f3af Make time columns default to descending sort order 2012-07-20 19:07:09 -04:00
Cosimo Cecchi
e79c28b480 extension: add some more missing gir annotations 2012-01-16 10:28:40 -05:00
Cosimo Cecchi
6003b063ee extension: add some annotations 2012-01-09 17:22:47 -05:00
Cosimo Cecchi
d3cee086e7 libnautilus-extension: remove the ability to add toolbar items
We want to fully control our toolbar now.
2011-02-17 11:25:17 -05:00
Cosimo Cecchi
fdae502d65 libnautilus-extension: use a different directory for 3.0
So that old extensions do not pull in GTK+2 code.

https://bugzilla.gnome.org/show_bug.cgi?id=624244
2010-12-03 13:49:36 +01:00
Cosimo Cecchi
393df7a83c build: simplify configure script
Also, don't support old exif/exempi APIs anymore.
2010-10-30 16:29:14 +02:00
Bastien Nocera
0187296a18 Update pkg-config files for GTK+ 3.x 2010-06-23 18:31:25 +01:00
Matthias Clasen
48f2f2b3bb Depend on the right gtk gir file
We need Gtk-3.0.gir now.
2010-06-21 12:58:30 -04:00
Cosimo Cecchi
86d41c1415 Split WARNING_CFLAGS into its own variable.
So that we can use e.g. LIBNAUTILUS_EXTENSIONS_CFLAGS when compiling the
gir information.
2010-05-20 14:34:00 +02:00
Rodrigo Moya
f1148c5878 Add introspection support for libnautilus-extension 2010-05-19 17:01:14 +02:00
Rodrigo Moya
8d366402ca Added introspection to libnautilus-extension 2010-05-18 11:43:24 +02:00
Cosimo Cecchi
4b680e163e Don't use C++ keywords in NautilusMenu (#616657). 2010-04-27 12:45:45 +02:00
Alexander Larsson
056ac6c3de Dist nautilus-extension-private.h 2009-12-17 17:22:25 +01:00
Alexander Larsson
18763611ef Forgot to add nautilus-extension-private.h in last commit 2009-12-07 22:21:47 +01:00
Alexander Larsson
881f208b87 Add lookup and creator functions for NautilusFileInfo objects
This has been requested by many extension developers.
2009-12-04 12:39:20 +01:00
Sven Herzberg
72a49ea8cc Bug 574546 – Document nautilus_property_page_provider_get_pages()
2009-03-08  Sven Herzberg  <herzi@lanedo.com>

	Bug 574546 – Document nautilus_property_page_provider_get_pages()

	* libnautilus-extension/nautilus-property-page-provider.c: document
	the function
	* src/nautilus-image-properties-page.c,
	* src/nautilus-notes-viewer.c: drop the function documentation, it's
	in the API reference now

svn path=/trunk/; revision=15070
2009-03-09 10:16:53 +00:00
Cosimo Cecchi
0fa45e385b Use G_DEFINE_TYPE_* instead of hand-written nautilus_foo_get_type()
2009-02-02  Cosimo Cecchi  <cosimoc@pluto>

	* libnautilus-extension/nautilus-column.c:
	(nautilus_column_finalize), (nautilus_column_init),
	(nautilus_column_class_init):
	* libnautilus-extension/nautilus-menu.c: (nautilus_menu_finalize):
	* libnautilus-private/nautilus-cell-renderer-pixbuf-emblem.c:
	(nautilus_cell_renderer_pixbuf_emblem_class_init),
	(nautilus_cell_renderer_pixbuf_emblem_finalize):
	* libnautilus-private/nautilus-cell-renderer-text-ellipsized.c:
	(nautilus_cell_renderer_text_ellipsized_init),
	(nautilus_cell_renderer_text_ellipsized_class_init),
	(nautilus_cell_renderer_text_ellipsized_get_size):
	* libnautilus-private/nautilus-entry.c: (nautilus_entry_finalize),
	(nautilus_entry_key_press), (nautilus_entry_motion_notify),
	(nautilus_entry_button_press), (nautilus_entry_button_release),
	(nautilus_entry_selection_clear), (nautilus_entry_class_init):
	* libnautilus-private/nautilus-file.c: (nautilus_file_init),
	(nautilus_file_constructor), (finalize),
	(nautilus_file_class_init):
	* libnautilus-private/nautilus-icon-canvas-item.c:
	(nautilus_icon_canvas_item_finalize),
	(nautilus_icon_canvas_item_update),
	(nautilus_icon_canvas_item_class_init):
	* libnautilus-private/nautilus-icon-container.c:
	(nautilus_icon_container_new):
	* libnautilus-private/nautilus-icon-container.h:
	* libnautilus-private/nautilus-mime-application-chooser.c:
	(nautilus_mime_application_chooser_finalize),
	(nautilus_mime_application_chooser_destroy),
	(nautilus_mime_application_chooser_class_init),
	(nautilus_mime_application_chooser_init):
	* libnautilus-private/nautilus-open-with-dialog.c:
	(nautilus_open_with_dialog_finalize),
	(nautilus_open_with_dialog_destroy),
	(nautilus_open_with_dialog_class_init),
	(nautilus_open_with_dialog_init):
	* src/file-manager/fm-icon-container.c:
	* src/file-manager/fm-list-model.c: (fm_list_model_dispose),
	(fm_list_model_finalize), (fm_list_model_class_init):
	* src/file-manager/fm-tree-model.c: (fm_tree_model_finalize),
	(fm_tree_model_class_init):
	Use G_DEFINE_TYPE_* instead of hand-written nautilus_foo_get_type()
	functions where possible.

svn path=/trunk/; revision=14911
2009-02-02 16:47:17 +00:00
Cosimo Cecchi
7fce8f06d6 Use single GLib/GTK+ includes. Patch by Maxim Ermilov (#560432).
2008-12-06  Cosimo Cecchi  <cosimoc@gnome.org>

	* cut-n-paste-code/libegg/eggtreemultidnd.c:
	* cut-n-paste-code/libegg/eggtreemultidnd.h:
	* libnautilus-extension/nautilus-menu.c:
	* libnautilus-private/nautilus-directory-notify.h:
	* libnautilus-private/nautilus-file-operations.c:
	* libnautilus-private/nautilus-file.c:
	* libnautilus-private/nautilus-icon-info.h:
	* libnautilus-private/nautilus-idle-queue.h:
	* libnautilus-private/nautilus-monitor.h:
	* libnautilus-private/nautilus-search-engine-simple.c:
	* src/file-manager/fm-list-model.c:
	* src/file-manager/fm-list-model.h:
	* src/file-manager/fm-list-view.c:
	* src/nautilus-emblem-sidebar.h:
	* src/nautilus-notebook.c:
	* src/nautilus-notebook.h:
	Use single GLib/GTK+ includes. Patch by Maxim Ermilov (#560432).

svn path=/trunk/; revision=14797
2008-12-06 10:26:20 +00:00
Christian Persch
4e887d6079 Only include gtk/gtk.h, to allow extensions to build with
* libnautilus-extension/nautilus-location-widget-provider.h:
	* libnautilus-extension/nautilus-menu-provider.h:
	* libnautilus-extension/nautilus-property-page.h: Only include
	gtk/gtk.h, to allow extensions to build with
	*_DISABLE_SINGLE_INCLKUDES. Bug #558070.

svn path=/trunk/; revision=14767
2008-10-27 11:16:06 +00:00
Cosimo Cecchi
31d3fc91d8 Remove gnome-vfs from the required libs.
2008-10-02  Cosimo Cecchi  <cosimoc@gnome.org>

	* libnautilus-extension/libnautilus-extension-uninstalled.pc.in:
	Remove gnome-vfs from the required libs.

svn path=/trunk/; revision=14679
2008-10-02 14:27:48 +00:00