Setting LANG and NO_AT_BRIDGE will prevent warnings about LANG not being
set (obviously) (Tracker), and about the a11y bus not being up, which we
don’t necessarily need to be able to test things.
Starting a D-Bus session before running tests ensures that dbus-launch
doesn’t croak when Tracker tries to reach the SPARQL backend, because of
missing X11 support.
Since this is already part of the search engine struct, and given
that we ref it, there's no point of reffing the query again.
Also not to create a mem-leak when we don't run it.
Since these are forwarded to the title bar, in cases where the middle
click does something special (e.g. minimize the window), unintended
side-effects might be observed in conjunction to opening the location in
a new tab. Claiming the sequence helps prevent that.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/671
Cloning the window while its location is null (i.e. the attributes of
the pending location file are still being waited on) results in a failed
assertion, which is less than desirable. That can be fixed by
preemptively checking if there is a pending location on the slot and
using that in the new window.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/649
On wider windows, we show a border around the pathbar and fill it
with background color using custom CSS specific for Adwaita.
This means the pathbar is unbounded in HighContrast mode or 3rd party
custom themes, giving the headerbar an uncentered, unbalanced layout.
Fix that using the "frame" and "background" style class which are
exposed by Gtk+ for this purpose.
Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/661
This is a regression from 3.28, where the file items where being
selected while searching if the user clicked either up or the down
arrows.
Since 3.30 we moved the query editor to the header bar, this automatic
handling was lost.
To fix it, do something similar as we do when activating the search,
which is emitting a signal to inform the window slot and the views to
perform an explicit action. In this case, we focus the views so further
key events are handled by the views themselves and not by the query.
Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/610
We use custom CSS that undecorates pathbar buttons in Adwaita. However,
this doesn't apply to HighContrast, which keeps button borders, and it
looks bad because there are slashes between them.
While some custom styling is still needed, some can be replaced using
the public "flat" class, with the benefit of removing the button
borders in HighContrast (as well as any 3rd party custom theme that
supports the "flat" class).
Do that. Also, remove the now pointless "linked" class.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/661
Since f692a93d, the left/right keys do not expand/collapse trees.
Also, the [Spacebar] key opens the file instead of previewing it.
This is because we return earlier when we get a state field. This
is a typo, because it should be the reverse.
But actually, it is safe to assume it is always TRUE, because at this
point we got a keval field already. So, skip the condition checking.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/639
The 'Could not display' dialog, is, admittedly pretty ugly.
The line break in the secondary text is tough to read through,
and, YES/NO button actions aren't apparent to the user.
This commit removes the linebreak in the secondary text
and gives the buttons relevant names for the user.
https://gitlab.gnome.org/GNOME/nautilus/issues/583
The 'Could not display' dialog is, admittedly, pretty ugly.
It's not properly capitalized, and, full stops do come
across as rude to the user.
This properly cases & removes the full stop from the
unhandled type dialog header.
https://gitlab.gnome.org/GNOME/nautilus/issues/583