Commit graph

21241 commits

Author SHA1 Message Date
Carlos Soriano 837123f9ff Flatpak: Add gcovr
So we can generate coverage reports.

And do it with pip, cannot make my system run the pipToFlatpak tool
locally.
2018-10-09 13:16:24 +00:00
Jordan Petridis 512fba35bf
CI: Improve formatting of yaml 2018-10-09 15:50:45 +03:00
Jordan Petridis 91b75f82b7
CI: Factorout flatpak job into a template 2018-10-09 15:48:18 +03:00
Ernestas Kulik 62e6db2767 meson.build: Only warn when seccomp support is disabled 2018-10-09 15:36:37 +03:00
Carlos Soriano 0a4327d0cd CI: Update to 3.30 image 2018-10-09 10:18:12 +00:00
Carlos Soriano 9fbb8a8557 Flatpak: Update to 3.30 2018-10-09 12:08:17 +02:00
Carlos Soriano e3f60343cf file: Use target-uri for shortcut file types
This is necessary for files such as GDrive files, where the target uri
is the web url that needs to be opened for activation.

Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/473
2018-10-09 08:18:37 +00:00
Ernestas Kulik 942429b133 meson.build: Use set instead of set10
Since we only care about whether those macros are defined, we can use
set to save a few lines.
2018-10-09 11:01:37 +03:00
Ernestas Kulik e97155f1d1 meson.build: Remove libseccomp dependency where unsupported
A number of CPU architectures are unsupported as far as seccomp goes.
This commit expands the current restriction to Linux by checking the
host CPU.
2018-10-09 11:01:37 +03:00
Ernestas Kulik 182fef9c94 CI: Do additional setup before running tests
Setting LANG and NO_AT_BRIDGE will prevent warnings about LANG not being
set (obviously) (Tracker), and about the a11y bus not being up, which we
don’t necessarily need to be able to test things.

Starting a D-Bus session before running tests ensures that dbus-launch
doesn’t croak when Tracker tries to reach the SPARQL backend, because of
missing X11 support.
2018-10-09 07:29:41 +00:00
Ernestas Kulik faec8c47bc window: Use auto pointer for cursor
If, for some reason, the cursor is null, we end up with a critical when
unreffing. Not very good when running tests.
2018-10-09 07:29:41 +00:00
Ernestas Kulik 692d431a04 tag-manager: Guard against null notifier
tracker_notifier_new() may return a null pointer on error, and that’s
exactly what happens sometimes (CI pipelines,
https://gitlab.gnome.org/GNOME/tracker/issues/43).
2018-10-09 07:29:41 +00:00
Ernestas Kulik 0718606dca meson.build: Enable -Werror=incompatible-pointer-types 2018-10-09 07:29:41 +00:00
Ernestas Kulik 1e95686269 CI: Always generate artifacts 2018-10-09 07:29:41 +00:00
Ernestas Kulik e42a5c1489 CI: Change profile option value
It’s no longer an enum, but rather a string.
2018-10-09 07:29:41 +00:00
Ernestas Kulik f6d8292b57 Flatpak: Remove Automake leftovers from exiv2 2018-10-09 07:29:41 +00:00
Ernestas Kulik f81b091ebf file-utilities: Add missing else statement
a9c446afe2 inadvertently removed it and
that is causing leaks that don’t make sense at first.
2018-10-09 07:29:41 +00:00
Ernestas Kulik 336fd6258a directory: Free list as well as unref items
filtering_changed_callback() populates a list of directories, but never
frees the list.
2018-10-09 07:29:41 +00:00
Ernestas Kulik 048206028c Bug.md: Update flatpakref URL
The ID was changed to reflect that in the manifest that is built.
2018-10-08 18:12:08 +00:00
Marco Trevisan (Treviño) 4c6d4eea99 search-engine-recent: remove add hits idle on finalize
Use a new function to initialize it without having to redo the same
thing twice.
2018-10-08 13:05:14 +00:00
Marco Trevisan (Treviño) 284c5a8612 search-engine-recent: fix memory leak on short-name result
RecentInfo short-name needs to be free'd
2018-10-08 13:05:14 +00:00
Marco Trevisan (Treviño) 9d16ff2e21 search-engine-recent: don't ref/unref query added to self
Since this is already part of the search engine struct, and given
that we ref it, there's no point of reffing the query again.

Also not to create a mem-leak when we don't run it.
2018-10-08 13:05:14 +00:00
Ernestas Kulik dd0e258d49 Flatpak: master: use url, not path for git repo 2018-10-05 20:08:56 +03:00
Ernestas Kulik fa29a901a9 pathbar: Claim path bar button presses
Since these are forwarded to the title bar, in cases where the middle
click does something special (e.g. minimize the window), unintended
side-effects might be observed in conjunction to opening the location in
a new tab. Claiming the sequence helps prevent that.

Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/671
2018-10-04 16:50:36 +03:00
Carlos Soriano 69244cd428 README: Document runtime depedencies
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/395
2018-10-04 07:58:00 +00:00
Ernestas Kulik 8a2234a273 file: Don’t assert as much
Some (public) functions needlessly assert certain facts about their
parameters, and can just throw warnings and return early, instead.
2018-10-02 17:00:36 +03:00
Ernestas Kulik d6f61a8823 application: Check pending location on clone-window
Cloning the window while its location is null (i.e. the attributes of
the pending location file are still being waited on) results in a failed
assertion, which is less than desirable. That can be fixed by
preemptively checking if there is a pending location on the slot and
using that in the new window.

Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/649
2018-10-02 17:00:36 +03:00
António Fernandes 0009d0e771 toolbar: Use GTK_STYLE_CLASS'es on the pathbar container box
On wider windows, we show a border around the pathbar and fill it
with background color using custom CSS specific for Adwaita.

This means the pathbar is unbounded in HighContrast mode or 3rd party
custom themes, giving the headerbar an uncentered, unbalanced layout.

Fix that using the "frame" and "background" style class which are
exposed by Gtk+ for this purpose.

Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/661
2018-10-02 13:25:07 +00:00
Carlos Soriano dae54e0c72 window-slot: Focus view widget on search up or down arrow pressed
This is a regression from 3.28, where the file items where being
selected while searching if the user clicked either up or the down
arrows.

Since 3.30 we moved the query editor to the header bar, this automatic
handling was lost.

To fix it, do something similar as we do when activating the search,
which is emitting a signal to inform the window slot and the views to
perform an explicit action. In this case, we focus the views so further
key events are handled by the views themselves and not by the query.

Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/610
2018-10-02 12:45:30 +00:00
Marek Cernocky 461d1c1cd9 Updated Czech translation 2018-10-02 13:19:21 +02:00
Марко Костић 4d935a8908 Update Serbian translation 2018-09-27 20:04:04 +00:00
António Fernandes 1b6f1ef572 pathbar: Use flat style class
We use custom CSS that undecorates pathbar buttons in Adwaita. However,
this doesn't apply to HighContrast, which keeps button borders, and it
looks bad because there are slashes between them.

While some custom styling is still needed, some can be replaced using
the public "flat" class, with the benefit of removing the button
borders in HighContrast (as well as any 3rd party custom theme that
supports the "flat" class).

Do that. Also, remove the now pointless "linked" class.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/661
2018-09-26 23:02:40 +01:00
António Fernandes 3c901f03d0 pathbar: Drop unused constant
Unused since commit b1abb52610.
2018-09-26 22:21:10 +01:00
Carlos Soriano 5dbed5565e mime-actions: Use more obvious name
I'm not gonna say how much of the day I spent on this code because
I read it the other way around because of the misleading function name.
2018-09-26 16:44:20 +02:00
Ernestas Kulik 62ba6d83df search-engine: Query file system to determine remoteness
Querying the file cache in is_recursive_search() does not guarantee that
the file system field will be populated with a value, and somehow
results in data races, in turn resulting in random crashes/file list
corruption.

Hopefully fixes https://gitlab.gnome.org/GNOME/nautilus/issues/640,
closes https://gitlab.gnome.org/GNOME/nautilus/issues/632 and resolves
https://gitlab.gnome.org/GNOME/nautilus/issues/602
2018-09-25 09:33:49 +03:00
Carlos Soriano d3b4555bb9 general: Fix some leaks catched by Valgrind
This is by just opening and closing the app, we will definitely have
more by regular usage...
2018-09-24 12:50:03 +02:00
António Fernandes 92436eb06a list_view: Fix key events regression
Since f692a93d, the left/right keys do not expand/collapse trees.
Also, the [Spacebar] key opens the file instead of previewing it.

This is because we return earlier when we get a state field. This
is a typo, because it should be the reverse.

But actually, it is safe to assume it is always TRUE, because at this
point we got a keval field already. So, skip the condition checking.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/639
2018-09-23 19:51:55 +01:00
Christopher Hargarten 4fe527bc8b mime-actions: fix unhandled type dialog content
The 'Could not display' dialog, is, admittedly pretty ugly.
The line break in the secondary text is tough to read through,
and, YES/NO button actions aren't apparent to the user.

This commit removes the linebreak in the secondary text
and gives the buttons relevant names for the user.

https://gitlab.gnome.org/GNOME/nautilus/issues/583
2018-09-21 08:45:12 +03:00
Jordan Petridis 61e54e4f8d Revert "Flatpak: Remove unecessary meson options"
This reverts commit a565907fe6
2018-09-20 16:49:00 +00:00
Jordan Petridis a565907fe6
Flatpak: Remove unecessary meson options 2018-09-20 19:25:22 +03:00
Jordan Petridis 60389de8f6
Flatpak: Remove duplicate modules 2018-09-20 19:19:55 +03:00
Christopher Hargarten 3d1a276753 mime-actions: fix unhandled type dialog header
The 'Could not display' dialog is, admittedly, pretty ugly.
It's not properly capitalized, and, full stops do come
across as rude to the user.

This properly cases & removes the full stop from the
unhandled type dialog header.

https://gitlab.gnome.org/GNOME/nautilus/issues/583
2018-09-20 13:39:58 +00:00
Khaled Hosny e78c621b53 Update Arabic translation
(cherry picked from commit eb69e307f1)
2018-09-20 13:04:16 +02:00
Jeremy Bicha 82a7ad8cbb tests: don't require installed gsettings schemas for nautilus test 2018-09-19 14:19:23 +00:00
Carlos Soriano 9f45d23bfd Update build-aux/flatpak/org.gnome.NautilusGtk4.yml, build-aux/flatpak/org.gnome.NautilusMaster.yml files 2018-09-18 11:45:48 +00:00
Carlos Soriano 3b0c1da590 Update build-aux/flatpak/org.gnome.Nautilus.yml 2018-09-18 11:16:46 +00:00
Carlos Soriano 63011cba78 Update build-aux/flatpak/org.gnome.Nautilus.json 2018-09-18 11:15:51 +00:00
Carlos Soriano 77cf43762f Update build-aux/flatpak/org.gnome.Nautilus.yml 2018-09-14 07:41:12 +00:00
Carlos Soriano b4471d3c3b Update build-aux/flatpak/org.gnome.Nautilus.json 2018-09-14 07:30:03 +00:00
Carlos Soriano bfe8f49e15 Update build-aux/flatpak/org.gnome.Nautilus.json 2018-09-14 07:29:03 +00:00