We added a new enum value, but we didn't handled it on places where
we knew it couldn't be reached. However that spits out a warning with
gcc even if we handled it after the switch.
Fix that handling a "default" and returning a default value.
We know we have deprecations functions, and they require a major work
as porting to gtk4.
That's truly a different task to what we are doing every day, and the
multiple warnings obscure all real warnings to the task that is
relevant at that point.
This is making contributors skip the warnings, rather than actually look
at them.
For that, ignore deprecation warnings for now until someone wants to
work in the gtk4 port, and we also assume you read the documentation
when introducing new code in order to avoid deprecations.
Since testing is planned to be done with actual views and no one has
built Nautilus with the empty view enabled recently, it is safe to say
that it should go. This commit removes the empty view.
https://bugzilla.gnome.org/show_bug.cgi?id=779255
autoreconf takes care of running aclocal and other commands
in the right order.
Also, removing aclocal saves around 40 seconds (Thanks to
Ernestas Kulik for testing) when running autogen.sh
https://bugzilla.gnome.org/show_bug.cgi?id=779248
Currently, the default size for window is calculated by taking the
minimum value between the screen size and the hardcoded default. As
the smallest recommended screen size for GNOME today is 1024x600 and the
code has been added in 2000, it is likely no longer relevant. This
commit simply makes the code use the hardcoded values within the
recommended range as the default window size.
https://bugzilla.gnome.org/show_bug.cgi?id=779082
"Adwaita-dark" is supplied by gnome-themes-standard and has a distinct
name to theme GTK+ 2. For GTK+ 3, this theme just imports gtk-contained-
dark.css from the library, so it's _as if_ Adwaita was the system theme.
But Nautilus only applied its Adwaita-specific CSS if the system theme
name was exactly "Adwaita". So using "Adwaita-dark" meant we got Adwaita
but without Nautilus' additions to it, even though they are applicable.
Fix this by also loading Adwaita.css if the theme name is "Adwaita-dark"
https://bugzilla.gnome.org/show_bug.cgi?id=779266
The "status" string was using the g_autofree macro to ensure its
automatic cleanup, but its attributions were all string literals.
We should live by the mantra "WE SHALL NEVER FREE MEMORY THAT WE
DIDN'T MALLOC(ED)".
https://bugzilla.gnome.org/show_bug.cgi?id=779188
In 7840b533e2, `nautilus-directory-provider` extension point was added
to the code paths used by the tests. When glib is asked for extensions,
it assumes the extension point is registered so it segfaults.
This patch registers the extension point before the tests are run.
https://bugzilla.gnome.org/show_bug.cgi?id=779178
Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script to generate a tarball
for releases, since we use libgd as a submodule and Meson does not
handle source distributions.
https://bugzilla.gnome.org/show_bug.cgi?id=778167
This commit removes git.mk and adds hand-written gitignore files. That
is needed to ignore build/, which is the directory of choice for Meson
builds.
https://bugzilla.gnome.org/show_bug.cgi?id=778167
gnome_desktop_thumbnail_scale_down_pixbuf () has been deprecated in
favor of gdk_pixbuf_scale_simple (). This commit replaces the call to
the deprecated function.
https://bugzilla.gnome.org/show_bug.cgi?id=779084
We were using a print function with custom handlers.
Not only this function is hard to understand and follow, but is also non
standard which makes it problematic for translation (where everything is
check using c standards to avoid crashing the application if the translator
makes some unsuported change).
This patch removes every use case of f() function and uses g_strdup_printf
and g_strdup in its place and uses custom functions directly to convert
required parameters into gchar* types.
https://bugzilla.gnome.org/show_bug.cgi?id=775091
The function format_time does not clearly tell anything about
the fact that it is supposed to return something. And also it's
return type is char *. So, to make it consistent it's return
type is changed to gchar *.
This patch renames format_time to get_formatted_time.
https://bugzilla.gnome.org/show_bug.cgi?id=775091
When the metadata of the desktop needs to be recalculated or it's
missing, we need to reposition the icons. They have what we call a
"lazy position". In order to place them on the desktop we either
position them by it's saved position if possible, and if not, moving
them as close as possible without overlaping, or by what we call
"auto layout", which is basically a perfect grid similar to a regular
nautilus window. It's clear from this logic that we do either one way
to place them or the other, and both at the same time doesn't make
sense. For that we assert we just apply one of this placements
algorythms. However, we were hitting this assertion if desktop-metadata
was missing (so they have a lazy position) since we need to reorder the
icons using the auto layout algorthm but the code was also trying to do
the "saved position" algorythm.
This issue is introduced by a commit intended to avoid overlapping icons,
with id: 40c79aec2d. In the initial
implementation of "lazy position" support, if "auto layout" was chosen,
the icons were repositioned only by the "auto layout" algorithm.
To fix this re-add the check that repositions icons only by the
"auto layout" algorithm if "auto layout" is chosen.
https://bugzilla.gnome.org/show_bug.cgi?id=747662
In systems where Tracker is not installed, building Nautilus with it
enabled will check for 1.0, 0.18 and 0.16. Since older versions may not
be installable from distribution packages, we should only care about
1.0.
https://bugzilla.gnome.org/show_bug.cgi?id=779037
The sort order is based on atime currently, which is problematic,
because some daemons (i.e. dropbox) randomly accesses files and
changes atime...
Instead we should just take into account when the user accessed.
Recently glib and gvfs added a new attribute in the recent namespaces
G_FILE_ATTRIBUTE_RECENT_MODIFIED or "recent::modified" that we can use
to sort correctly the files in Recent.
This patch adds this attribute and corresponding columns etc. to the
file data and views and makes it the default sorting when in Recent.
https://bugzilla.gnome.org/show_bug.cgi?id=777507
