* src/nautilus-view-frame.c: (check_if_view_is_gone):
Removed an unnecessary line that was setting a field
of a struct that was just set to NULL. This crashed for
terral (IRC name).
* libnautilus-extensions/nautilus-undo-context.c:
(nautilus_undo_context_new): Bonobo objects own themselves, so we
should not do a ref/sink on them.
* libnautilus-extensions/nautilus-undo-manager.c:
(nautilus_undo_manager_new): Bonobo objects own themselves, so we
should not do a ref/sink on them.
* src/nautilus-application.c: (nautilus_application_initialize):
Move global preferences initialization to main with other
initialize calls.
(nautilus_application_new): Bonobo objects own themselves, so we
should not do a ref/sink on them.
(nautilus_application_destroy): Unref the undo manager to fix a
leak.
* src/nautilus-main.c: (main): Move global preferences
initialization to main with other initialize calls.
* nautilus.spec.in: Added "-k" to build commands so we get more
information about what failed when failing to build via
RPM. Failures are still failures, we just see more of what's
failing.
* components/help/converters/gnome-db2html2/sect-elements.c:
(sect_entry_end_element):
* components/help/converters/gnome-db2html2/toc-elements.c:
(toc_title_start_element):
* components/image-viewer/nautilus-image-view.c:
(init_server_factory):
* components/rpmview/nautilus-rpm-view-install.c:
(nautilus_rpm_view_install_package_callback),
(nautilus_rpm_view_uninstall_package_callback):
* components/services/install/command-line/eazel-alt-install-corba.
c: (main):
* components/services/install/command-line/eazel-alt-install.c:
(main):
* components/services/install/command-line/eazel-install.c:
(generate_new_package_list), (fetch_remote_package_list), (main):
* components/services/install/command-line/eazel-package-query.c:
(main):
* components/services/install/command-line/eazel-revert.c: (main):
* components/services/install/command-line/eazel-uninstall.c:
(main):
* components/services/install/lib/eazel-install-object.c:
(eazel_install_fetch_remote_package_list):
* components/services/install/lib/eazel-install-protocols.c:
(eazel_install_fetch_file), (eazel_install_fetch_package):
* components/services/install/lib/eazel-install-rpm-glue.c:
(install_new_packages), (eazel_install_download_packages),
(uninstall_packages), (eazel_install_start_transaction),
(eazel_install_add_to_rpm_set),
(eazel_install_check_if_related_package):
* components/services/install/nautilus-view/nautilus-service-instal
l-view.c: (nautilus_service_install_preflight_check):
* components/services/install/nautilus-view/nautilus-service-instal
l.c: (nautilus_service_install_view_install_package_callback),
(nautilus_service_install_view_uninstall_package_callback):
* components/services/install/server/main.c: (main):
* components/services/summary/nautilus-view/nautilus-summary-view.c
: (generate_startup_form), (generate_summary_form),
(generate_service_entry_row):
* components/services/time/command-line/main.c: (main):
* components/services/time/service/main.c: (main):
* components/services/trilobite/libtrilobite/trilobite-core-utils.c
: (trilobite_init):
* components/services/trilobite/libtrilobite/trilobite-root-client.
c: (trilobite_root_client_initialize):
* components/services/trilobite/libtrilobite/trilobite-service-pass
wordquery.c: (trilobite_passwordquery_initialize):
* components/services/trilobite/libtrilobite/trilobite-service.c:
(trilobite_service_initialize):
* components/services/trilobite/sample/command-line/main.c: (main):
* components/services/trilobite/sample/service/main.c: (main):
* components/shell/shell.c:
* components/tree/nautilus-tree-model.c:
(nautilus_tree_model_monitor_add),
(nautilus_tree_model_root_node_file_monitor):
* components/tree/nautilus-tree-view.c:
* libnautilus-extensions/nautilus-directory-async.c:
(get_filter_options_for_directory_count):
* libnautilus-extensions/nautilus-file-utilities.c:
(nautilus_uri_is_local_scheme), (nautilus_handle_trailing_slashes):
* libnautilus-extensions/nautilus-icon-dnd.c:
(drag_data_received_callback):
* libnautilus-extensions/nautilus-icon-text-item.c: (iti_event):
* libnautilus-extensions/nautilus-list.c:
(nautilus_list_ensure_drag_data), (nautilus_list_get_drop_action),
(nautilus_list_drag_data_received):
* libnautilus-extensions/nautilus-scalable-font.c:
(initialize_global_stuff_if_needed):
* libnautilus-extensions/nautilus-undo-signal-handlers.c:
(editable_register_edit_undo):
* src/file-manager/fm-icon-view.c:
(context_menu_layout_radio_item_callback):
* src/file-manager/nautilus-indexing-info.c:
(update_progress_display):
* src/nautilus-switchable-search-bar.c:
(nautilus_switchable_search_bar_set_mode):
Got rid of all uses of == TRUE and != TRUE, since they are dangerous.
Got rid of all uses of == FALSE and != FALSE, since they lead to use
of == TRUE and != TRUE.
* components/tree/nautilus-tree-view.c
(nautilus_tree_view_initialize): Set the tree widget to
GTK_SELECTION_SINGLE instead of GTK_SELECTION_BROWSE, fixing bug
3235.
mostly fixed bug 3158, unacceptable memory usage when thumbnailing,
by implementing an upper bound on the file size, above which it
won't try to thumbnail - it's currently set to 1 megabyte, but it
needs to be tweaked. We still need to give the "too big to thumbnail"
files a distinctive icon.
* icons/arlo/Makefile.am:
* icons/arlo/i-directory-192-aa.png:
* icons/arlo/i-directory-96-aa.png:
* icons/arlo/i-directory-72-aa.png:
Added a few more sizes to my folder icons.
Document icons coming soon!
and revealed).
The delay was there for two reasons, one of which was a mistaken
accident of history. Reduced the delay from 300ms to 10ms in icon
view, and to 0ms in list view. Couldn't reduce the icon view delay
to 0ms due to problems with the scroll/redraw being unable to keep
up with holding the arrow key down. The current settings seem to
work well in both views, though it would be worthwhile to verify
this on a maximally-slow target machine.
* libnautilus-extensions/nautilus-icon-container.c:
* libnautilus-extensions/nautilus-list.c:
nautilus_tree_view_find_parent_node bug.
* components/tree/nautilus-tree-model.h:
* components/tree/nautilus-tree-model.c:
(dump_one_file_node),
(nautilus_tree_model_dump_files): New debugging functions
that display what files are known to the tree view.
* components/tree/nautilus-tree-view.c:
(nautilus_tree_view_find_parent_node): Added a bunch of
debugging output in the intermittent case where this
function can't find a node.
* librsvg/Makefile.am:
Dont install the test programs.
* nautilus.spec.in:
Make sure the fallback font is part of the package.
Dont include the rsvg test programs.
2000-09-27 Rebecca Schulman <rebecka@eazel.com>
Fixed bug 1275, that sidebar panels don't have defaults
per user level.
* libnautilus-extensions/nautilus-global-preferences.c:
(get_default_sidebar_iids_for_user_level),
(sidebar_panel_iid_is_in_default_list),
(global_preferences_register_sidebar_panels),
(global_preferences_is_sidebar_panel_enabled):
Added default sets (hard coded, as before) for each
user level, and used them to get the defaults, instead of
the single set for all levels
* libnautilus/nautilus-clipboard.c:
(set_paste_sensitive_if_clipboard_contains_data):
simplified check whether paste should be available.
* src/nautilus-window-menus.c: (nautilus_window_initialize_menus):
Fixed a typo in the clipboard menu text.
type is changed to non-text one)
* src/nautilus-complex-search-bar.c:
(search_bar_criterion_type_changed_callback):
Added a missing "update_dynamic_button_states". This used to
work, so I think it probably got accidentally deleted somewhere
along the way.
* components/tree/nautilus-tree-node.c: (nautilus_tree_node_new):
Get rid of extra allocation of node->details that caused a storage
leak.
* components/tree/nautilus-tree-view.c:
(nautilus_tree_view_insert_model_node): Add a g_free.
(free_uri_to_node_map_entry), (free_uri_to_hack_node_map_entry),
(nautilus_tree_view_destroy): Free the keys of the hash table.
(tree_expand_callback), (tree_collapse_callback),
(tree_select_row_callback): Added missing g_free.
(nautilus_tree_view_item_at): Removed an excess g_strdup.
* libnautilus-extensions/nautilus-preference.c:
(preference_initialize_if_needed): Destroy the global preference
table on exit.
(preference_hash_node_free_func): Free the hash key as well as
the node value.
(preference_register): Use strdup on keys as then are entered
into the hash table.
(preference_hash_node_lookup_with_registration): Remove the strdup
in here since preference_register now handles it.
(destroy_global_preference_table): Renamed and simplified the
existing unused function.
* libnautilus-extensions/nautilus-volume-monitor.c:
(nautilus_volume_monitor_destroy), (free_volume): Free the volume
itself, not just the fields within it.
* src/nautilus-complex-search-bar.c:
(nautilus_complex_search_bar_get_location): Added a missing
g_free.
* src/nautilus-sidebar-tabs.c: (tab_item_destroy_cover),
(nautilus_sidebar_tabs_destroy): Free the tab items too, not just
the list they are stored in.
* src/nautilus-switchable-search-bar.c:
(search_bar_preference_changed_callback): Added a missing g_free.
* libnautilus-extensions/nautilus-theme.c: (free_default_theme),
(nautilus_theme_get_theme_data): Add code to free the default
theme on program exit to make leak detection easier.
* src/nautilus-main.c: (main): Clean up the memory used by the XML
parser on exit to make leak detection easier.
* libnautilus/Makefile.am:
* libnautilus/nautilus-bonobo-workarounds.c:
* libnautilus/nautilus-bonobo-workarounds.h:
Added version of bonobo_object_get_epv that shares a single global
instance instead of allocating a new one each time it's called.
* components/adapter/nautilus-adapter-factory-server.c:
(impl_Nautilus_ComponentAdapterFactory__create):
* libnautilus-extensions/bonobo-stream-vfs.c:
(bonobo_stream_vfs_class_init):
* libnautilus-extensions/nautilus-undo-context.c:
(impl_Nautilus_Undo_Context__create):
* libnautilus-extensions/nautilus-undo-manager.c:
(nautilus_undo_manager_initialize_class):
* libnautilus/nautilus-undo-transaction.c:
(impl_Nautilus_Undo_Transaction__create):
* libnautilus/nautilus-view.c: (impl_Nautilus_View__create):
* src/nautilus-history-frame.c:
(impl_Nautilus_HistoryFrame__create):
* src/nautilus-shell.c: (nautilus_shell_get_vepv):
* src/nautilus-view-frame-corba.c:
(impl_Nautilus_ViewFrame__create):
* src/nautilus-zoomable-frame-corba.c:
(impl_Nautilus_ZoomableFrame__create):
Use the new cover for bonobo_object_get_epv to avoid
making lots of copies of it.
* src/nautilus-window-menus.c: (get_user_level_image): Formatting
tweak.
* tools/leak-checker/nautilus-leak-checker.c: Added more "known to
allocate and not free on exit" functions.
when filtering preferences change)
* libnautilus-extensions/nautilus-directory.c:
(invalidate_one_count): hash table foreach function that
invalidates the count of a NautilusDirectory.
(filtering_changed_callback): preference callback function
that calls invalidate_one_count on all extant directories.
(add_filtering_callbacks): add preference callbacks for each
file-filtering preference.
(remove_filtering_callbacks): remove those preference callbacks.
(nautilus_directory_get_internal): When directories hash table
is created, call add_filtering_callbacks and schedule
remove_filtering_callbacks for exit time.
Fixed bug 2001 (adding/removing files doesn't update directory counts)
* libnautilus-extensions/nautilus-directory-async.c:
(get_corresponding_file): Removed from here, replaced by
nautilus_directory_get_existing_corresponding_file, now
in nautilus-directory.c
(nautilus_directory_invalidate_counts): New function, split out
from nautilus_directory_force_reload.
(nautilus_directory_force_reload): Now calls _invalidate_counts.
* libnautilus-extensions/nautilus-directory-private.h:
Added prototypes for nautilus_directory_get_existing_corresponding_file
and nautilus_directory_invalidate_counts.
* libnautilus-extensions/nautilus-directory.h:
Added prototype for nautilus_directory_get_corresponding_file.
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_get_corresponding_file): New public function,
returns NautilusFile object for this NautilusDirectory (whether or
not one already existed).
(nautilus_directory_get_existing_corresponding_file): Moved and
renamed private function, returns NautilusFile object for this
NautilusDirectory but only if one already exists.
(invalidate_count_and_unref): New helper hash table foreach function,
invalidates count & unrefs a NautilusDirectory.
(collect_parent_directories): New helper function, adds directory
to hash table & refs if not already present.
(nautilus_directory_notify_files_added),
(nautilus_directory_notify_files_removed),
(nautilus_directory_notify_files_moved): Use these two new functions
to invalidate directory counts when files added/removed.
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_get_internal): Initialize a variable to NULL
to make compiler happy.
Reimplemented "select all should be insensitive when there
are no files to select" a better way after Darin hinted.
* src/file-manager/fm-directory-view.h: Added is_empty function
pointer and prototype for fm_directory_view_is_empty.
* src/file-manager/fm-directory-view.c:
(fm_directory_view_initialize_class): made is_empty a MUST_OVERRIDE
function.
(get_directory_as_file): Simplified implementation by calling new
nautilus_directory_get_corresponding_file.
(no_items_showing): Removed this function.
(compute_menu_item_info): Use fm_directory_view_is_empty instead of
no_items_showing.
(fm_directory_view_is_empty): New function, calls virtual function.
(fm_directory_view_real_create_background_context_menu_items): Fixed
bug where "New Folder" item in context menu was sensitive when it
shouldn't have been.
* src/file-manager/fm-list-view.c: (fm_list_view_initialize_class),
(real_is_empty): Overrode is_empty function pointer to check whether
row count of list is 0.
* libnautilus-extensions/nautilus-icon-container.h:
* libnautilus-extensions/nautilus-icon-container.c:
(nautilus_icon_container_is_empty): New function, checks whether
list of icons is NULL.
* src/file-manager/fm-icon-view.c: (fm_icon_view_is_empty),
(fm_icon_view_initialize_class): Overrode is_empty function pointer
to ask icon container.
2000-09-26 J Shane Culpepper <pepper@eazel.com>
* components/services/summary/nautilus-view/nautilus-summary-view.c
: (generate_startup_form), (generate_summary_form):
* nautilus-installer/src/Makefile:
Adding scroll bar capabilities to various sections and cleaning up
the box packing so that things look slightly better than with frames.
2000-09-26 Rebecca Schulman <rebecka@eazel.com>
Fixed bugs 691, 689, and 733. Hopeully this also
fixes 690, but I can't test it, because rename in
place is confused on my system
* components/notes/nautilus-notes.c: (make_notes_view):
Change clipboard initialization to new signature
* libnautilus/nautilus-clipboard.c:
* libnautilus/nautilus-clipboard.h:
(set_paste_sensitive_if_clipboard_contains_data),
(add_menu_items_callback), (remove_menu_items_callback),
(set_clipboard_menu_items_sensitive),
(set_clipboard_menu_items_insensitive), (menu_activated_callback),
(menu_deactivated_callback),
(nautilus_clipboard_set_up_editable_from_bonobo_control),
(nautilus_clipboard_setup_local):
Add calls to sensitize and desensitize. Change signatures
around to get the data necessary to find out whether cut
and paste should be active or not
* src/nautilus-location-bar.c: (nautilus_location_bar_initialize):
* src/nautilus-window-menus.c: (nautilus_window_initialize_menus):
Change clipboard menu signatures to fit above changes
* src/nautilus-window.c: (nautilus_window_constructed):
add clipoard initialization, after the local ui handler is created
Fixed bug 2488 (path name for link set determined incorrectly) by
using only paths for link sets, never URIs.
* tools/leak-checker/nautilus-leak-checker.c: Added more "known to
leak" symbols.
* libnautilus-extensions/nautilus-link-set.c: (create_new_link),
(nautilus_link_set_is_installed), (nautilus_link_set_remove):
Changed functions to always expect paths, so they can now use
nautilus_make_path instead of link_set_path_name.
* src/nautilus-sidebar.c: (metadata_button_callback): Changed to
turn the URI into a path before calling the link-set functions.
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_notify_files_moved): Use
nautilus_file_list_free instead of
nautilus_g_list_free_deep_custom.
* libnautilus-extensions/nautilus-string-list.c:
(nautilus_string_list_clear): Use nautilus_g_list_free_deep
instead of nautilus_g_list_free_deep_custom.
* libnautilus-extensions/nautilus-view-identifier.c:
(nautilus_view_identifier_free_callback),
(nautilus_view_identifier_list_free): Fixed call to
nautilus_g_list_free_deep_custom so it doesn't need a function
pointer type cast any more.
other window in bad state)
Also ran into some tree view problems that I did not fix
but made less deadly so I could continue.
* components/tree/nautilus-tree-view.c:
(nautilus_tree_view_model_done_loading_callback),
(reload_node_for_uri):
Added g_return_if_fails checking the model and node parameters,
so it won't segfault with a NULL node. I did not attempt to
debug why the nodes were NULL.
* src/nautilus-window-private.h: Added viewed_file field to
details struct.
* src/nautilus-window-manage-views.c:
(viewed_file_changed_callback): New function, closes window if
viewed_file is gone.
(nautilus_window_update_internals): Set viewed_file to
NautilusFile for this location (after unreffing old one), and
connect to its "changed" signal with viewed_file_changed_callback.
(nautilus_window_end_location_change_callback): Truncate the
"for display" version of the URI in error messages.
* src/nautilus-window.c: (nautilus_window_destroy):
unref viewed_file.
2000-09-26 Victor Lecha <victor@eazel.com>
make it compile.
* components/services/summary/nautilus-view/Makefile.am:
make it include correct libtrilobite path.
* components/services/summary/nautilus-view/nautilus-summary-view.c:
small tweak.
2000-09-26 Gene Z. Ragan <gzr@eazel.com>
Work in progress on allowing the user to set a HTTP proxy.
* components/mozilla/nautilus-mozilla-content-view.c:
(nautilus_mozilla_content_view_initialize):
* libnautilus-extensions/nautilus-global-preferences.c:
(global_preferences_create_dialog), (global_preferences_register):
* libnautilus-extensions/nautilus-global-preferences.h:
2000-09-26 Pavel Cisler <pavel@eazel.com>
* libnautilus-extensions/nautilus-file-utilities.c:
(pthread_nautilus_read_file_callback_idle_binder),
(pthread_nautilus_read_file_callback_common),
(pthread_nautilus_read_file_synchronous_callback),
(pthread_nautilus_read_file_asynchronous_callback),
(pthread_nautilus_read_file_thread_entry),
(pthread_nautilus_read_file_async),
(pthread_nautilus_read_file_async_cancel),
(nautilus_read_file_async), (nautilus_read_file_cancel):
Experimental replacement for the nautilus_read_file_async
as a potential speed improvement. Need to do some more profiling
to see if we are getting any gain.
