Commit graph

20126 commits

Author SHA1 Message Date
Jason Gerecke
5bca20de25 canvas-container: Cancel active rubberband if a new one is started
Wayland allows multiple pointers to be active at the same time, e.g. when
a Wacom tablet and mouse are both connected to a system. This means that
it is possible to recieve a "rubberband start" event from a second tool
while a rubberband is already active. At the moment, this results in stray
selection rectangles since the canvas does not properly perform cleanup.

To prevent these graphical glitches from occuring, we can simply cancel
any existing rubberband operation if a second one attempts to start. The
only additional minor complication is ensuring that the new rubberband
is not stopped when the first tool sends a button-up event.

https://bugzilla.gnome.org/show_bug.cgi?id=783797
2017-06-15 18:33:43 +02:00
Jason Gerecke
ee67066c99 canvas-container: Use rubberband coordinates from original device
Nautilus assumes that the pointer returned by gdk_seat_get_pointer will
return the same GdkDevice which started a rubberband action. This is
not necessarily the case, however. Under Wayland, for example, tablet
tools have pointers (and GdkDevice's) which are entirely separate from
the seat's primary mouse-driven pointer. Attempting to use a pen to
perform rubberband selection will result in the rectangle being drawn
with the incorrect coordinates.

This patch has the code store the GdkDevice which generated the event
and provides it in place of the call to gdk_seat_get_pointer.

https://bugzilla.gnome.org/show_bug.cgi?id=783797
2017-06-15 18:33:43 +02:00
Jordi Mas
18f0f93d14 Update Catalan translation 2017-06-14 07:07:22 +02:00
Ernestas Kulik
da471facf7 Revert "files-view: Add alternative shortcut for renaming files"
This reverts commit 3c00fa343e.
2017-06-13 18:33:13 +03:00
Piotr Drąg
891ca5e5e7 Use glib preset for i18n
https://bugzilla.gnome.org/show_bug.cgi?id=783746
2017-06-13 16:28:40 +02:00
Kjartan Maraas
b250a10e5a Added Norwegian bokmål translation 2017-06-12 20:43:05 +02:00
Mario Blättermann
1331d7ce7b Update German translation 2017-06-09 19:22:45 +00:00
Kukuh Syafaat
0aa7a55f84 Update Indonesian translation 2017-06-06 10:24:49 +00:00
Daniel Mustieles
09e32da8e4 Update Spanish translation 2017-06-05 14:00:19 +00:00
Emin Tufan Çetin
b6aa7cbbdb Update Turkish translation 2017-06-02 15:06:32 +00:00
Alexandru Pandelea
2d99bcf4bd fix misuse of nautilus_file_is_desktop_directory
The issue is that when navigating into the Desktop directory, the slot
is replaced with a desktop window slot.

This happens because when checking if the current location is handled by
the current slot, the check was made for the actual Desktop directory
instead for the virtual Desktop.

To fix this, instead of checking if the location matches the actual dir,
check if it matches the right uri. A similar issue was in files-view
when creating a new folder, so also change that accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=771710
2017-05-31 16:03:21 +03:00
Alexandru Pandelea
9ab9de94b3 nautilus-window: add wrapper for creating slot
Always when creating a slot in NautilusWindow, it is also initialized,
so create a wrapper which does both the creating and initializing.
https://bugzilla.gnome.org/show_bug.cgi?id=561136
2017-05-31 15:58:52 +03:00
Alexandru Pandelea
6e16bc32e8 add "restore tab" action
Adds option to reopen closed tabs with Ctrl+Shift+T.

In order to do so, keep a list with data needed to restore closed
tabs. So, this list keeps the location bookmark, the view id before
search, which is needed in case the closed tab was a search and
the back/forward history.

https://bugzilla.gnome.org/show_bug.cgi?id=561136
2017-05-31 15:58:52 +03:00
Baurzhan Muftakhidinov
e4e9eb83d5 Update Kazakh translation 2017-05-30 17:02:51 +00:00
Ernestas Kulik
80ebc12c49 file-operations: deduplicate code
Some duplicate code can be removed by refactoring
mark_desktop_file_executable().

https://bugzilla.gnome.org/show_bug.cgi?id=782658
2017-05-30 11:17:56 +03:00
Fabio Tomat
f8868596c3 Update Friulian translation 2017-05-29 10:21:28 +00:00
Марко Костић
ce146e7552 Update Serbian translation
(cherry picked from commit 6830977fb6)
2017-05-27 22:44:51 +00:00
Fabio Tomat
6e29fe79aa Update Friulian translation 2017-05-25 12:20:19 +00:00
Kukuh Syafaat
f796f4a137 Update Indonesian translation 2017-05-18 12:55:18 +00:00
Alexandru Pandelea
fd05b6f064 search-engine-tracker: don't use fts:match on empty search entry
If the search entry is empty and filtering for date or mime type is
added, then the sparql query always returns nothing because of
fts:match '""*'

To get the expected search results don't use fts:match when the
search text is empty.

https://bugzilla.gnome.org/show_bug.cgi?id=782596
2017-05-16 23:58:49 +03:00
Ernestas Kulik
8a14b5329c file-operations: duplicate: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:24 +03:00
Ernestas Kulik
7b7f0a1b63 file-operations: set_permissions_recursive: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:24 +03:00
Ernestas Kulik
f673ae8ab2 file-operations: empty_trash: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:24 +03:00
Ernestas Kulik
0d207faa30 file-operations: mark_desktop_file_executable: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:24 +03:00
Ernestas Kulik
b1d57bc5a9 file-operations: delete: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:24 +03:00
Ernestas Kulik
8e8010de41 file-operations: copy: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:23 +03:00
Ernestas Kulik
48fd326ee8 file-operations: move: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:23 +03:00
Ernestas Kulik
0406451c70 file-operations: link: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:06:16 +03:00
Ernestas Kulik
caef877dee file-operations: create: use automatic cleanup
https://bugzilla.gnome.org/show_bug.cgi?id=782650
2017-05-15 15:04:38 +03:00
Mario Blättermann
9e59b21fed Update German translation 2017-05-14 18:47:56 +00:00
Ernestas Kulik
fb8b8ca54e views: handle keyboard activation in files-view
Each view handles keyboard activation on its own by listening to
key-press-event, yet there are actions in files-view that could handle
it. This commit makes it so, additionally swapping the accelerators for
opening in new tab and window to make things more consistent throughout
the application (and others, too, e.g. Firefox).

https://bugzilla.gnome.org/show_bug.cgi?id=782600
2017-05-14 12:21:12 +03:00
Ernestas Kulik
1e898de966 mime-actions: check for valid error before dereferencing
After launching a URI, the code checks if the operation has been
canceled, but does not check if the error pointer is valid.

https://bugzilla.gnome.org/show_bug.cgi?id=781132
2017-05-13 23:02:38 +03:00
Piotr Drąg
8480203d1a batch-rename-dialog: fix grammar in translatable strings
https://bugzilla.gnome.org/show_bug.cgi?id=782601
2017-05-13 19:47:09 +02:00
Piotr Drąg
5713949603 batch-rename-dialog: mark strings as translatable
https://bugzilla.gnome.org/show_bug.cgi?id=782601
2017-05-13 19:40:58 +02:00
Diana Grecu
0e21d1877e batch-rename: show error on empty name
When the destination name is empty, the "Rename" button goes
insensitive without explaining the user why it happened.

To explain what happened show a descriptive message to inform
the user.

https://bugzilla.gnome.org/show_bug.cgi?id=772435
2017-05-13 19:18:25 +03:00
Ernestas Kulik
f5206a6daf mime-actions: launch default uri handlers when activating files
Currently, Nautilus tries to find the default applications for files
itself, which does not work well in a sandbox. This commit makes
Nautilus blindly launch the default applications, which makes use of the
documents portal indirectly.

https://bugzilla.gnome.org/show_bug.cgi?id=781132
2017-05-13 19:16:01 +03:00
Ernestas Kulik
a4931f4a66 program-choosing: reindent header
https://bugzilla.gnome.org/show_bug.cgi?id=781132
2017-05-13 19:16:01 +03:00
Piotr Drąg
b232004a1a Fix typos in Portuguese translation
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=773687
2017-05-13 15:15:31 +02:00
Kukuh Syafaat
09354730f6 Update Indonesian translation 2017-05-13 00:43:28 +00:00
Carlos Soriano
7148aca89a view-icon-controller: Fix double-free
We weren't taking a ref, but we were unrefing afterwards.
2017-05-13 00:01:26 +02:00
Mario Blättermann
e9d63bf01b Update German translation 2017-05-12 14:51:56 +00:00
Carlos Soriano
2cb1f8b099 preferences-window.ui: Use header bar
So it's consistent with all the other dialogs.
Also use a GtkDialog instead of a window.
2017-05-11 14:47:37 +02:00
Waqar Ahmed
ff7e8f7625 window: port to G_DECLARE_*_TYPE decl
This patch ports the manual definition of macros to G_Declare type
declaration, which makes the code cleaner and easier to read and
understand.

https://bugzilla.gnome.org/show_bug.cgi?id=782204
2017-05-06 14:42:02 +03:00
Mohammed Sadiq
ec52282f15 toolbar: Don't leak previous allocations
When undo_active/redo_active is FALSE, undo_label/redo_label
was getting overwritten irrespective of whether they were
NULL or not.

Let the label values be freed incase they are updated.

https://bugzilla.gnome.org/show_bug.cgi?id=782083
2017-05-05 17:14:56 +03:00
Jeremy Bicha
1ca554b872 canvas-item: Don't wrap after . immediately followed by numbers
Nautilus allowed line wrapping for filenames after a . or _
The code made an exception for version numbers, but it
was too rigid and broke things like Ubuntu's 12.04 version
numbering. This relaxes the exception so that the line isn't
wrapped for a . or _ immediately followed by any numbers.

https://launchpad.net/bugs/942539

https://bugzilla.gnome.org/show_bug.cgi?id=781875
2017-05-04 04:37:34 -04:00
Carlos Soriano
bd9ae8d0a6 flatpak: Add stable release
So we can put it in FlatHub

https://bugzilla.gnome.org/show_bug.cgi?id=782125
2017-05-03 20:26:27 +02:00
Fabio Tomat
7550472d80 Update Friulian translation 2017-05-03 05:36:53 +00:00
Alexandru Pandelea
c68efe281b window-slot: fix activate on search entry
The issue is that when pressing enter in search while the search entry
has the focus, right after the callback to activate the selection is
called, Nautilus also tries to activate the location corresponding to
the base of the search, as the view is still searching.

This occurs because in the activated signal the search is set as not
visible manually, which will make Nautilus check immediatly if it should
go back to the base of the search location, without waiting for the view
to update.

To fix this, don't set the search as not visible in the activated callback,
as when the search-mode-enabled property changes, if necessarry, the
cancel signal will be emitted which will set the search as not visible,
which will happen only after the view is updated. This is the behavior for
activating the selection in other ways, so activation with focus on the
entry should behave the same.

https://bugzilla.gnome.org/show_bug.cgi?id=764981
2017-05-02 21:35:45 +03:00
Evgeny Shulgin
941b3fe16e file-conflict-dialog: confirm filename change with return key
The problem is that when we have a file conflict dialog, we can write
a new name for the file in GtkEntry in the expander "Select a new
name for the destination", but after typing in a new file name,
pressing <ENTER> does nothing, but should close this dialog and
confirm the renaming.

To fix this we enable "activates-default" flag for the GtkEntry.

https://bugzilla.gnome.org/show_bug.cgi?id=780449
2017-05-02 21:20:34 +03:00
Carlos Soriano
53928d7f46 postinstall: Use python
Instead of shell scripts, much better to maintain.
Also, the new python script has better handling of non existing paths.
2017-05-02 19:50:54 +02:00