* libnautilus-extensions/nautilus-view-identifier.h: Remove
HAVE_POPT_H define since the bug in OAF that we were working
around has been fixed.
* components/music/nautilus-music-view.c: Remove unneeded
includes.
* components/rpmview/nautilus-rpm-view.c: Remove unused
#define and FIXME for bug already fixed.
* components/tree/nautilus-tree-view.c:
(nautilus_tree_view_destroy): Remove FIXME for bug already fixed.
* libnautilus-extensions/nautilus-global-preferences.c: Remove
FIXME for bug already fixed.
* libnautilus-extensions/nautilus-user-level-manager.c: Remove
FIXME for bug already fixed.
* src/file-manager/fm-list-view.c: (fm_list_get_default_action):
Remove FIXME for bug already fixed.
* src/nautilus-property-browser.c: (add_background_to_browser):
Remove FIXME for bug already fixed.
* src/nautilus-window.h: Remove FIXME for bug already fixed.
* tools/README: Remove file now that people have had a chance to
find the tools in their new location, so the directory will go
away.
2000-11-16 Rebecca Schulman <rebecka@eazel.com>
* check-FIXME.pl:
Make below change work for modules containing the
'-' character (like, say, gnome-vfs)
2000-11-16 Rebecca Schulman <rebecka@eazel.com>
reviewed by: Darin Adler <darin@eazel.com>
(Patch for check-FIXME.pl; later I added
additional check for "This is not a fixme bug")
* check-FIXME.pl:
Add the functionality that it also checks for bugs marked
with "fixme" in the bugzilla database for a product, and
notifies you if the bug has no fixme comment in the source.
This is not a perfect operation, so you can explicitly
include the comment "This is not a fixme bug" and the
script will ignore it.
* libnautilus-extensions/nautilus-search-uri.c:
Fixed some wording so that the text is not hard to
understand if we are creating an english equivalent for
several criteria.
* check-FIXME.pl: Skip the macros directory.
* libnautilus-extensions/nautilus-directory-async.c:
(async_job_start), (async_job_end), (get_one_value_callback),
(get_one_value), (async_job_wake_up): Add new calls that limit the
number of async. jobs done at once.
(directory_count_cancel), (deep_count_cancel), (mime_list_cancel),
(top_left_cancel), (activation_uri_cancel), (file_info_cancel),
(metafile_read_cancel), (metafile_read_done): End the async. job
if it's cancelled.
(metafile_read_try_public_metafile), (metafile_read_restart):
Changed the old metafile_read_start function's name to
metafile_read_restart since it's used on the second try.
(is_anyone_waiting_for_metafile), (metafile_read_start): Move the
logic about whether to start reading into this function to make it
more like the other jobs. Also start the async. job.
(file_list_cancel): Changed name for consistency and end the
async. job.
(directory_count_callback): End the async. job.
(start_monitoring_file_list): Start the async job.
(file_list_start): Moved logic about when to start loading the file
list into this function to make it more like other jobs.
(directory_count_start): Renamed to make it more like other jobs
and start the async. job.
(deep_count_callback): End the async. job.
(deep_count_start): Start the async. job.
(mime_list_callback): End the async. job.
(mime_list_start): Start the async. job.
(top_left_read_done): End the async. job.
(top_left_start): Start the async. job.
(get_info_callback): End the async. job.
(file_info_start): Start the async. job.
(activation_uri_done): End the async. job.
(activation_uri_start): Start the async. job.
(nautilus_directory_async_state_changed): Wake up directories that
may have breathing from from all the cancellation.
(nautilus_directory_cancel): Moved the cancelling code down here,
remove a directory from the waiting list when it goes, and also
wake up directories that may have breathing room from all the
cancellation.
* libnautilus-extensions/nautilus-directory-private.h: Remove
request_read_metafile from the header.
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_destroy): Eliminate the call to
nautilus_directory_stop_monitoring_file_list since that's now
handled by nautilus_directory_cancel.
* libnautilus-extensions/nautilus-file-private.h: Removed the
got_*_mime_type variables since they are the same as *_mime_type
!= NULL.
* libnautilus-extensions/nautilus-file.c: (destroy): Get rid of
checks for NULL before calling g_free.
(nautilus_file_update_info): Replace == FALSE with !. Simplified
some tortuous logic by getting rid of checks for NULL that weren't
needed and booleans that weren't needed.
(get_either_mime_type): Add helper to make it easier to avoid
confusion between default and slow MIME type.
(nautilus_file_compare_by_type): Use get_either_mime_type so it
works when default MIME type is NULL.
(nautilus_file_get_type_as_string): Use get_either_mime_type so it
works when default MIME type is NULL.
(nautilus_file_get_slow_mime_type): Simplified logic. Also got rid
of "application/nonono" which was left here by accident.
(nautilus_file_get_mime_type): Simplified logic and use
get_either_mime_type to share code.
(nautilus_file_is_mime_type): Simplified logic and use
get_either_mime_type to share code.
* src/file-manager/fm-directory-view.c: Format tweaks.
* user-guide/C/Makefile.am: Not so much echoing as we install.
* check-FIXME.pl: Removed some special-case file names
that aren't needed any more.
* libnautilus-extensions/nautilus-file-operations.c:
(get_link_name): Added comments to help localizers.
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_get_date_as_string): Added comments to help
localizers. Deals with bug 2720 (Please add a comment to help
localizers do date translations)
* libnautilus-extensions/nautilus-icon-canvas-item.c:
(draw_or_measure_label_text): Added a comment to help localizers.
* src/file-manager/fm-directory-view.c:
(fm_directory_view_display_selection_info): Unmarked one string
that doesn't make sense to translate and adding a comment to
another to explain why it is marked for translation.
(add_separator): Changed add_open_with_gtk_menu_item into this
function, which deals with bug 2735 (add_open_with_gtk_menu_item
only called to create separator?).
(create_open_with_gtk_menu): Call the new add_separator function.
* src/nautilus-zoom-control.c: (create_zoom_menu_item): Added a
comment to help localizers.
* libnautilus-extensions/nautilus-link.c: (make_local_path): Fixed
logic here that was doing strange things with URIs. This deals
with bugs 2492 (Incorrect unescaping when dealing with link
files), 2493 (Mysterious and probably incorrect "+7" when escaping
URI for link file), and 2737 (link code must make path into URI).
* libnautilus-extensions/nautilus-search-bar-criterion.c:
* libnautilus-extensions/nautilus-search-bar-criterion.h:
* po/POTFILES.in:
Removed these duplicate files. Rebecca moved them to src, but she
didn't remove the old ones. I didn't have to remove them from the
makefile, since they were already removed, but I had to remove
them from the list of files to translate.
* src/nautilus-search-bar-criterion.h:
* libnautilus-extensions/nautilus-search-uri.h:
Moved some of the stuff from nautilus-search-bar-criterion.h to
here, since it's really about search URIs, not specific to the
search bar. Over time we will move more.
* src/nautilus-search-bar-criterion.c: Added include of the
nautilus-search-uri.h header now that stuff was moved there.
* src/file-manager/fm-search-list-view.c:
Fixed includes to get the nautilus-search-bar-criterion.h from its
new location. This is not a real solution to the problem that was
exposed by moving the search bar code. The bug 2815 covers this.
* src/nautilus-complex-search-bar.c: Fix search bar so it gets
the real location of the header. It was including the old one.
* src/nautilus-simple-search-bar.c: Fix search bar so it gets
the real location of the header. It was including the old one.
* src/nautilus-main.c: (main): Some small cleanups including some
additional parameter checking and returning a failure code to
the invoking shell in the case where the parameters are not
consistent.
* libnautilus-extensions/nautilus-directory-private.h:
* libnautilus-extensions/nautilus-directory-async.c:
(nautilus_directory_is_anyone_monitoring_file_list):
Made this function public because it's needed to get the
assert right.
(start_or_stop_io): Use it by the new public name.
* libnautilus-extensions/nautilus-vfs-directory.c:
(vfs_is_not_empty): Use the new function to get the assert
right, which fixes bug 2706 (crash at startup with
bookmark for nonexistent trash file).
* libnautilus-extensions/nautilus-trash-directory.c:
(remove_trash_volume): Fix a NautilusDirectory leak.
* libnautilus-extensions/nautilus-glib-extensions.c:
(print_key_string), (free_hash_tables_at_exit):
Print keys before complaining about hash table so you
see them first if you have things set to drop into
the debugger on warnings.
2000-08-31 Rebecca Schulman <rebecka@eazel.com>
Completed the rest of 2369 for the required
milestone.
* check-FIXME.pl: Make the script a little
bit smarter about recognizing FIXMEs with
bug reports.
* src/nautilus-search-bar-criterion.c:
* src/nautilus-search-bar-criterion.h:
* src/nautilus-search-bar-criterion-private.h:
(nautilus_search_bar_criterion_destroy),
(nautilus_search_bar_criterion_new), (option_menu_callback),
(nautilus_search_bar_criterion_set_callback),
(nautilus_search_bar_criterion_new_from_values),
(nautilus_search_bar_criterion_next_new),
(nautilus_search_bar_criterion_first_new),
(nautilus_search_bar_criterion_get_location),
(get_next_default_search_criterion_type),
(nautilus_search_bar_criterion_show),
(nautilus_search_bar_criterion_hide),
(nautilus_search_bar_criterion_human_from_uri),
(nautilus_search_uri_get_first_criterion), (get_name_location_for),
(get_content_location_for), (get_file_type_location_for),
(get_size_location_for), (get_emblem_location_for),
(get_date_modified_location_for), (get_owner_location_for),
(make_emblem_value_menu), (emblems_changed_callback):
* libnautilus-extensions/Makefile.am:
* src/Makefile.am:
moved search bar criterion class out of
libnautilus-extensions and into /src
Added acceptance of the emblems changed signal, which
causes a redraw of an emblem criteria menu.
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_destroy), (construct_private_metafile_vfs_uri),
(nautilus_directory_new):
Changed the name of metafile_vfs_uri function from
metafile_uri to reflect its return of a gnome vfs uri.
Check for the case where the metafile was not successfully
created when freeing.
* src/nautilus-complex-search-bar.c: (criterion_callback):
got rid of extraneous print statement.
* src/nautilus-property-browser.c: (remove_emblem),
(emblem_dialog_clicked), (emit_emblems_changed_signal):
Added the emission of signals that happen when the list of
emblems change so that we tell the search bar about it.
* src/nautilus-signaller.c: (nautilus_signaller_initialize_class):
* src/nautilus-signaller.h:
Added an "emblems changed" signal to the signaller's vocabulary,
since we need a global signal, so this seems to be the logical
object to attach it to.
* check-FIXME.pl: Added HACKING to the files to skip.
* components/services/install/idl/trilobite-eazel-install.idl:
* components/services/install/lib/eazel-install-corba-callback.c:
(impl_install_failed), (impl_uninstall_failed),
(eazel_install_callback_query):
* components/services/install/lib/eazel-install-corba-types.c:
(corba_packagedatastruct_from_packagedata),
(packagedata_from_corba_packagedatastruct):
* components/services/install/lib/eazel-install-corba.c:
(impl_Eazel_Install_query):
* components/services/install/lib/eazel-install-protocols.c:
(eazel_install_fetch_package),
(eazel_install_fetch_package_which_provides),
(get_url_for_package), (get_search_url_for_package):
* components/services/install/lib/eazel-install-rpm-glue.c:
(eazel_install_do_rpm_transaction_save_report),
(eazel_install_fetch_rpm_dependencies),
(eazel_uninstall_upward_traverse),
(eazel_uninstall_downward_traverse):
* components/services/install/lib/eazel-install-types.c:
(packagedata_destroy_foreach):
* src/file-manager/fm-directory-view.c: (activate_callback):
* src/nautilus-window.c: (nautilus_window_realize):
Fixed "FIXME bugzilla.eazel.com ###:" formatting to match what
check-FIXME.pl looks for. The colon goes after the bug number.
And it has to be "bugzilla.eazel.com", not "bug".
* libnautilus-extensions/nautilus-directory-async.c:
(allow_metafile): Fixed a comment.
* libnautilus-extensions/nautilus-drag.c:
(nautilus_drag_can_accept_item):
Got rid of a fixed FIXME and changed to use
nautilus_file_is_directory instead of nautilus_file_get_file_type.
* check-FIXME.pl: Maciej helped me refine the find command so it
doesn't go into po or CVS directories and only looks at files.
* components/music/nautilus-music-view.c:
(nautilus_music_view_background_changed): Turned the metadata saving
code back on. I think I fixed the problem that made Andy turn it off.
* libnautilus-extensions/nautilus-directory-metafile.c:
(set_metadata_eat_value): Fixed a double-delete problem. Oops.
(nautilus_directory_set_metadata): Fixed code that wasn't emitting the
metadata_changed signal enough.
* libnautilus-extensions/nautilus-gdk-extensions.c:
(nautilus_fill_rectangle_with_color): Fixed a crash in Gdk. It turns
out gdk_rgb needs to be initialized, even though I don't think that
was the intent.
* check-FIXME.pl: Added the count of FIXMEs with bug numbers
as well as the count of FIXMEs without.
* components/services/trilobite/lib/helixcode-utils.c:
(xml_get_value), (prune_xml), (check_for_root_user),
(check_for_redhat), (determine_redhat_version),
(determine_mandrake_version), (determine_turbolinux_version),
(determine_suse_version), (determine_debian_version),
(determine_distribution_type), (get_distribution_name):
A tiny bit of cleanup on these functions. There was some really
bad code in here, including code that compared strings with ==.
Also a lot of code that does open and then no close, for no
good reason, so I added the close.
* libnautilus-extensions/nautilus-file.c: (rename_callback),
(nautilus_file_get_mapped_uri):
* libnautilus-extensions/nautilus-icon-container.c:
(nautilus_icon_container_update_icon):
* libnautilus-extensions/nautilus-icon-dnd.c:
(confirm_switch_to_manual_layout), (nautilus_icon_dnd_begin_drag):
* src/file-manager/fm-icon-view.c: (update_layout_menus),
(sort_callback), (manual_layout_callback):
* src/ntl-view.c: (nautilus_view_destroy_client):
Added bug numbers to some FIXMEs.
* check-FIXME.pl:
* check-config-h.pl: Added "." parameter to "find" so it works
with non-GNU versions of find. This was for Morten, who wanted
to run check-config-h.pl on Gnumeric.
* libnautilus-extensions/nautilus-directory-async.c:
(start_getting_top_lefts): Turn embedded text back on.
* libnautilus-extensions/nautilus-directory.c:
(nautilus_directory_get_metadata): Fixed a bug that was showing
up in "make check".
(nautilus_self_check_directory): Got rid of GNOME VFS tests,
since I moved the same tests into test-async-cancel in the
gnome-vfs module.
* check-FIXME.pl: Added -print as suggested by Morten Welinder
<terra@diku.dk>.
* check-config-h.pl: Added -print and fixed broken message as
suggested by Morten Welinder <terra@diku.dk>.
* libnautilus-extensions/nautilus-icon-factory.h:
* libnautilus-extensions/nautilus-icon-factory.c
(suffix_is_scalable): Simpler implementation.
(get_themed_icon_file_path): Look for size-specific version of
even .svg files. Although not so useful, it's not ridiculous to do so.
(nautilus_icon_factory_get_icon_for_file): Fixed the twisted logic to
be less twisted. Also changed the ".svg" extension check to use the
common function suffix_is_scalable.
(load_specific_image): Untwist logic here too, and note in the FIXME
that both the .svg library and gdk-pixbuf are limiting us to file:
URIs, although the gdk-pixbuf case is fixable without redoing the
library by just using our utility functions.
(load_image_for_scaling): Update for new size request structure which
contains maximum sizes as well as nominal ones.
(scale_image_and_rectangle), (revise_scale_factors_if_too_big),
(scale_image_down_if_too_big): New helper functions for scaling.
(load_image_scale_if_necessary): Take the maximum size into account.
(get_image_from_cache): Use new size request structure and take the
maximum size into account.
(nautilus_icon_factory_get_pixbuf_for_icon): Changed to take maximum
size parameters and pass them in to the underlying function.
(icon_cache_key_hash): Include the maximum size in the hash.
(icon_cache_key_equal): Check the maximum size too.
(nautilus_icon_factory_get_pixbuf_for_file): Pass new max. size
parameters to the nautilus_icon_factory_get_pixbuf_for_icon
function.
* libnautilus-extensions/nautilus-icon-container.c
(nautilus_icon_container_update_icon): Pass new max. size
parameters to the nautilus_icon_factory_get_pixbuf_for_icon
function.
* src/file-manager/fm-list-view.c
(fm_list_view_get_emblem_pixbufs_for_file): Pass new max. size
parameters to the nautilus_icon_factory_get_pixbuf_for_icon
function.
* check-FIXME.pl: Added the three desktop-drawing files
that aren't included in the build to the list of files
in which to ignore FIXMEs.
* nautilus-widgets/nautilus-caption-table.c,
* nautilus-widgets/nautilus-preferences-group.c,
* nautilus-widgets/nautilus-preferences.c,
* src/file-manager/dfos-xfer-progress-dialog.c,
* src/file-manager/dfos-xfer.c:
Wrote bug reports for all FIXMEs in these files. Down to
54 in Nautilus with no bug report.
bugs for the FIXME items but we were distracted into fixing bugs
and tweaking code that we found while doing so.
* check-FIXME.pl: Won't search old ChangeLogs for FIXMEs either;
changed FIXME format from "FIXME bug xxx" to "FIXME bugzilla.eazel.com xxx"
* components/history/ntl-history-view.c:
(hyperbola_navigation_history_notify_location_change): Moved bookmark
naming hack here and added FIXME explaining it.
* libnautilus-extensions/nautilus-bookmark.h,
* libnautilus-extensions/nautilus-bookmark.c:
(nautilus_bookmark_new), (nautilus_bookmark_new_with_name):
Combined these two into one routine that takes both the uri and
title; removed hack for trying to come up with good name for
bookmark here.
(nautilus_bookmark_get_pixmap_and_mask): Changed to call
_get_pixbuf instead of duplicating code.
(nautilus_bookmark_get_pixbuf): Changed interface to return
pixbuf or NULL instead of boolean result & "out" parameter.
* src/nautilus-bookmark-list.c,
* src/nautilus-bookmarks-window.c,
* src/nautilus-window-menus.c,
* src/ntl-window-msgs.c:
Updated callers of nautilus_bookmark_new and _new_with_name.
* check-FIXME.pl: This is a new Perl script for searching for FIXME
in the code. It reports any FIXME that does not have a bug number
next to it, or any with a bug number that's not an open bug.
* libnautilus/nautilus-bookmark.c: Attached a bug number to a FIXME
for script-testing purposes.
* docs/architecture.txt: Removed a FIXME. So sue me!
* src/file-manager/fm-icon-text-window.c
(create_attributes_option_menu): Added a call to gettext since the
attribute_labels are now N_ strings.
* po/.cvsignore: Ignore the generated files.
* libnautilus/nautilus-icon-factory.c: Formatting tweak.
