Most of the things in eel are already in glib, or are already easy
enough to have them directly in the code. So we should remove eel which
is just another layer of abstraction that we don't need as it makes
it hard to follow the code.
This patch replaces eel_show_error_dialog with show_error_dialog
to make it independent of eel.
https://bugzilla.gnome.org/show_bug.cgi?id=775092
Most of the things in eel are already in glib, or are already easy
enough to have them directly in the code. So we should remove eel which
is just another layer of abstraction that we don't need as it makes
it hard to follow the code.
This patch replaces eel_show_error_dialog with show_error_dialog
to make it independent of eel.
https://bugzilla.gnome.org/show_bug.cgi?id=775092
Most of the things in eel are already in glib, or are already easy
enough to have them directly in the code. So we should remove eel which
is just another layer of abstraction that we don't need as it makes
it hard to follow the code.
This patch adds function to show error dialog (show_error_dialog)
which is to be used in place of eel_show_error_dialog.
https://bugzilla.gnome.org/show_bug.cgi?id=775092
As some users or developers might choose to install repo builds, they
would also have to compile the installed GSettings schema manually. This
commit adds a script that does that post-install.
https://bugzilla.gnome.org/show_bug.cgi?id=779669
Some build servers don’t have git installed, which makes the tarball
build fail when trying to update the libgd submodule. This commit adds a
check for the existence of the root meson.build of libgd before running
git.
https://bugzilla.gnome.org/show_bug.cgi?id=779603
Currently, when skipping files, they are added to the transfer counts,
which results in inflated progress information. This commit makes the
code subtract from the total counts, instead.
https://bugzilla.gnome.org/show_bug.cgi?id=779569
When copying or moving a file, the file’s “skipped” status is not reset,
resulting in cases where the code starts skipping all files. In such
cases the progress popover will show the finished operation count higher
than the total amount of files.
https://bugzilla.gnome.org/show_bug.cgi?id=779569
Currently, the popover remains open if the file is deleted (can be
triggered by creating a file, opening the rename popover and undoing).
This commit makes the controller connect to the “changed” signal of the
target file and emits the “cancelled” signal if the file is gone.
https://bugzilla.gnome.org/show_bug.cgi?id=779568
Currently, when building with Meson, the version of the pkg-config file
for libnautilus-extension is set to the version of the library itself.
This is incompatible with how it was before - the version was set to the
version of Nautilus. That breaks some modules that build extensions
(e.g. file-roller).
https://bugzilla.gnome.org/show_bug.cgi?id=779472
With numbering added, the format mode stack child is slightly smaller
than the replace one, so the scrolled window height is slightly
changing when switching between modes.
The problem is that the row spacing in the replace stack child is
greater by 1px than the spacing in the format stack child.
To fix this make the replace stack child have the same row spacing.
https://bugzilla.gnome.org/show_bug.cgi?id=778272
Refreshing the desktop makes nautilus-desktop crash.
The cause of this crash is that the desktop canvas view is a floating
reference. In commit 5c414bfcd1 the creation
of the desktop view was changed and it was forgotten to sink the floating
ref.
To fix this, remove the floating reference. The reason why the ref sink
is needed here, as well as in all the other views, is because the views
are also managed as data structures.
https://bugzilla.gnome.org/show_bug.cgi?id=779321
run-uncrustify.sh script uses cwd relative file names, which fails
if it is ran from the repository root or other directory.
This commit fixes the paths relative to the script.
https://bugzilla.gnome.org/show_bug.cgi?id=779408
In previous versions of Nautilus, F2 used to switch between selecting
the whole filename and selecting the filename up to the extension. This
functionality has been lost in some version. This commit brings the
functionality back.
https://bugzilla.gnome.org/show_bug.cgi?id=774361
The width for the rename popover entry is set if the file is a regular
file, which does not include folders, resulting in a narrow entry,
despite the name being long. This commit makes the code set the width
regardless of the file type.
https://bugzilla.gnome.org/show_bug.cgi?id=774361
Since Continuous does not have GTK-Doc and jhbuild users don’t usually
care about generating documentation, it makes sense to disable it by
default.
https://bugzilla.gnome.org/show_bug.cgi?id=779420
We added a new enum value, but we didn't handled it on places where
we knew it couldn't be reached. However that spits out a warning with
gcc even if we handled it after the switch.
Fix that handling a "default" and returning a default value.
We know we have deprecations functions, and they require a major work
as porting to gtk4.
That's truly a different task to what we are doing every day, and the
multiple warnings obscure all real warnings to the task that is
relevant at that point.
This is making contributors skip the warnings, rather than actually look
at them.
For that, ignore deprecation warnings for now until someone wants to
work in the gtk4 port, and we also assume you read the documentation
when introducing new code in order to avoid deprecations.
Since testing is planned to be done with actual views and no one has
built Nautilus with the empty view enabled recently, it is safe to say
that it should go. This commit removes the empty view.
https://bugzilla.gnome.org/show_bug.cgi?id=779255
autoreconf takes care of running aclocal and other commands
in the right order.
Also, removing aclocal saves around 40 seconds (Thanks to
Ernestas Kulik for testing) when running autogen.sh
https://bugzilla.gnome.org/show_bug.cgi?id=779248
Currently, the default size for window is calculated by taking the
minimum value between the screen size and the hardcoded default. As
the smallest recommended screen size for GNOME today is 1024x600 and the
code has been added in 2000, it is likely no longer relevant. This
commit simply makes the code use the hardcoded values within the
recommended range as the default window size.
https://bugzilla.gnome.org/show_bug.cgi?id=779082
"Adwaita-dark" is supplied by gnome-themes-standard and has a distinct
name to theme GTK+ 2. For GTK+ 3, this theme just imports gtk-contained-
dark.css from the library, so it's _as if_ Adwaita was the system theme.
But Nautilus only applied its Adwaita-specific CSS if the system theme
name was exactly "Adwaita". So using "Adwaita-dark" meant we got Adwaita
but without Nautilus' additions to it, even though they are applicable.
Fix this by also loading Adwaita.css if the theme name is "Adwaita-dark"
https://bugzilla.gnome.org/show_bug.cgi?id=779266
