The notification is shown when all operations are completed and Nautilus doesn't
have a focus. It says that "All file operations have been successfully completed".
This is shown also when some errors were skipped. So the word "successfully"
is a bit misleading. Let's drop that word from the notification.
Relates: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1953
Instead of creating GtkListBoxRows directly, we can just create their
child widget and use GtkListBox::insert() method directly.
This prepares for GTK4, where GtkContainer is gone.
The functions for getting the width and height separately are gone
in GTK4. When not using them for height-for-width/width-for-height
measurements, they can be trivially replaced with get_preferred_size().
Rebased and ammended by António Fernandes <antoniof@gnome.org>
Implements Alan's proposed redesign for the rename dialog,
that also allows displaying longer file names.
Implements GNOME/nautilus#1986
Relates GNOME/nautilus#46
Regenerate the .ui file with Glade 3.38.2, without any actual changes.
This updates the syntax to use dashes instead of underscores, so that
future edits of the file don't have cluttered commit diffs due to these
automatic changes.
Same rationale as for Templates.
But, in this case, we don't have a cache ready to use.
So, keep a cache of the menu model in the private instance data.
No need for a GObject property in this case.
Also, remove scripts_present boolean, now that we can directly check
whether the scripts_menu is present (i.e., not NULL).
Menus are updated very frequently. Each time, we read the Templates
directory tree and recreate a menu model from which we generate the
New Document menu that's shared between the background context menu
and the current location menu in the pathbar.
This is wasteful and may cause noticeable UI lag if the Templates
directory has got a lot of files and subdirectories.
We already have a file monitor in place which notifies us when the
content of the Templates directory actually changes, so we can rely
on it to know when we need to read the directory again, and, in the
remaining situations, we can use the cached menu model.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1069
Relates to https://gitlab.gnome.org/GNOME/nautilus/-/issues/1705
If the templates dir is set to Home, then it should not be used.
We set the priv->templates_present boolean to FALSE in that case,
but forget to set the :templates-menu property to NULL too.
Fix that corner case issue. Also, drop the useless boolean and
just check directly whether the menu is present (i.e. not NULL).
The subtitle label is long and may be even longer in some locales.
As a result, a wide minimum width is forced on the whole window, which
is not desirable.
So, make it ellipsize and also add a tooltip.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2012
The positional argument was being silently ignored until meson 0.60.0 where
it fails with "ERROR: Function does not take positional arguments".
See: https://github.com/mesonbuild/meson/issues/9441
The "Apply this action to all files and folders" checkbox works only
with the "Replace" action, not the "Rename" action. Indeed, if the
rename field is expanded, the checkbox is greyed out.
However, if the checkbox is checked, when unchecking it changes the
main action to Rename, despite the rename field being obviously
hidden (otherwise the checkbox wouldn't be checked). That's wrong.
It's a regression from 15d59cd18d
When the checkbox is unchecked, the action is already "Replace", so
there is no need to change it.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1889
In case of extraction failure, the "Skip" and "Cancel" actions are offered
everytime, but skipping doesn't make sense when extracting one file only.
Let's use the same approach as it is used also for other operations, which
is based on total number of files and remaining files. Also the "Skip All"
action will be offered as a side-effect of this change.
Currently, output files are checked for existence. But the files are
explicitely deleted in the case of extraction failure, so this extra
check is no more needed. Let's drop the redundant check and just update
the list when deleting the files.
Empty, or corrupted files are left in the output directory in the case
of extraction failure, e.g. when wrong password is supplied. This is
in most cases undesired. Let's recursively delete all the leftover
files in the case of extraction failure.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1954
The fedora job was there before the flatpak job. But now we relies on
flatpak job and the fedora job doesn't really give much benefits. It is
rather waste of runners and maintainers time. Let's remove it.
The flatpak master job seems to be redundant currently. It uses the same
image as flatpak devel and their .yml files are equal. The two flatpak jobs
are relict from the times when GNOME SDK was unstable and broke CI often,
which is no more true. Let's remove the flatpak master job.
The style check job currently fails on stable branches since the recent
uncrustify change. We could use older image on stable, or backport the code
changes, but I think that the style check job on stable branches is not
actually needed. Let's disable the style check job on stable branches to
fix pipeline there and avoid this situation in the future.
Currently the keyboard focus for the type of archive choice is always on
the first element.
This patch allows the focus to be on the currently selected item instead.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1944
The flatpak build currently fails because of gexiv2 build failure, which is
a problem for our contributors and among others breaks our CI pipeline. The
potential fix is available already for a couple of days on
https://gitlab.gnome.org/GNOME/gexiv2/-/merge_requests/63 but not yet merged.
Let's temporarily pin the gexiv2 and exiv2 dependencies to the stable branches
to fix those issues.
