gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-10-02 14:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

list-view: Translate coordinates for underline on hover

Browse source 
gtk_tree_view_get_path_at_pos() requires bin_window coordinates, which
happened to be what the ::event coordinates were (because bin_window
was the event's GdkWindow).

However, with GtkEventControllerMotion we get widget coordinates. This
causes glytches with the underline.

Translating the coordinates fixes the regression.
This commit is contained in:
António Fernandes 2021-08-07 22:38:42 +01:00 committed by António Fernandes
parent a211f4abe0
commit f9e76ba42b
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/nautilus-list-view.c
View file

@ -327,6 +327,8 @@ on_event_controller_motion_motion (GtkEventControllerMotion *controller,
NautilusListView *view;
GtkWidget *widget;
GtkTreePath *old_hover_path;
int x_in_bin;
int y_in_bin;
if (get_click_policy () != NAUTILUS_CLICK_POLICY_SINGLE)
{
@ -337,8 +339,11 @@ on_event_controller_motion_motion (GtkEventControllerMotion *controller,
widget = gtk_event_controller_get_widget (GTK_EVENT_CONTROLLER (controller));
old_hover_path = view->details->hover_path;
gtk_tree_view_convert_widget_to_bin_window_coords (GTK_TREE_VIEW (widget),
x, y,
&x_in_bin, &y_in_bin);
gtk_tree_view_get_path_at_pos (GTK_TREE_VIEW (widget),
x, y,
x_in_bin, y_in_bin,
&view->details->hover_path,
NULL, NULL, NULL);
@ -386,6 +391,8 @@ on_event_controller_motion_enter (GtkEventControllerMotion *controller,
{
NautilusListView *view;
GtkWidget *widget;
int x_in_bin;
int y_in_bin;
if (get_click_policy () != NAUTILUS_CLICK_POLICY_SINGLE)
{
@ -399,8 +406,11 @@ on_event_controller_motion_enter (GtkEventControllerMotion *controller,
}
widget = gtk_event_controller_get_widget (GTK_EVENT_CONTROLLER (controller));
gtk_tree_view_convert_widget_to_bin_window_coords (GTK_TREE_VIEW (widget),
x, y,
&x_in_bin, &y_in_bin);
gtk_tree_view_get_path_at_pos (GTK_TREE_VIEW (widget),
x, y,
x_in_bin, y_in_bin,
&view->details->hover_path,
NULL, NULL, NULL);