gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-10-02 22:13:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

pathbar: Drop gtk_widget_{g,s}et_clip()

Browse source 
It's gone in GTK4 and removing this doesn't seem to cause any visual or
behavorial change at the moment.

Originally it was a workaround to some visual problem with button
shadows. Our pathbar buttons don't have shadows nowadays, and even if
testing with added shadows, there is no apparent issue nowadays.

Rebased and ammended by António Fernandes <antoniof@gnome.org>
This commit is contained in:
Ernestas Kulik 2018-07-11 13:33:14 +03:00 committed by Ondrej Holy
parent c56ccce791
commit f717ec01ab
1 changed files with 0 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/nautilus-pathbar.c
View file

@ -457,37 +457,6 @@ nautilus_path_bar_map (GtkWidget *widget)
GTK_WIDGET_CLASS (nautilus_path_bar_parent_class)->map (widget);
}
#define BUTTON_BOTTOM_SHADOW 1
static void
union_with_clip (GtkWidget *widget,
gpointer clip)
{
GtkAllocation widget_clip;
if (!gtk_widget_is_drawable (widget))
{
return;
}
gtk_widget_get_clip (widget, &widget_clip);
gdk_rectangle_union (&widget_clip, clip, clip);
}
static void
_set_simple_bottom_clip (GtkWidget *widget,
gint pixels)
{
GtkAllocation clip;
gtk_widget_get_allocation (widget, &clip);
clip.height += pixels;
gtk_container_forall (GTK_CONTAINER (widget), union_with_clip, &clip);
gtk_widget_set_clip (widget, &clip);
}
/* This is a tad complicated */
static void
nautilus_path_bar_size_allocate (GtkWidget *widget,
@ -516,7 +485,6 @@ nautilus_path_bar_size_allocate (GtkWidget *widget,
/* No path is set so we don't have to allocate anything. */
if (self->button_list == NULL)
{
_set_simple_bottom_clip (widget, BUTTON_BOTTOM_SHADOW);
return;
}
direction = gtk_widget_get_direction (widget);
@ -637,8 +605,6 @@ nautilus_path_bar_size_allocate (GtkWidget *widget,
child = BUTTON_DATA (list->data)->button;
gtk_widget_set_child_visible (child, FALSE);
}
_set_simple_bottom_clip (widget, BUTTON_BOTTOM_SHADOW);
}
static void