gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-06-30 23:46:35 +00:00
Code Issues Projects Releases Wiki Activity

window-slot: Stop ignoring NOT_SUPPORTED errors

Browse Source 
We use some application-internal URIs without a corresponging GVFS
backend. If we let NautilusVfsFile handle the file info requests when
loading these locations, we get a G_IO_ERROR_NOT_SUPPORTED error, as
should be expected.

Nowadays, none of our internal URI schemes go through NautilusVfsFile:

  * `x-nautilus-search://*/` URIs lead to the creation of instances of
    the `NautilusSearchDirectoryFile` subclass;
  * `x-network-view:///` and `starred:/// lead to the creation of
    instances of the `NautilusInternalPlaceFile` subclass.

This means that `call_when_ready()` requests for these files do not ask
for a GVFS to handle unsupported URI schemes. So, we no longer get a
G_IO_NOT_SUPPORTED error when getting info on these locations.

As such, let's no longer ignore such errors.
This commit is contained in:
António Fernandes 2024-06-15 12:56:52 +01:00
parent 4db38919c2
commit f5cacef579
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/nautilus-window-slot.c
View File

@ -1959,9 +1959,7 @@ got_file_info_for_view_selection_callback (NautilusFile *file,
location = self->pending_location;
/* desktop and other-locations GFile operations report G_IO_ERROR_NOT_SUPPORTED,
* but it's not an actual error for Nautilus */
if (!error || g_error_matches (error, G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED))
if (error == NULL)
{
view = nautilus_window_slot_get_view_for_location (self, location);
setup_view (self, view);