gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-09-13 04:51:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

name-cell: Improve subfolder loading indication

Browse source 
Reduce the timeout from 1 s to 200 ms and move the spinner after the
name, not to move things around.
This commit is contained in:
António Fernandes 2024-01-14 16:38:08 +00:00
parent 36fec089ec
commit d1d482a490
2 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/nautilus-name-cell.c
View file

@ -10,7 +10,7 @@
#include "nautilus-file-utilities.h"
#include "nautilus-thumbnails.h"
#define LOADING_TIMEOUT_SECONDS 1
#define SPINNER_DELAY_MS 200
struct _NautilusNameCell
{
@ -273,7 +273,7 @@ on_item_is_cut_changed (NautilusNameCell *self)
}
}
static gboolean
static void
on_loading_timeout (gpointer user_data)
{
NautilusNameCell *self = NAUTILUS_NAME_CELL (user_data);
@ -287,8 +287,6 @@ on_loading_timeout (gpointer user_data)
gtk_widget_set_visible (self->spinner, TRUE);
gtk_spinner_start (GTK_SPINNER (self->spinner));
}
return G_SOURCE_REMOVE;
}
static void
@ -301,9 +299,9 @@ on_item_is_loading_changed (NautilusNameCell *self)
if (is_loading)
{
self->loading_timeout_id = g_timeout_add_seconds (LOADING_TIMEOUT_SECONDS,
G_SOURCE_FUNC (on_loading_timeout),
self);
self->loading_timeout_id = g_timeout_add_once (SPINNER_DELAY_MS,
on_loading_timeout,
self);
}
else
{

16
src/resources/ui/nautilus-name-cell.ui
View file

@ -19,14 +19,6 @@
<property name="orientation">horizontal</property>
<property name="halign">fill</property>
<property name="valign">center</property>
<child>
<object class="GtkSpinner" id="spinner">
<property name="visible">False</property>
<property name="spinning">False</property>
<property name="halign">center</property>
<property name="valign">center</property>
</object>
</child>
<child>
<object class="GtkBox" id="fixed_height_box">
<property name="orientation">vertical</property>
@ -85,6 +77,14 @@
<property name="spacing">6</property>
</object>
</child>
<child>
<object class="GtkSpinner" id="spinner">
<property name="visible">False</property>
<property name="spinning">False</property>
<property name="halign">center</property>
<property name="valign">center</property>
</object>
</child>
</object>
</child>
<child>