gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-11-05 16:04:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

Added more bug numbers to FIXMEs. 166 to go.

Browse source 
* libnautilus-extensions/nautilus-search-bar-criterion.c:
	(nautilus_search_bar_criterion_destroy), (get_size_location_for),
	(get_emblem_location_for):
	* libnautilus-extensions/nautilus-search-uri.c:
	* libnautilus-extensions/nautilus-stock-dialogs.c:
	(timed_wait_callback):
	* libnautilus-extensions/nautilus-string-map.c:
	* libnautilus-extensions/nautilus-trash-directory.c:
	(get_volume_vfs_uri_if_writable):
	* libnautilus-extensions/nautilus-volume-monitor.c:
	(mount_volume_mount), (eject_cdrom), (mount_volume_floppy_add),
	(mount_volume_add_aliases), (mntent_is_removable_fs),
	(find_volumes), (nautilus_volume_monitor_mount_unmount_removable):
This commit is contained in:
John Sullivan 2000-08-28 20:44:34 +00:00
parent a54ce64495
commit d06e8b95d7
13 changed files with 82 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
ChangeLog
View file

@ -1,3 +1,21 @@
2000-08-28 John Sullivan <sullivan@eazel.com>
Added more bug numbers to FIXMEs. 166 to go.
* libnautilus-extensions/nautilus-search-bar-criterion.c:
(nautilus_search_bar_criterion_destroy), (get_size_location_for),
(get_emblem_location_for):
* libnautilus-extensions/nautilus-search-uri.c:
* libnautilus-extensions/nautilus-stock-dialogs.c:
(timed_wait_callback):
* libnautilus-extensions/nautilus-string-map.c:
* libnautilus-extensions/nautilus-trash-directory.c:
(get_volume_vfs_uri_if_writable):
* libnautilus-extensions/nautilus-volume-monitor.c:
(mount_volume_mount), (eject_cdrom), (mount_volume_floppy_add),
(mount_volume_add_aliases), (mntent_is_removable_fs),
(find_volumes), (nautilus_volume_monitor_mount_unmount_removable):
2000-08-28 Pavel Cisler <pavel@eazel.com>
* libnautilus-extensions/nautilus-file.c:

8
libnautilus-extensions/nautilus-search-bar-criterion.c
View file

@ -104,7 +104,7 @@ static char *emblem_relations [] = {
};
static char *emblem_objects [] = {
/* FIXME: add emblem possibilities here.
/* FIXME bugzilla.eazel.com 2369: add emblem possibilities here.
likely to be icon filenames
*/
NULL
@ -163,7 +163,7 @@ static char * get_owner_location_for
void
nautilus_search_bar_criterion_destroy (NautilusSearchBarCriterion *criterion)
{
/* FIXME : need more freeage */
/* FIXME bugzilla.eazel.com 2437: need more freeage */
g_free (criterion->details);
g_free (criterion);
}
@ -609,7 +609,7 @@ get_size_location_for (int relation_number,
/* We put a 'K' after the size, so multiply what the user
entered by 1000 */
entered_size = strtol (size_text, NULL, 10);
/* FIXME: Need error handling here */
/* FIXME bugzilla.eazel.com 2438: Need error handling here */
g_return_val_if_fail (entered_size >= 0, NULL);
return g_strdup_printf ("%s %s %d", NAUTILUS_SEARCH_URI_TEXT_SIZE,
possible_relations[relation_number],
@ -621,7 +621,7 @@ static char *
get_emblem_location_for (int relation_number,
int value_number)
{
/* FIXME: not yet implemented */
/* FIXME bugzilla.eazel.com 2369: not yet implemented */
return g_strdup_printf ("%s ", NAUTILUS_SEARCH_URI_TEXT_EMBLEMS);
}

12
libnautilus-extensions/nautilus-search-uri.c
View file

@ -308,7 +308,7 @@ static operand_criterion_item mod_time2_table [] = {
-------------------------------------------------------
*/
/* FIXME: not implemented in nautilus yet */
/* FIXME bugzilla.eazel.com 2369: not implemented in nautilus yet */
static operand_criterion_item emblem2_table [] = {
{NULL, NULL, NULL}
};
@ -319,7 +319,7 @@ static operand_criterion_item emblem2_table [] = {
-------------------------------------------------------
*/
/* FIXME: I cannot find any doc on this one */
/* FIXME bugzilla.eazel.com 2439: I cannot find any doc on this one */
static operand_criterion_item contains2_table [] = {
{"includes",
N_("with the word"),
@ -350,15 +350,15 @@ static field_criterion_item main_table[] = {
{"size",
N_(""),
size2_table},
/* FIXME: waiting for doc */
/* FIXME bugzilla.eazel.com 2439: waiting for doc */
{"contains",
N_(""),
contains2_table},
/* FIXME: waiting for spec */
/* FIXME bugzilla.eazel.com 2439: waiting for spec */
{"mod_time",
N_(""),
mod_time2_table},
/* FIXME: waiting for implementation */
/* FIXME bugzilla.eazel.com 2369: waiting for implementation */
{"emblem",
N_(""),
emblem2_table},
@ -473,7 +473,7 @@ get_translated_criterion (const GSList *criterion)
* @criterion: The GSList whose data field points to the criterion GSList.
*
* calculates the "whose", "who" or "which" prefix for a given criterion.
* FIXME: it is an ugly hack I added after arlo asked me to:
* FIXME bugzilla.eazel.com 2440: it is an ugly hack I added after arlo asked me to:
* it is likely to be a pain for translations. I need to modify the data struct
* for this to work cleanly.
*

3
libnautilus-extensions/nautilus-stock-dialogs.c
View file

@ -153,7 +153,8 @@ timed_wait_callback (gpointer callback_data)
gnome_dialog_set_close (dialog, TRUE);
gtk_widget_show_all (GTK_WIDGET (dialog));
/* FIXME: Could parent here, but it's complicated because we
/* FIXME bugzilla.eazel.com 2441:
* Could parent here, but it's complicated because we
* don't want this window to go away just because the parent
* would go away first.
*/

3
libnautilus-extensions/nautilus-string-map.c
View file

@ -31,7 +31,8 @@
#include "nautilus-lib-self-check-functions.h"
#include <string.h>
/* FIXME: The case sensitive flag is not functional yet. Need to change
/* FIXME bugzilla.eazel.com 2442:
* The case sensitive flag is not functional yet. Need to change
* NautilusStringList to also accept a case_sensitive flag to make it work.
*/

11
libnautilus-extensions/nautilus-trash-directory.c
View file

@ -59,9 +59,14 @@ get_volume_vfs_uri_if_writable (NautilusVolume *volume)
char *uri;
GnomeVFSURI *vfs_uri;
/* FIXME: Why is trash only found on EXT2 volumes? This seems
* like an incorrect check. Also, why can't we view the trash
* on a read-only volume if it happens to be there?
/* FIXME bugzilla.eazel.com 2443:
* Why is trash only found on EXT2 volumes? This seems
* like an incorrect check.
*/
/* FIXME bugzilla.eazel.com 2444:
* Why can't we view the trash on a read-only volume
* if it happens to be there?
*/
if (volume->type != NAUTILUS_VOLUME_EXT2 || volume->is_read_only) {
return NULL;

18
libnautilus-extensions/nautilus-volume-monitor.c
View file

@ -361,7 +361,7 @@ mount_volume_mount (NautilusVolumeMonitor *view, NautilusVolume *volume)
* them to something that's suitable for use in the name of a
* link on the desktop.
*/
/* FIXME: Move to desktop code? */
/* FIXME bugzilla.eazel.com 2445: Move to desktop code? */
for (index = 0; ; index++) {
if (volume->volume_name [index] == '\0') {
break;
@ -450,7 +450,7 @@ mount_volume_activate (NautilusVolumeMonitor *monitor, NautilusVolume *volume)
static void
eject_cdrom (NautilusVolume *volume)
{
/* FIXME: We need to turn on this code, or get rid of it. */
/* FIXME bugzilla.eazel.com 2446: We need to turn on this code, or get rid of it. */
#if 0
int fd;
@ -610,7 +610,7 @@ mount_volume_floppy_add (NautilusVolumeMonitor *monitor, NautilusVolume *volume)
volume->type = NAUTILUS_VOLUME_FLOPPY;
return TRUE;
/* FIXME: Is this code needed or not? */
/* FIXME bugzilla.eazel.com 2447: Is this code needed or not? */
#if 0
if (check_permissions (volume->fsname, R_OK)) {
return FALSE;
@ -683,7 +683,7 @@ mount_volume_add_aliases (NautilusVolumeMonitor *monitor, const char *alias, Nau
if (buf[0] == '/') {
path = g_strdup (buf);
} else {
/* FIXME: This doesn't work well for paths with ".." in them. */
/* FIXME bugzilla.eazel.com 2449: This doesn't work well for paths with ".." in them. */
directory_path = g_dirname (alias);
path = g_strconcat (directory_path,
"/",
@ -729,11 +729,13 @@ add_mount_volume (NautilusVolumeMonitor *monitor, struct mntent *ent)
static gboolean
mntent_is_removable_fs (struct mntent *ent)
{
/* FIXME: this does not detect removable volumes that are not
/* FIXME bugzilla.eazel.com 2450:
this does not detect removable volumes that are not
CDs or floppies (e.g. zip drives, DVD-ROMs, those weird 20M
super floppies, etc) */
/* FIXME: it's incorrect to assume that all ISO9660 volumes
/* FIXME bugzilla.eazel.com 2451:
it's incorrect to assume that all ISO9660 volumes
are removable; you could create one as a "filesystem in a
file" for testing purposes. */
@ -782,7 +784,7 @@ find_volumes (NautilusVolumeMonitor *monitor)
while ((ent = getmntent (mef)) != NULL) {
#if 0
/* FIXME: Think some more about these checks */
/* FIXME bugzilla.eazel.com 2452: Think some more about these checks */
/* Check for removable volume */
if (!mntent_is_removable_fs (ent)) {
continue;
@ -877,7 +879,7 @@ nautilus_volume_monitor_mount_unmount_removable (NautilusVolumeMonitor *monitor,
argv[2] = NULL;
exec_err = gnome_execute_async (g_get_home_dir(), 2, argv);
/* FIXME: Ignore error? */
/* FIXME bugzilla.eazel.com 2453: Ignore error? */
is_mounted = !is_mounted;
}

8
libnautilus-private/nautilus-search-bar-criterion.c
View file

@ -104,7 +104,7 @@ static char *emblem_relations [] = {
};
static char *emblem_objects [] = {
/* FIXME: add emblem possibilities here.
/* FIXME bugzilla.eazel.com 2369: add emblem possibilities here.
likely to be icon filenames
*/
NULL
@ -163,7 +163,7 @@ static char * get_owner_location_for
void
nautilus_search_bar_criterion_destroy (NautilusSearchBarCriterion *criterion)
{
/* FIXME : need more freeage */
/* FIXME bugzilla.eazel.com 2437: need more freeage */
g_free (criterion->details);
g_free (criterion);
}
@ -609,7 +609,7 @@ get_size_location_for (int relation_number,
/* We put a 'K' after the size, so multiply what the user
entered by 1000 */
entered_size = strtol (size_text, NULL, 10);
/* FIXME: Need error handling here */
/* FIXME bugzilla.eazel.com 2438: Need error handling here */
g_return_val_if_fail (entered_size >= 0, NULL);
return g_strdup_printf ("%s %s %d", NAUTILUS_SEARCH_URI_TEXT_SIZE,
possible_relations[relation_number],
@ -621,7 +621,7 @@ static char *
get_emblem_location_for (int relation_number,
int value_number)
{
/* FIXME: not yet implemented */
/* FIXME bugzilla.eazel.com 2369: not yet implemented */
return g_strdup_printf ("%s ", NAUTILUS_SEARCH_URI_TEXT_EMBLEMS);
}

12
libnautilus-private/nautilus-search-uri.c
View file

@ -308,7 +308,7 @@ static operand_criterion_item mod_time2_table [] = {
-------------------------------------------------------
*/
/* FIXME: not implemented in nautilus yet */
/* FIXME bugzilla.eazel.com 2369: not implemented in nautilus yet */
static operand_criterion_item emblem2_table [] = {
{NULL, NULL, NULL}
};
@ -319,7 +319,7 @@ static operand_criterion_item emblem2_table [] = {
-------------------------------------------------------
*/
/* FIXME: I cannot find any doc on this one */
/* FIXME bugzilla.eazel.com 2439: I cannot find any doc on this one */
static operand_criterion_item contains2_table [] = {
{"includes",
N_("with the word"),
@ -350,15 +350,15 @@ static field_criterion_item main_table[] = {
{"size",
N_(""),
size2_table},
/* FIXME: waiting for doc */
/* FIXME bugzilla.eazel.com 2439: waiting for doc */
{"contains",
N_(""),
contains2_table},
/* FIXME: waiting for spec */
/* FIXME bugzilla.eazel.com 2439: waiting for spec */
{"mod_time",
N_(""),
mod_time2_table},
/* FIXME: waiting for implementation */
/* FIXME bugzilla.eazel.com 2369: waiting for implementation */
{"emblem",
N_(""),
emblem2_table},
@ -473,7 +473,7 @@ get_translated_criterion (const GSList *criterion)
* @criterion: The GSList whose data field points to the criterion GSList.
*
* calculates the "whose", "who" or "which" prefix for a given criterion.
* FIXME: it is an ugly hack I added after arlo asked me to:
* FIXME bugzilla.eazel.com 2440: it is an ugly hack I added after arlo asked me to:
* it is likely to be a pain for translations. I need to modify the data struct
* for this to work cleanly.
*

3
libnautilus-private/nautilus-stock-dialogs.c
View file

@ -153,7 +153,8 @@ timed_wait_callback (gpointer callback_data)
gnome_dialog_set_close (dialog, TRUE);
gtk_widget_show_all (GTK_WIDGET (dialog));
/* FIXME: Could parent here, but it's complicated because we
/* FIXME bugzilla.eazel.com 2441:
* Could parent here, but it's complicated because we
* don't want this window to go away just because the parent
* would go away first.
*/

3
libnautilus-private/nautilus-string-map.c
View file

@ -31,7 +31,8 @@
#include "nautilus-lib-self-check-functions.h"
#include <string.h>
/* FIXME: The case sensitive flag is not functional yet. Need to change
/* FIXME bugzilla.eazel.com 2442:
* The case sensitive flag is not functional yet. Need to change
* NautilusStringList to also accept a case_sensitive flag to make it work.
*/

11
libnautilus-private/nautilus-trash-directory.c
View file

@ -59,9 +59,14 @@ get_volume_vfs_uri_if_writable (NautilusVolume *volume)
char *uri;
GnomeVFSURI *vfs_uri;
/* FIXME: Why is trash only found on EXT2 volumes? This seems
* like an incorrect check. Also, why can't we view the trash
* on a read-only volume if it happens to be there?
/* FIXME bugzilla.eazel.com 2443:
* Why is trash only found on EXT2 volumes? This seems
* like an incorrect check.
*/
/* FIXME bugzilla.eazel.com 2444:
* Why can't we view the trash on a read-only volume
* if it happens to be there?
*/
if (volume->type != NAUTILUS_VOLUME_EXT2 || volume->is_read_only) {
return NULL;

18
libnautilus-private/nautilus-volume-monitor.c
View file

@ -361,7 +361,7 @@ mount_volume_mount (NautilusVolumeMonitor *view, NautilusVolume *volume)
* them to something that's suitable for use in the name of a
* link on the desktop.
*/
/* FIXME: Move to desktop code? */
/* FIXME bugzilla.eazel.com 2445: Move to desktop code? */
for (index = 0; ; index++) {
if (volume->volume_name [index] == '\0') {
break;
@ -450,7 +450,7 @@ mount_volume_activate (NautilusVolumeMonitor *monitor, NautilusVolume *volume)
static void
eject_cdrom (NautilusVolume *volume)
{
/* FIXME: We need to turn on this code, or get rid of it. */
/* FIXME bugzilla.eazel.com 2446: We need to turn on this code, or get rid of it. */
#if 0
int fd;
@ -610,7 +610,7 @@ mount_volume_floppy_add (NautilusVolumeMonitor *monitor, NautilusVolume *volume)
volume->type = NAUTILUS_VOLUME_FLOPPY;
return TRUE;
/* FIXME: Is this code needed or not? */
/* FIXME bugzilla.eazel.com 2447: Is this code needed or not? */
#if 0
if (check_permissions (volume->fsname, R_OK)) {
return FALSE;
@ -683,7 +683,7 @@ mount_volume_add_aliases (NautilusVolumeMonitor *monitor, const char *alias, Nau
if (buf[0] == '/') {
path = g_strdup (buf);
} else {
/* FIXME: This doesn't work well for paths with ".." in them. */
/* FIXME bugzilla.eazel.com 2449: This doesn't work well for paths with ".." in them. */
directory_path = g_dirname (alias);
path = g_strconcat (directory_path,
"/",
@ -729,11 +729,13 @@ add_mount_volume (NautilusVolumeMonitor *monitor, struct mntent *ent)
static gboolean
mntent_is_removable_fs (struct mntent *ent)
{
/* FIXME: this does not detect removable volumes that are not
/* FIXME bugzilla.eazel.com 2450:
this does not detect removable volumes that are not
CDs or floppies (e.g. zip drives, DVD-ROMs, those weird 20M
super floppies, etc) */
/* FIXME: it's incorrect to assume that all ISO9660 volumes
/* FIXME bugzilla.eazel.com 2451:
it's incorrect to assume that all ISO9660 volumes
are removable; you could create one as a "filesystem in a
file" for testing purposes. */
@ -782,7 +784,7 @@ find_volumes (NautilusVolumeMonitor *monitor)
while ((ent = getmntent (mef)) != NULL) {
#if 0
/* FIXME: Think some more about these checks */
/* FIXME bugzilla.eazel.com 2452: Think some more about these checks */
/* Check for removable volume */
if (!mntent_is_removable_fs (ent)) {
continue;
@ -877,7 +879,7 @@ nautilus_volume_monitor_mount_unmount_removable (NautilusVolumeMonitor *monitor,
argv[2] = NULL;
exec_err = gnome_execute_async (g_get_home_dir(), 2, argv);
/* FIXME: Ignore error? */
/* FIXME bugzilla.eazel.com 2453: Ignore error? */
is_mounted = !is_mounted;
}