gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-11-04 19:08:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

general: Remove thumbnail frame

Browse source 
Shadows are present in design mockups, frame is not.

In GTK 4 we are going to be able to draw shadows in the new views using
CSS, which is going to be much better than transforming pixbufs.

Furthermore, this removes another use of libgd, which we want to stop
depending on as part of the GTK 3-to-4 migration.
This commit is contained in:
António Fernandes 2021-11-02 21:57:50 +00:00
parent 8cf4113d70
commit b6ec43aaf0
5 changed files with 0 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
icons/thumbnail_frame.png
View file

Binary file not shown.
Side by side

Before

Width:  |  Height:  |  Size: 482 B

4
src/nautilus-file.c
View file

@ -5261,10 +5261,6 @@ nautilus_file_get_thumbnail_icon (NautilusFile *file,
{
nautilus_ui_frame_video (&pixbuf);
}
else
{
nautilus_ui_frame_image (&pixbuf);
}
}
}

25
src/nautilus-ui-utilities.c
View file

@ -28,7 +28,6 @@
#include <gio/gio.h>
#include <gtk/gtk.h>
#include <libgd/gd.h>
#include <string.h>
#include <glib/gi18n.h>
@ -68,30 +67,6 @@ nautilus_gmenu_set_from_model (GMenu *target_menu,
}
}
#define NAUTILUS_THUMBNAIL_FRAME_LEFT 3
#define NAUTILUS_THUMBNAIL_FRAME_TOP 3
#define NAUTILUS_THUMBNAIL_FRAME_RIGHT 3
#define NAUTILUS_THUMBNAIL_FRAME_BOTTOM 3
void
nautilus_ui_frame_image (GdkPixbuf **pixbuf)
{
GtkBorder border;
GdkPixbuf *pixbuf_with_frame;
border.left = NAUTILUS_THUMBNAIL_FRAME_LEFT;
border.top = NAUTILUS_THUMBNAIL_FRAME_TOP;
border.right = NAUTILUS_THUMBNAIL_FRAME_RIGHT;
border.bottom = NAUTILUS_THUMBNAIL_FRAME_BOTTOM;
pixbuf_with_frame = gd_embed_image_in_frame (*pixbuf,
"resource:///org/gnome/nautilus/icons/thumbnail_frame.png",
&border, &border);
g_object_unref (*pixbuf);
*pixbuf = pixbuf_with_frame;
}
static GdkPixbuf *filmholes_left = NULL;
static GdkPixbuf *filmholes_right = NULL;

1
src/nautilus-ui-utilities.h
View file

@ -28,7 +28,6 @@
void nautilus_gmenu_set_from_model (GMenu *target_menu,
GMenuModel *source_model);
void nautilus_ui_frame_image (GdkPixbuf **pixbuf);
void nautilus_ui_frame_video (GdkPixbuf **pixbuf);
gboolean nautilus_file_date_in_between (guint64 file_unix_time,

1
src/resources/nautilus.gresource.xml
View file

@ -28,7 +28,6 @@
<file>ui/nautilus-operations-ui-manager-request-passphrase.ui</file>
<file alias="gtk/ui/nautilusgtkplacesview.ui">../gtk/nautilusgtkplacesview.ui</file>
<file alias="gtk/ui/nautilusgtkplacesviewrow.ui">../gtk/nautilusgtkplacesviewrow.ui</file>
<file alias="icons/thumbnail_frame.png">../../icons/thumbnail_frame.png</file>
<file alias="icons/filmholes.png">../../icons/filmholes.png</file>
<file>css/Adwaita.css</file>
<file>css/nautilus.css</file>