mirror of
https://gitlab.gnome.org/GNOME/nautilus
synced 2024-11-05 16:04:31 +00:00
Added more bug numbers to FIXMEs. 94 to go.
* libnautilus-extensions/nautilus-icon-canvas-item.c: (map_pixbuf), (draw_label_text_aa), (nautilus_icon_canvas_item_event): * libnautilus-extensions/nautilus-icon-container.c: (icon_free), (get_all_icon_bounds), (lay_down_icons_tblr), (lay_down_icons), (nautilus_icon_container_move_icon), (stop_rubberbanding), (destroy), (hide_rename_widget): * libnautilus-extensions/nautilus-icon-dnd.c: (nautilus_icon_container_dropped_icon_feedback), (receive_dropped_keyword), (auto_scroll_timeout_callback), (nautilus_icon_container_find_drop_target), (nautilus_icon_dnd_update_drop_target), (nautilus_icon_dnd_fini): * libnautilus-extensions/nautilus-link-set.c: (link_set_path_name), (expand_uri): * libnautilus-extensions/nautilus-link.c: (nautilus_link_get_root_property), (nautilus_link_get_additional_text), (make_local_path), (nautilus_link_get_image_uri), (nautilus_link_get_link_uri), (nautilus_link_get_link_type): * src/nautilus-sidebar-title.c: (nautilus_sidebar_title_select_text_color), (update_font), (update_title), (update_more_info), (update_emblems), (update_notes):
This commit is contained in:
John Sullivan
parent
c2d0d23c0c
commit
8bc0bad71c
12 changed files with 124 additions and 69 deletions
27
ChangeLog
27
ChangeLog
|
|
@ -1,3 +1,30 @@
|
|||
2000-08-28 John Sullivan <sullivan@eazel.com>
|
||||
|
||||
Added more bug numbers to FIXMEs. 94 to go.
|
||||
|
||||
* libnautilus-extensions/nautilus-icon-canvas-item.c: (map_pixbuf),
|
||||
(draw_label_text_aa), (nautilus_icon_canvas_item_event):
|
||||
* libnautilus-extensions/nautilus-icon-container.c: (icon_free),
|
||||
(get_all_icon_bounds), (lay_down_icons_tblr), (lay_down_icons),
|
||||
(nautilus_icon_container_move_icon), (stop_rubberbanding),
|
||||
(destroy), (hide_rename_widget):
|
||||
* libnautilus-extensions/nautilus-icon-dnd.c:
|
||||
(nautilus_icon_container_dropped_icon_feedback),
|
||||
(receive_dropped_keyword), (auto_scroll_timeout_callback),
|
||||
(nautilus_icon_container_find_drop_target),
|
||||
(nautilus_icon_dnd_update_drop_target), (nautilus_icon_dnd_fini):
|
||||
* libnautilus-extensions/nautilus-link-set.c: (link_set_path_name),
|
||||
(expand_uri):
|
||||
* libnautilus-extensions/nautilus-link.c:
|
||||
(nautilus_link_get_root_property),
|
||||
(nautilus_link_get_additional_text), (make_local_path),
|
||||
(nautilus_link_get_image_uri), (nautilus_link_get_link_uri),
|
||||
(nautilus_link_get_link_type):
|
||||
* src/nautilus-sidebar-title.c:
|
||||
(nautilus_sidebar_title_select_text_color), (update_font),
|
||||
(update_title), (update_more_info), (update_emblems),
|
||||
(update_notes):
|
||||
|
||||
2000-08-28 Michael Engber <engber@eazel.com>
|
||||
|
||||
The three zooming related items no longer appear in
|
||||
|
|
|
|||
|
|
@ -1082,7 +1082,7 @@ map_pixbuf (NautilusIconCanvasItem *icon_item)
|
|||
if (icon_item->details->is_prelit) {
|
||||
temp_pixbuf = nautilus_create_spotlight_pixbuf (icon_item->details->pixbuf);
|
||||
|
||||
/* FIXME: This hard-wired image is inappropriate to
|
||||
/* FIXME bugzilla.eazel.com 2471: This hard-wired image is inappropriate to
|
||||
* this level of code, which shouldn't know that the
|
||||
* preview is audio, nor should it have an icon
|
||||
* hard-wired in.
|
||||
|
|
@ -1204,7 +1204,8 @@ draw_label_text_aa (NautilusIconCanvasItem *icon_item, GnomeCanvasBuf *buf, doub
|
|||
}
|
||||
|
||||
if (icon_item->details->is_renaming) {
|
||||
/* FIXME: Why is it OK to leave text_height and
|
||||
/* FIXME bugzilla.eazel.com 2472:
|
||||
* Why is it OK to leave text_height and
|
||||
* text_width alone in this code path?
|
||||
*/
|
||||
return;
|
||||
|
|
@ -1339,7 +1340,8 @@ nautilus_icon_canvas_item_event (GnomeCanvasItem *item, GdkEvent *event)
|
|||
if (!icon_item->details->is_prelit) {
|
||||
icon_item->details->is_prelit = TRUE;
|
||||
gnome_canvas_item_request_update (item);
|
||||
/* FIXME: We should emit our own signal here,
|
||||
/* FIXME bugzilla.eazel.com 2473:
|
||||
* We should emit our own signal here,
|
||||
* not one from the container; it could hook
|
||||
* up to that signal and emit one of its
|
||||
* own. Doing it this way hard-codes what
|
||||
|
|
@ -1361,7 +1363,8 @@ nautilus_icon_canvas_item_event (GnomeCanvasItem *item, GdkEvent *event)
|
|||
* higlighted for drop. The latter gets turned on
|
||||
* by the drag&drop motion callback.
|
||||
*/
|
||||
/* FIXME: We should emit our own signal here,
|
||||
/* FIXME bugzilla.eazel.com 2473:
|
||||
* We should emit our own signal here,
|
||||
* not one from the containe; it could hook up
|
||||
* to that signal and emit one of its
|
||||
* ownr. Doing it this way hard-codes what
|
||||
|
|
|
|||
|
|
@ -162,7 +162,7 @@ static char stipple_bits[] = { 0x02, 0x01 };
|
|||
static void
|
||||
icon_free (NautilusIcon *icon)
|
||||
{
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2481: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (icon->item));
|
||||
g_free (icon);
|
||||
}
|
||||
|
|
@ -461,7 +461,7 @@ get_all_icon_bounds (NautilusIconContainer *container,
|
|||
double *x1, double *y1,
|
||||
double *x2, double *y2)
|
||||
{
|
||||
/* FIXME: Do we have to do something about the rubberband
|
||||
/* FIXME bugzilla.eazel.com 2477: Do we have to do something about the rubberband
|
||||
* here? Any other non-icon items?
|
||||
*/
|
||||
gnome_canvas_item_get_bounds
|
||||
|
|
@ -921,7 +921,8 @@ lay_down_icons_tblr (NautilusIconContainer *container, GList *icons)
|
|||
/* These modes are special. We freeze all of our positions
|
||||
* after we do the layout.
|
||||
*/
|
||||
/* FIXME: This should not be tied to the direction of layout.
|
||||
/* FIXME bugzilla.eazel.com 2478:
|
||||
* This should not be tied to the direction of layout.
|
||||
* It should be a separate switch.
|
||||
*/
|
||||
nautilus_icon_container_freeze_icon_positions (container);
|
||||
|
|
@ -939,7 +940,8 @@ lay_down_icons (NautilusIconContainer *container, GList *icons, double start_y)
|
|||
|
||||
case NAUTILUS_ICON_LAYOUT_T_B_L_R:
|
||||
case NAUTILUS_ICON_LAYOUT_T_B_R_L:
|
||||
/* FIXME: Need to handle T_B_R_L differently. */
|
||||
/* FIXME bugzilla.eazel.com 2479:
|
||||
* Need to handle T_B_R_L differently. */
|
||||
lay_down_icons_tblr (container, icons);
|
||||
break;
|
||||
|
||||
|
|
@ -1089,7 +1091,8 @@ nautilus_icon_container_move_icon (NautilusIconContainer *container,
|
|||
icon_raise (icon);
|
||||
}
|
||||
|
||||
/* FIXME: Handling of the scroll region is inconsistent here. In
|
||||
/* FIXME bugzilla.eazel.com 2474:
|
||||
* Handling of the scroll region is inconsistent here. In
|
||||
* the scale-changing case, relayout is called, which updates the
|
||||
* scroll region appropriately. In other cases, it's up to the
|
||||
* caller to make sure the scroll region is updated. This could
|
||||
|
|
@ -1323,7 +1326,7 @@ stop_rubberbanding (NautilusIconContainer *container,
|
|||
band_info->active = FALSE;
|
||||
|
||||
gnome_canvas_item_ungrab (band_info->selection_rectangle, event->time);
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2475: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (band_info->selection_rectangle));
|
||||
band_info->selection_rectangle = NULL;
|
||||
}
|
||||
|
|
@ -1996,7 +1999,7 @@ destroy (GtkObject *object)
|
|||
gtk_timeout_remove (container->details->rubberband_info.timer_id);
|
||||
}
|
||||
if (container->details->rubberband_info.selection_rectangle != NULL) {
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2475: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (container->details->rubberband_info.selection_rectangle));
|
||||
}
|
||||
|
||||
|
|
@ -4193,7 +4196,7 @@ hide_rename_widget (NautilusIconContainer *container, NautilusIcon *icon)
|
|||
nautilus_icon_text_item_stop_editing (container->details->rename_widget, TRUE);
|
||||
|
||||
/* Destroy renaming widget */
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2480: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (container->details->rename_widget));
|
||||
container->details->rename_widget = NULL;
|
||||
|
||||
|
|
|
|||
|
|
@ -353,7 +353,8 @@ nautilus_icon_container_dropped_icon_feedback (GtkWidget *widget,
|
|||
|
||||
/* Delete old shadow if any. */
|
||||
if (dnd_info->shadow != NULL) {
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2484:
|
||||
* Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (dnd_info->shadow));
|
||||
}
|
||||
|
||||
|
|
@ -514,7 +515,8 @@ receive_dropped_keyword (NautilusIconContainer *container, char* keyword, int x,
|
|||
return;
|
||||
}
|
||||
|
||||
/* FIXME: This does not belong in the icon code.
|
||||
/* FIXME bugzilla.eazel.com 2485:
|
||||
* This does not belong in the icon code.
|
||||
* It has to be in the file manager.
|
||||
* The icon code has no right to deal with the file directly.
|
||||
* But luckily there's no issue of not getting a file object,
|
||||
|
|
@ -610,7 +612,7 @@ auto_scroll_timeout_callback (gpointer data)
|
|||
|
||||
/* Adjust the scroll delta to the proper acceleration values depending on how far
|
||||
* into the sroll margins we are.
|
||||
* FIXME:
|
||||
* FIXME bugzilla.eazel.com 2486:
|
||||
* we could use an exponential acceleration factor here for better feel
|
||||
*/
|
||||
if (x_scroll_delta != 0) {
|
||||
|
|
@ -825,7 +827,8 @@ nautilus_icon_container_find_drop_target (NautilusIconContainer *container,
|
|||
gnome_canvas_window_to_world (GNOME_CANVAS (container),
|
||||
x, y, &world_x, &world_y);
|
||||
|
||||
/* FIXME: These "can_accept_items" tests need to be done by
|
||||
/* FIXME bugzilla.eazel.com 2485:
|
||||
* These "can_accept_items" tests need to be done by
|
||||
* the icon view, not here. This file is not supposed to know
|
||||
* that the target is a file.
|
||||
*/
|
||||
|
|
@ -995,7 +998,8 @@ nautilus_icon_dnd_update_drop_target (NautilusIconContainer *container,
|
|||
/* Find the item we hit with our drop, if any. */
|
||||
icon = nautilus_icon_container_item_at (container, world_x, world_y);
|
||||
|
||||
/* FIXME: These "can_accept_items" tests need to be done by
|
||||
/* FIXME bugzilla.eazel.com 2485:
|
||||
* These "can_accept_items" tests need to be done by
|
||||
* the icon view, not here. This file is not supposed to know
|
||||
* that the target is a file.
|
||||
*/
|
||||
|
|
@ -1099,7 +1103,8 @@ nautilus_icon_dnd_fini (NautilusIconContainer *container)
|
|||
|
||||
stop_auto_scroll (container);
|
||||
if (container->details->dnd_info->shadow != NULL) {
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2484:
|
||||
* Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (container->details->dnd_info->shadow));
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -51,7 +51,8 @@ link_set_path_name (const char *directory_path, const char *name)
|
|||
{
|
||||
const char *path_start;
|
||||
|
||||
/* FIXME: This hack is unacceptable. Either it's a URI and the
|
||||
/* FIXME bugzilla.eazel.com 2488:
|
||||
* This hack is unacceptable. Either it's a URI and the
|
||||
* file:// must be removed with the function that does that,
|
||||
* or it's a path, and there's no reason to remove the prefix.
|
||||
*/
|
||||
|
|
@ -117,7 +118,9 @@ get_link_set_document(const char *link_set_name)
|
|||
static char *
|
||||
expand_uri (const char *uri)
|
||||
{
|
||||
/* FIXME: This turns "~x" into "HOME", which is bad. */
|
||||
/* FIXME bugzilla.eazel.com 2487:
|
||||
* This turns "~x" into "HOME", which is bad.
|
||||
*/
|
||||
if (uri[0] == '~') {
|
||||
return gnome_vfs_get_uri_from_local_path (g_get_home_dir ());
|
||||
}
|
||||
|
|
|
|||
|
|
@ -239,13 +239,13 @@ nautilus_link_get_root_property (const char *link_file_uri,
|
|||
return NULL;
|
||||
}
|
||||
|
||||
/* FIXME: Works only with local link files. */
|
||||
/* FIXME bugzilla.eazel.com 2489: Works only with local link files. */
|
||||
path = gnome_vfs_get_local_path_from_uri (link_file_uri);
|
||||
if (path == NULL) {
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/* FIXME: Sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: Sync. I/O. */
|
||||
doc = xmlParseFile (path);
|
||||
g_free (path);
|
||||
property = xml_get_root_property (doc, key);
|
||||
|
|
@ -257,7 +257,7 @@ nautilus_link_get_root_property (const char *link_file_uri,
|
|||
char *
|
||||
nautilus_link_get_additional_text (const char *link_file_uri)
|
||||
{
|
||||
/* FIXME: This interface requires sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: This interface requires sync. I/O. */
|
||||
return nautilus_link_get_root_property
|
||||
(link_file_uri, NAUTILUS_METADATA_KEY_EXTRA_TEXT);
|
||||
}
|
||||
|
|
@ -274,10 +274,10 @@ make_local_path (const char *image_uri)
|
|||
* still should unescape.
|
||||
*/
|
||||
unescaped_uri = gnome_vfs_unescape_string (image_uri, "/");
|
||||
/* FIXME: Why should we unescape? The above can return NULL for
|
||||
/* FIXME bugzilla.eazel.com 2492: Why should we unescape? The above can return NULL for
|
||||
* URIs with slashes in it and other cases like that.
|
||||
*/
|
||||
/* FIXME: Why the +7 below? This seems totally wrong. */
|
||||
/* FIXME bugzilla.eazel.com 2493: Why the +7 below? This seems totally wrong. */
|
||||
escaped_uri = nautilus_str_escape_slashes (unescaped_uri + 7);
|
||||
g_free (unescaped_uri);
|
||||
|
||||
|
|
@ -287,7 +287,7 @@ make_local_path (const char *image_uri)
|
|||
NULL);
|
||||
|
||||
/* We must create the directory if it doesn't exist. */
|
||||
/* FIXME: Is it OK to ignore the error here? */
|
||||
/* FIXME bugzilla.eazel.com 2494: Is it OK to ignore the error here? */
|
||||
gnome_vfs_make_directory (local_directory_path, REMOTE_ICON_DIR_PERMISSIONS);
|
||||
|
||||
local_file_path = nautilus_make_path (local_directory_path, escaped_uri);
|
||||
|
|
@ -359,7 +359,7 @@ nautilus_link_get_image_uri (const char *link_file_uri)
|
|||
return NULL;
|
||||
}
|
||||
|
||||
/* FIXME: Works only with local URIs. */
|
||||
/* FIXME bugzilla.eazel.com 2489: Works only with local URIs. */
|
||||
path = gnome_vfs_get_local_path_from_uri (link_file_uri);
|
||||
if (path == NULL) {
|
||||
return NULL;
|
||||
|
|
@ -398,7 +398,7 @@ nautilus_link_get_image_uri (const char *link_file_uri)
|
|||
char *
|
||||
nautilus_link_get_link_uri (const char *link_file_uri)
|
||||
{
|
||||
/* FIXME: This interface requires sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: This interface requires sync. I/O. */
|
||||
return nautilus_link_get_root_property
|
||||
(link_file_uri, "LINK");
|
||||
}
|
||||
|
|
@ -407,13 +407,13 @@ nautilus_link_get_link_uri (const char *link_file_uri)
|
|||
char *
|
||||
nautilus_link_get_link_type (const char *path)
|
||||
{
|
||||
/* FIXME: This interface requires sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: This interface requires sync. I/O. */
|
||||
return nautilus_link_get_root_property
|
||||
(path, "NAUTILUS_LINK");
|
||||
}
|
||||
|
||||
/* FIXME: Caller has to know to pass in a file with a NULL character at
|
||||
* the end.
|
||||
/* FIXME bugzilla.eazel.com 2495:
|
||||
* Caller has to know to pass in a file with a NULL character at the end.
|
||||
*/
|
||||
char *
|
||||
nautilus_link_get_link_uri_given_file_contents (const char *file_contents,
|
||||
|
|
|
|||
|
|
@ -1082,7 +1082,7 @@ map_pixbuf (NautilusIconCanvasItem *icon_item)
|
|||
if (icon_item->details->is_prelit) {
|
||||
temp_pixbuf = nautilus_create_spotlight_pixbuf (icon_item->details->pixbuf);
|
||||
|
||||
/* FIXME: This hard-wired image is inappropriate to
|
||||
/* FIXME bugzilla.eazel.com 2471: This hard-wired image is inappropriate to
|
||||
* this level of code, which shouldn't know that the
|
||||
* preview is audio, nor should it have an icon
|
||||
* hard-wired in.
|
||||
|
|
@ -1204,7 +1204,8 @@ draw_label_text_aa (NautilusIconCanvasItem *icon_item, GnomeCanvasBuf *buf, doub
|
|||
}
|
||||
|
||||
if (icon_item->details->is_renaming) {
|
||||
/* FIXME: Why is it OK to leave text_height and
|
||||
/* FIXME bugzilla.eazel.com 2472:
|
||||
* Why is it OK to leave text_height and
|
||||
* text_width alone in this code path?
|
||||
*/
|
||||
return;
|
||||
|
|
@ -1339,7 +1340,8 @@ nautilus_icon_canvas_item_event (GnomeCanvasItem *item, GdkEvent *event)
|
|||
if (!icon_item->details->is_prelit) {
|
||||
icon_item->details->is_prelit = TRUE;
|
||||
gnome_canvas_item_request_update (item);
|
||||
/* FIXME: We should emit our own signal here,
|
||||
/* FIXME bugzilla.eazel.com 2473:
|
||||
* We should emit our own signal here,
|
||||
* not one from the container; it could hook
|
||||
* up to that signal and emit one of its
|
||||
* own. Doing it this way hard-codes what
|
||||
|
|
@ -1361,7 +1363,8 @@ nautilus_icon_canvas_item_event (GnomeCanvasItem *item, GdkEvent *event)
|
|||
* higlighted for drop. The latter gets turned on
|
||||
* by the drag&drop motion callback.
|
||||
*/
|
||||
/* FIXME: We should emit our own signal here,
|
||||
/* FIXME bugzilla.eazel.com 2473:
|
||||
* We should emit our own signal here,
|
||||
* not one from the containe; it could hook up
|
||||
* to that signal and emit one of its
|
||||
* ownr. Doing it this way hard-codes what
|
||||
|
|
|
|||
|
|
@ -162,7 +162,7 @@ static char stipple_bits[] = { 0x02, 0x01 };
|
|||
static void
|
||||
icon_free (NautilusIcon *icon)
|
||||
{
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2481: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (icon->item));
|
||||
g_free (icon);
|
||||
}
|
||||
|
|
@ -461,7 +461,7 @@ get_all_icon_bounds (NautilusIconContainer *container,
|
|||
double *x1, double *y1,
|
||||
double *x2, double *y2)
|
||||
{
|
||||
/* FIXME: Do we have to do something about the rubberband
|
||||
/* FIXME bugzilla.eazel.com 2477: Do we have to do something about the rubberband
|
||||
* here? Any other non-icon items?
|
||||
*/
|
||||
gnome_canvas_item_get_bounds
|
||||
|
|
@ -921,7 +921,8 @@ lay_down_icons_tblr (NautilusIconContainer *container, GList *icons)
|
|||
/* These modes are special. We freeze all of our positions
|
||||
* after we do the layout.
|
||||
*/
|
||||
/* FIXME: This should not be tied to the direction of layout.
|
||||
/* FIXME bugzilla.eazel.com 2478:
|
||||
* This should not be tied to the direction of layout.
|
||||
* It should be a separate switch.
|
||||
*/
|
||||
nautilus_icon_container_freeze_icon_positions (container);
|
||||
|
|
@ -939,7 +940,8 @@ lay_down_icons (NautilusIconContainer *container, GList *icons, double start_y)
|
|||
|
||||
case NAUTILUS_ICON_LAYOUT_T_B_L_R:
|
||||
case NAUTILUS_ICON_LAYOUT_T_B_R_L:
|
||||
/* FIXME: Need to handle T_B_R_L differently. */
|
||||
/* FIXME bugzilla.eazel.com 2479:
|
||||
* Need to handle T_B_R_L differently. */
|
||||
lay_down_icons_tblr (container, icons);
|
||||
break;
|
||||
|
||||
|
|
@ -1089,7 +1091,8 @@ nautilus_icon_container_move_icon (NautilusIconContainer *container,
|
|||
icon_raise (icon);
|
||||
}
|
||||
|
||||
/* FIXME: Handling of the scroll region is inconsistent here. In
|
||||
/* FIXME bugzilla.eazel.com 2474:
|
||||
* Handling of the scroll region is inconsistent here. In
|
||||
* the scale-changing case, relayout is called, which updates the
|
||||
* scroll region appropriately. In other cases, it's up to the
|
||||
* caller to make sure the scroll region is updated. This could
|
||||
|
|
@ -1323,7 +1326,7 @@ stop_rubberbanding (NautilusIconContainer *container,
|
|||
band_info->active = FALSE;
|
||||
|
||||
gnome_canvas_item_ungrab (band_info->selection_rectangle, event->time);
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2475: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (band_info->selection_rectangle));
|
||||
band_info->selection_rectangle = NULL;
|
||||
}
|
||||
|
|
@ -1996,7 +1999,7 @@ destroy (GtkObject *object)
|
|||
gtk_timeout_remove (container->details->rubberband_info.timer_id);
|
||||
}
|
||||
if (container->details->rubberband_info.selection_rectangle != NULL) {
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2475: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (container->details->rubberband_info.selection_rectangle));
|
||||
}
|
||||
|
||||
|
|
@ -4193,7 +4196,7 @@ hide_rename_widget (NautilusIconContainer *container, NautilusIcon *icon)
|
|||
nautilus_icon_text_item_stop_editing (container->details->rename_widget, TRUE);
|
||||
|
||||
/* Destroy renaming widget */
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2480: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (container->details->rename_widget));
|
||||
container->details->rename_widget = NULL;
|
||||
|
||||
|
|
|
|||
|
|
@ -353,7 +353,8 @@ nautilus_icon_container_dropped_icon_feedback (GtkWidget *widget,
|
|||
|
||||
/* Delete old shadow if any. */
|
||||
if (dnd_info->shadow != NULL) {
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2484:
|
||||
* Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (dnd_info->shadow));
|
||||
}
|
||||
|
||||
|
|
@ -514,7 +515,8 @@ receive_dropped_keyword (NautilusIconContainer *container, char* keyword, int x,
|
|||
return;
|
||||
}
|
||||
|
||||
/* FIXME: This does not belong in the icon code.
|
||||
/* FIXME bugzilla.eazel.com 2485:
|
||||
* This does not belong in the icon code.
|
||||
* It has to be in the file manager.
|
||||
* The icon code has no right to deal with the file directly.
|
||||
* But luckily there's no issue of not getting a file object,
|
||||
|
|
@ -610,7 +612,7 @@ auto_scroll_timeout_callback (gpointer data)
|
|||
|
||||
/* Adjust the scroll delta to the proper acceleration values depending on how far
|
||||
* into the sroll margins we are.
|
||||
* FIXME:
|
||||
* FIXME bugzilla.eazel.com 2486:
|
||||
* we could use an exponential acceleration factor here for better feel
|
||||
*/
|
||||
if (x_scroll_delta != 0) {
|
||||
|
|
@ -825,7 +827,8 @@ nautilus_icon_container_find_drop_target (NautilusIconContainer *container,
|
|||
gnome_canvas_window_to_world (GNOME_CANVAS (container),
|
||||
x, y, &world_x, &world_y);
|
||||
|
||||
/* FIXME: These "can_accept_items" tests need to be done by
|
||||
/* FIXME bugzilla.eazel.com 2485:
|
||||
* These "can_accept_items" tests need to be done by
|
||||
* the icon view, not here. This file is not supposed to know
|
||||
* that the target is a file.
|
||||
*/
|
||||
|
|
@ -995,7 +998,8 @@ nautilus_icon_dnd_update_drop_target (NautilusIconContainer *container,
|
|||
/* Find the item we hit with our drop, if any. */
|
||||
icon = nautilus_icon_container_item_at (container, world_x, world_y);
|
||||
|
||||
/* FIXME: These "can_accept_items" tests need to be done by
|
||||
/* FIXME bugzilla.eazel.com 2485:
|
||||
* These "can_accept_items" tests need to be done by
|
||||
* the icon view, not here. This file is not supposed to know
|
||||
* that the target is a file.
|
||||
*/
|
||||
|
|
@ -1099,7 +1103,8 @@ nautilus_icon_dnd_fini (NautilusIconContainer *container)
|
|||
|
||||
stop_auto_scroll (container);
|
||||
if (container->details->dnd_info->shadow != NULL) {
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2484:
|
||||
* Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (container->details->dnd_info->shadow));
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -51,7 +51,8 @@ link_set_path_name (const char *directory_path, const char *name)
|
|||
{
|
||||
const char *path_start;
|
||||
|
||||
/* FIXME: This hack is unacceptable. Either it's a URI and the
|
||||
/* FIXME bugzilla.eazel.com 2488:
|
||||
* This hack is unacceptable. Either it's a URI and the
|
||||
* file:// must be removed with the function that does that,
|
||||
* or it's a path, and there's no reason to remove the prefix.
|
||||
*/
|
||||
|
|
@ -117,7 +118,9 @@ get_link_set_document(const char *link_set_name)
|
|||
static char *
|
||||
expand_uri (const char *uri)
|
||||
{
|
||||
/* FIXME: This turns "~x" into "HOME", which is bad. */
|
||||
/* FIXME bugzilla.eazel.com 2487:
|
||||
* This turns "~x" into "HOME", which is bad.
|
||||
*/
|
||||
if (uri[0] == '~') {
|
||||
return gnome_vfs_get_uri_from_local_path (g_get_home_dir ());
|
||||
}
|
||||
|
|
|
|||
|
|
@ -239,13 +239,13 @@ nautilus_link_get_root_property (const char *link_file_uri,
|
|||
return NULL;
|
||||
}
|
||||
|
||||
/* FIXME: Works only with local link files. */
|
||||
/* FIXME bugzilla.eazel.com 2489: Works only with local link files. */
|
||||
path = gnome_vfs_get_local_path_from_uri (link_file_uri);
|
||||
if (path == NULL) {
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/* FIXME: Sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: Sync. I/O. */
|
||||
doc = xmlParseFile (path);
|
||||
g_free (path);
|
||||
property = xml_get_root_property (doc, key);
|
||||
|
|
@ -257,7 +257,7 @@ nautilus_link_get_root_property (const char *link_file_uri,
|
|||
char *
|
||||
nautilus_link_get_additional_text (const char *link_file_uri)
|
||||
{
|
||||
/* FIXME: This interface requires sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: This interface requires sync. I/O. */
|
||||
return nautilus_link_get_root_property
|
||||
(link_file_uri, NAUTILUS_METADATA_KEY_EXTRA_TEXT);
|
||||
}
|
||||
|
|
@ -274,10 +274,10 @@ make_local_path (const char *image_uri)
|
|||
* still should unescape.
|
||||
*/
|
||||
unescaped_uri = gnome_vfs_unescape_string (image_uri, "/");
|
||||
/* FIXME: Why should we unescape? The above can return NULL for
|
||||
/* FIXME bugzilla.eazel.com 2492: Why should we unescape? The above can return NULL for
|
||||
* URIs with slashes in it and other cases like that.
|
||||
*/
|
||||
/* FIXME: Why the +7 below? This seems totally wrong. */
|
||||
/* FIXME bugzilla.eazel.com 2493: Why the +7 below? This seems totally wrong. */
|
||||
escaped_uri = nautilus_str_escape_slashes (unescaped_uri + 7);
|
||||
g_free (unescaped_uri);
|
||||
|
||||
|
|
@ -287,7 +287,7 @@ make_local_path (const char *image_uri)
|
|||
NULL);
|
||||
|
||||
/* We must create the directory if it doesn't exist. */
|
||||
/* FIXME: Is it OK to ignore the error here? */
|
||||
/* FIXME bugzilla.eazel.com 2494: Is it OK to ignore the error here? */
|
||||
gnome_vfs_make_directory (local_directory_path, REMOTE_ICON_DIR_PERMISSIONS);
|
||||
|
||||
local_file_path = nautilus_make_path (local_directory_path, escaped_uri);
|
||||
|
|
@ -359,7 +359,7 @@ nautilus_link_get_image_uri (const char *link_file_uri)
|
|||
return NULL;
|
||||
}
|
||||
|
||||
/* FIXME: Works only with local URIs. */
|
||||
/* FIXME bugzilla.eazel.com 2489: Works only with local URIs. */
|
||||
path = gnome_vfs_get_local_path_from_uri (link_file_uri);
|
||||
if (path == NULL) {
|
||||
return NULL;
|
||||
|
|
@ -398,7 +398,7 @@ nautilus_link_get_image_uri (const char *link_file_uri)
|
|||
char *
|
||||
nautilus_link_get_link_uri (const char *link_file_uri)
|
||||
{
|
||||
/* FIXME: This interface requires sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: This interface requires sync. I/O. */
|
||||
return nautilus_link_get_root_property
|
||||
(link_file_uri, "LINK");
|
||||
}
|
||||
|
|
@ -407,13 +407,13 @@ nautilus_link_get_link_uri (const char *link_file_uri)
|
|||
char *
|
||||
nautilus_link_get_link_type (const char *path)
|
||||
{
|
||||
/* FIXME: This interface requires sync. I/O. */
|
||||
/* FIXME bugzilla.eazel.com 2490: This interface requires sync. I/O. */
|
||||
return nautilus_link_get_root_property
|
||||
(path, "NAUTILUS_LINK");
|
||||
}
|
||||
|
||||
/* FIXME: Caller has to know to pass in a file with a NULL character at
|
||||
* the end.
|
||||
/* FIXME bugzilla.eazel.com 2495:
|
||||
* Caller has to know to pass in a file with a NULL character at the end.
|
||||
*/
|
||||
char *
|
||||
nautilus_link_get_link_uri_given_file_contents (const char *file_contents,
|
||||
|
|
|
|||
|
|
@ -236,7 +236,7 @@ nautilus_sidebar_title_select_text_color (NautilusSidebarTitle *sidebar_title)
|
|||
sidebar = GTK_WIDGET (sidebar)->parent;
|
||||
background = nautilus_get_widget_background (sidebar);
|
||||
|
||||
/* FIXME: for now, both the title and info colors are the same */
|
||||
/* FIXME bugzilla.eazel.com 2496: for now, both the title and info colors are the same */
|
||||
if (nautilus_background_is_dark (background)) {
|
||||
sidebar_title_color = g_strdup("rgb:FFFF/FFFF/FFFF");
|
||||
sidebar_info_title_color = g_strdup("rgb:FFFF/FFFF/FFFF");
|
||||
|
|
@ -320,14 +320,14 @@ update_font (NautilusSidebarTitle *sidebar_title)
|
|||
* factory and be failsafe if the given font is not found.
|
||||
*/
|
||||
|
||||
/* FIXME: Where does the "4" come from? */
|
||||
/* FIXME bugzilla.eazel.com 2497: Where does the "4" come from? */
|
||||
label_font = nautilus_get_largest_fitting_font
|
||||
(sidebar_title->details->title_text,
|
||||
GTK_WIDGET (sidebar_title)->allocation.width - 4,
|
||||
"-adobe-helvetica-bold-r-normal-*-%d-*-*-*-*-*-*-*");
|
||||
|
||||
nautilus_gtk_widget_set_font (sidebar_title->details->normal_title_label, label_font);
|
||||
/* FIXME: Is there a font leak here? */
|
||||
/* FIXME bugzilla.eazel.com 2499: Is there a font leak here? */
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -335,7 +335,7 @@ update_font (NautilusSidebarTitle *sidebar_title)
|
|||
static void
|
||||
update_title (NautilusSidebarTitle *sidebar_title)
|
||||
{
|
||||
/* FIXME: We could defer showing the title until the icon is ready. */
|
||||
/* FIXME bugzilla.eazel.com 2500: We could defer showing the title until the icon is ready. */
|
||||
|
||||
if (sidebar_title->details->smooth_graphics) {
|
||||
nautilus_label_set_text (NAUTILUS_LABEL (sidebar_title->details->smooth_title_label),
|
||||
|
|
@ -371,7 +371,7 @@ update_more_info (NautilusSidebarTitle *sidebar_title)
|
|||
|
||||
file = sidebar_title->details->file;
|
||||
|
||||
/* FIXME: We could defer showing info until the icon is ready. */
|
||||
/* FIXME bugzilla.eazel.com 2500: We could defer showing info until the icon is ready. */
|
||||
|
||||
info_string = g_string_new (NULL);
|
||||
type_string = nautilus_file_get_string_attribute (file, "type");
|
||||
|
|
@ -419,7 +419,7 @@ update_emblems (NautilusSidebarTitle *sidebar_title)
|
|||
GList *icons, *p;
|
||||
GdkPixbuf *pixbuf;
|
||||
|
||||
/* FIXME: We could defer showing emblems until the icon is ready. */
|
||||
/* FIXME bugzilla.eazel.com 2500: We could defer showing emblems until the icon is ready. */
|
||||
|
||||
/* First, deallocate any existing ones */
|
||||
gtk_container_foreach (GTK_CONTAINER (sidebar_title->details->emblem_box),
|
||||
|
|
@ -450,7 +450,7 @@ update_notes (NautilusSidebarTitle *sidebar_title)
|
|||
{
|
||||
char *text;
|
||||
|
||||
/* FIXME: We could defer showing notes until the icon is ready. */
|
||||
/* FIXME bugzilla.eazel.com 2500: We could defer showing notes until the icon is ready. */
|
||||
|
||||
text = nautilus_file_get_metadata (sidebar_title->details->file,
|
||||
NAUTILUS_METADATA_KEY_NOTES,
|
||||
|
|
|
|||
Loading…
Reference in a new issue