gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-06-30 23:46:35 +00:00
Code Issues Projects Releases Wiki Activity

placessidebar: Update enum symbol

Browse Source 
Around the 3.0 release, the sidebar featured section headers and there
was a section whose header was "Computer".

We still carry that name in an enum symbol. It makes no sense nowadays
if you don't know the history. So, let's rename it to the name by
which it is informally called in current design mockups.
This commit is contained in:
António Fernandes 2024-06-09 18:15:20 +01:00
parent 5c2f55663a
commit 6636a22ffd
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/gtk/nautilusgtkplacessidebar.c
View File

@ -684,7 +684,7 @@ update_places (NautilusGtkPlacesSidebar *sidebar)
home_uri = get_home_directory_uri ();
start_icon = g_themed_icon_new_with_default_fallbacks (ICON_NAME_HOME);
add_place (sidebar, NAUTILUS_GTK_PLACES_BUILT_IN,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
_("Home"), start_icon, NULL, home_uri,
NULL, NULL, NULL, NULL, 0,
_("Open Personal Folder"));
@ -695,7 +695,7 @@ update_places (NautilusGtkPlacesSidebar *sidebar)
{
start_icon = g_themed_icon_new_with_default_fallbacks ("document-open-recent-symbolic");
add_place (sidebar, NAUTILUS_GTK_PLACES_BUILT_IN,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
_("Recent"), start_icon, NULL, SCHEME_RECENT ":///",
NULL, NULL, NULL, NULL, 0,
_("Recent Files"));
@ -704,7 +704,7 @@ update_places (NautilusGtkPlacesSidebar *sidebar)
start_icon = g_themed_icon_new_with_default_fallbacks ("starred-symbolic");
add_place (sidebar, NAUTILUS_GTK_PLACES_STARRED_LOCATION,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
_("Starred"), start_icon, NULL, SCHEME_STARRED ":///",
NULL, NULL, NULL, NULL, 0,
_("Starred Files"));
@ -718,7 +718,7 @@ update_places (NautilusGtkPlacesSidebar *sidebar)
{
start_icon = g_themed_icon_new_with_default_fallbacks (ICON_NAME_DESKTOP);
add_place (sidebar, NAUTILUS_GTK_PLACES_BUILT_IN,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
_("Desktop"), start_icon, NULL, mount_uri,
NULL, NULL, NULL, NULL, 0,
_("Open the contents of your desktop in a folder"));
@ -730,7 +730,7 @@ update_places (NautilusGtkPlacesSidebar *sidebar)
/* Network view */
start_icon = g_themed_icon_new_with_default_fallbacks (ICON_NAME_NETWORK_VIEW);
add_place (sidebar, NAUTILUS_GTK_PLACES_BUILT_IN,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
_("Network"), start_icon, NULL, SCHEME_NETWORK_VIEW ":///",
NULL, NULL, NULL, NULL, 0,
_("Open Network Locations"));
@ -739,7 +739,7 @@ update_places (NautilusGtkPlacesSidebar *sidebar)
/* Trash */
start_icon = nautilus_trash_monitor_get_symbolic_icon ();
sidebar->trash_row = add_place (sidebar, NAUTILUS_GTK_PLACES_BUILT_IN,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
_("Trash"), start_icon, NULL, SCHEME_TRASH ":///",
NULL, NULL, NULL, NULL, 0,
_("Open Trash"));
@ -3229,7 +3229,7 @@ list_box_sort_func (GtkListBoxRow *row1,
if (section_type_1 == section_type_2)
{
if (section_type_1 == NAUTILUS_GTK_PLACES_SECTION_COMPUTER &&
if (section_type_1 == NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS &&
place_type_1 == place_type_2 &&
place_type_1 == NAUTILUS_GTK_PLACES_XDG_DIR)
{

2
src/gtk/nautilusgtkplacessidebarprivate.h
View File

@ -88,7 +88,7 @@ void nautilus_gtk_places_sidebar_set_drop_targets_visible (Nauti
/* Keep order, since it's used for the sort functions */
typedef enum {
NAUTILUS_GTK_PLACES_SECTION_INVALID,
NAUTILUS_GTK_PLACES_SECTION_COMPUTER,
NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS,
NAUTILUS_GTK_PLACES_SECTION_BOOKMARKS,
NAUTILUS_GTK_PLACES_SECTION_CLOUD,
NAUTILUS_GTK_PLACES_SECTION_MOUNTS,

2
src/gtk/nautilusgtksidebarrow.c
View File

@ -336,7 +336,7 @@ nautilus_gtk_sidebar_row_set_property (GObject *object,
case PROP_SECTION_TYPE:
self->section_type = g_value_get_enum (value);
if (self->section_type == NAUTILUS_GTK_PLACES_SECTION_COMPUTER)
if (self->section_type == NAUTILUS_GTK_PLACES_SECTION_DEFAULT_LOCATIONS)
gtk_label_set_ellipsize (GTK_LABEL (self->label_widget), PANGO_ELLIPSIZE_NONE);
else
gtk_label_set_ellipsize (GTK_LABEL (self->label_widget), PANGO_ELLIPSIZE_END);