mirror of
https://gitlab.gnome.org/GNOME/nautilus
synced 2024-11-05 16:04:31 +00:00
Added bug numbers for FIXMEs
* components/services/install/lib/eazel-install-protocols.c: (eazel_install_fetch_package): * components/services/login/nautilus-view/nautilus-login-view.c: (nautilus_login_view_initialize): * components/services/summary/nautilus-view/nautilus-summary-view.c : (authn_cb_succeeded), (authn_cb_failed), (login_button_cb), (nautilus_summary_view_initialize): * components/tree/libmain.c: (tree_shlib_object_destroyed): * components/tree/nautilus-tree-view.c: * libnautilus-extensions/nautilus-link.c: (make_local_path): * libnautilus-extensions/nautilus-search-bar-criterion.c: (make_emblem_value_menu): * src/file-manager/fm-directory-view.c: (add_open_with_gtk_menu_item): * src/nautilus-search-bar-criterion.c: (make_emblem_value_menu), (emblems_changed_callback): Added bug numbers for FIXMEs
This commit is contained in:
Maciej Stachowiak
parent
72fb6ec09e
commit
62e426c199
13 changed files with 53 additions and 22 deletions
21
ChangeLog
21
ChangeLog
|
|
@ -1,3 +1,24 @@
|
|||
2000-09-03 Maciej Stachowiak <mjs@eazel.com>
|
||||
|
||||
* components/services/install/lib/eazel-install-protocols.c:
|
||||
(eazel_install_fetch_package):
|
||||
* components/services/login/nautilus-view/nautilus-login-view.c:
|
||||
(nautilus_login_view_initialize):
|
||||
* components/services/summary/nautilus-view/nautilus-summary-view.c
|
||||
: (authn_cb_succeeded), (authn_cb_failed), (login_button_cb),
|
||||
(nautilus_summary_view_initialize):
|
||||
* components/tree/libmain.c: (tree_shlib_object_destroyed):
|
||||
* components/tree/nautilus-tree-view.c:
|
||||
* libnautilus-extensions/nautilus-link.c: (make_local_path):
|
||||
* libnautilus-extensions/nautilus-search-bar-criterion.c:
|
||||
(make_emblem_value_menu):
|
||||
* src/file-manager/fm-directory-view.c:
|
||||
(add_open_with_gtk_menu_item):
|
||||
* src/nautilus-search-bar-criterion.c: (make_emblem_value_menu),
|
||||
(emblems_changed_callback):
|
||||
|
||||
Added bug numbers for FIXMEs
|
||||
|
||||
2000-09-03 Pavel Cisler <pavel@eazel.com>
|
||||
|
||||
* libnautilus-extensions/nautilus-directory-notify.h:
|
||||
|
|
|
|||
|
|
@ -527,8 +527,7 @@ eazel_install_fetch_package (EazelInstall *service,
|
|||
#ifndef EAZEL_INSTALL_SLIM
|
||||
md5_get_digest_from_file (package, md5);
|
||||
/*
|
||||
FIXME: bugzilla.eazel.c 2241
|
||||
until we get the md5 set in the xml parse, don't md5 check it
|
||||
FIXME bugzilla.eazel.com 2241: until we get the md5 set in the xml parse, don't md5 check it
|
||||
|
||||
if (strncmp (package->md5, md5, 16)!=0) {
|
||||
g_warning (_("MD5 mismatch, package may be compromised"));
|
||||
|
|
|
|||
|
|
@ -418,7 +418,10 @@ nautilus_login_view_initialize (NautilusLoginView *view)
|
|||
CORBA_exception_init (&ev);
|
||||
view->details->user_control = (EazelProxy_UserControl) oaf_activate_from_id (IID_EAZELPROXY, 0, NULL, &ev);
|
||||
if ( CORBA_NO_EXCEPTION != ev._major ) {
|
||||
/* FIXME user should be warned that Ammonite may not be installed */
|
||||
/* FIXME bugzilla.eazel.com 2740: user should be
|
||||
* warned that Ammonite may not be installed
|
||||
*/
|
||||
|
||||
g_warning ("Couldn't instantiate eazel-proxy");
|
||||
view->details->user_control = CORBA_OBJECT_NIL;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -464,7 +464,7 @@ authn_cb_succeeded (const EazelProxy_User *user, gpointer state, CORBA_Environme
|
|||
view->details->pending_operation = Pending_None;
|
||||
gtk_widget_set_sensitive (view->details->login_button, TRUE);
|
||||
|
||||
/* FIXME-- what now? */
|
||||
/* FIXME bugzilla.eazel.com 2743: what now? */
|
||||
|
||||
g_message ("Login succeeded");
|
||||
|
||||
|
|
@ -483,7 +483,7 @@ authn_cb_failed (const EazelProxy_User *user, const EazelProxy_AuthnFailInfo *in
|
|||
view->details->pending_operation = Pending_None;
|
||||
gtk_widget_set_sensitive (view->details->login_button, TRUE);
|
||||
|
||||
/* FIXME-- what now? */
|
||||
/* FIXME bugzilla.eazel.com 2744: what now? */
|
||||
|
||||
g_message ("Login FAILED");
|
||||
|
||||
|
|
@ -534,7 +534,7 @@ login_button_cb (GtkWidget *button, NautilusSummaryView *view)
|
|||
|
||||
if (CORBA_NO_EXCEPTION != ev._major) {
|
||||
g_warning ("Exception during EazelProxy login");
|
||||
/* FIXME cleanup after fail here */
|
||||
/* FIXME bugzilla.eazel.com 2745: cleanup after fail here */
|
||||
}
|
||||
|
||||
g_free (user_name);
|
||||
|
|
@ -671,7 +671,7 @@ nautilus_summary_view_initialize (NautilusSummaryView *view)
|
|||
view->details->user_control = (EazelProxy_UserControl) oaf_activate_from_id (IID_EAZELPROXY, 0, NULL, &ev);
|
||||
|
||||
if ( CORBA_NO_EXCEPTION != ev._major ) {
|
||||
/* FIXME user should be warned that Ammonite may not be installed */
|
||||
/* FIXME bugzilla.eazel.com 2740: user should be warned that Ammonite may not be installed */
|
||||
g_warning ("Couldn't instantiate eazel-proxy\n");
|
||||
view->details->user_control = CORBA_OBJECT_NIL;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -464,7 +464,7 @@ authn_cb_succeeded (const EazelProxy_User *user, gpointer state, CORBA_Environme
|
|||
view->details->pending_operation = Pending_None;
|
||||
gtk_widget_set_sensitive (view->details->login_button, TRUE);
|
||||
|
||||
/* FIXME-- what now? */
|
||||
/* FIXME bugzilla.eazel.com 2743: what now? */
|
||||
|
||||
g_message ("Login succeeded");
|
||||
|
||||
|
|
@ -483,7 +483,7 @@ authn_cb_failed (const EazelProxy_User *user, const EazelProxy_AuthnFailInfo *in
|
|||
view->details->pending_operation = Pending_None;
|
||||
gtk_widget_set_sensitive (view->details->login_button, TRUE);
|
||||
|
||||
/* FIXME-- what now? */
|
||||
/* FIXME bugzilla.eazel.com 2744: what now? */
|
||||
|
||||
g_message ("Login FAILED");
|
||||
|
||||
|
|
@ -534,7 +534,7 @@ login_button_cb (GtkWidget *button, NautilusSummaryView *view)
|
|||
|
||||
if (CORBA_NO_EXCEPTION != ev._major) {
|
||||
g_warning ("Exception during EazelProxy login");
|
||||
/* FIXME cleanup after fail here */
|
||||
/* FIXME bugzilla.eazel.com 2745: cleanup after fail here */
|
||||
}
|
||||
|
||||
g_free (user_name);
|
||||
|
|
@ -671,7 +671,7 @@ nautilus_summary_view_initialize (NautilusSummaryView *view)
|
|||
view->details->user_control = (EazelProxy_UserControl) oaf_activate_from_id (IID_EAZELPROXY, 0, NULL, &ev);
|
||||
|
||||
if ( CORBA_NO_EXCEPTION != ev._major ) {
|
||||
/* FIXME user should be warned that Ammonite may not be installed */
|
||||
/* FIXME bugzilla.eazel.com 2740: user should be warned that Ammonite may not be installed */
|
||||
g_warning ("Couldn't instantiate eazel-proxy\n");
|
||||
view->details->user_control = CORBA_OBJECT_NIL;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -39,7 +39,7 @@
|
|||
static void
|
||||
tree_shlib_object_destroyed (GtkObject *object)
|
||||
{
|
||||
/* FIXME: oaf_plugin_unuse can't possibly work! this sucks */
|
||||
/* FIXME bugzilla.eazel.com 2736: oaf_plugin_unuse can't possibly work! this sucks */
|
||||
#if 0
|
||||
oaf_plugin_unuse (gtk_object_get_user_data (object));
|
||||
#endif
|
||||
|
|
|
|||
|
|
@ -939,8 +939,16 @@ nautilus_tree_view_initialize (NautilusTreeView *view)
|
|||
static void
|
||||
disconnect_model_handlers (NautilusTreeView *view)
|
||||
{
|
||||
/* stop monitoring all the nodes, then stop monitoring the
|
||||
whole */
|
||||
NautilusTreeNode *node;
|
||||
|
||||
node = nautilus_tree_model_get_node (view->details->model,
|
||||
"file:///");
|
||||
|
||||
if (node != NULL) {
|
||||
nautilus_tree_model_stop_monitoring_node_recursive (view->details->model,
|
||||
node,
|
||||
view);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
|
|
|
|||
|
|
@ -288,7 +288,7 @@ make_local_path (const char *image_uri)
|
|||
|
||||
/* We must create the directory if it doesn't exist. */
|
||||
/* FIXME bugzilla.eazel.com 2494: Is it OK to ignore the error here? */
|
||||
/* FIXME: This needs to make the path into a URI if it's going to use gnome_vfs. */
|
||||
/* FIXME bugzilla.eazel.com 2737: This needs to make the path into a URI if it's going to use gnome_vfs. */
|
||||
gnome_vfs_make_directory (local_directory_path, REMOTE_ICON_DIR_PERMISSIONS);
|
||||
|
||||
local_file_path = nautilus_make_path (local_directory_path, escaped_uri);
|
||||
|
|
|
|||
|
|
@ -699,7 +699,7 @@ make_emblem_value_menu (NautilusSearchBarCriterion *criterion)
|
|||
GtkWidget *value_option_menu, *value_menu;
|
||||
|
||||
/* Add the items to the emblems menu here */
|
||||
/* FIXME: What are the variables for thumbnail icon height and width */
|
||||
/* FIXME bugzilla.eazel.com 2738: What are the variables for thumbnail icon height and width */
|
||||
value_option_menu = gtk_option_menu_new ();
|
||||
value_menu = gtk_menu_new ();
|
||||
customization_data = nautilus_customization_data_new ("emblems",
|
||||
|
|
|
|||
|
|
@ -288,7 +288,7 @@ make_local_path (const char *image_uri)
|
|||
|
||||
/* We must create the directory if it doesn't exist. */
|
||||
/* FIXME bugzilla.eazel.com 2494: Is it OK to ignore the error here? */
|
||||
/* FIXME: This needs to make the path into a URI if it's going to use gnome_vfs. */
|
||||
/* FIXME bugzilla.eazel.com 2737: This needs to make the path into a URI if it's going to use gnome_vfs. */
|
||||
gnome_vfs_make_directory (local_directory_path, REMOTE_ICON_DIR_PERMISSIONS);
|
||||
|
||||
local_file_path = nautilus_make_path (local_directory_path, escaped_uri);
|
||||
|
|
|
|||
|
|
@ -699,7 +699,7 @@ make_emblem_value_menu (NautilusSearchBarCriterion *criterion)
|
|||
GtkWidget *value_option_menu, *value_menu;
|
||||
|
||||
/* Add the items to the emblems menu here */
|
||||
/* FIXME: What are the variables for thumbnail icon height and width */
|
||||
/* FIXME bugzilla.eazel.com 2738: What are the variables for thumbnail icon height and width */
|
||||
value_option_menu = gtk_option_menu_new ();
|
||||
value_menu = gtk_menu_new ();
|
||||
customization_data = nautilus_customization_data_new ("emblems",
|
||||
|
|
|
|||
|
|
@ -2448,7 +2448,7 @@ append_selection_menu_subtree (FMDirectoryView *view,
|
|||
GTK_WIDGET (child_menu));
|
||||
}
|
||||
|
||||
/* FIXME: John, you bozo, explain this confusing function in a comment
|
||||
/* FIXME bugzilla.eazel.com 2734: John, you bozo, explain this confusing function in a comment
|
||||
* or redesign it out of existence.
|
||||
*/
|
||||
void
|
||||
|
|
@ -2578,7 +2578,7 @@ add_open_with_gtk_menu_item (GtkMenu *menu, const char *label)
|
|||
{
|
||||
GtkWidget *menu_item;
|
||||
|
||||
/* FIXME: This is only called to add a separator? */
|
||||
/* FIXME bugzilla.eazel.com 2735: This is only called to add a separator? */
|
||||
if (label != NULL) {
|
||||
menu_item = gtk_menu_item_new_with_label (label);
|
||||
} else {
|
||||
|
|
|
|||
|
|
@ -712,7 +712,7 @@ make_emblem_value_menu (NautilusSearchBarCriterion *criterion)
|
|||
GtkWidget *value_menu;
|
||||
|
||||
/* Add the items to the emblems menu here */
|
||||
/* FIXME: What are the variables for thumbnail icon height and width */
|
||||
/* FIXME bugzilla.eazel.com 2738: What are the variables for thumbnail icon height and width */
|
||||
|
||||
value_menu = gtk_menu_new ();
|
||||
customization_data = nautilus_customization_data_new ("emblems",
|
||||
|
|
@ -751,7 +751,7 @@ emblems_changed_callback (GtkObject *signaller,
|
|||
NautilusSearchBarCriterion *criterion;
|
||||
GtkWidget *menu_widget;
|
||||
|
||||
/* FIXME: check type here in some way */
|
||||
/* FIXME bugzilla.eazel.com 2739: check type here in some way */
|
||||
criterion = NAUTILUS_SEARCH_BAR_CRITERION (data);
|
||||
|
||||
if (criterion->details->type == NAUTILUS_EMBLEM_SEARCH_CRITERION) {
|
||||
|
|
|
|||
Loading…
Reference in a new issue